You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Brian Behlendorf <br...@collab.net> on 2001/09/04 17:37:42 UTC
Re: Commit
On Sun, 2 Sep 2001 svn@svn.collab.net wrote:
> Author: joe
> Date: 2001-09-02 19:59 GMT
>
> Modified: trunk/subversion/clients/cmdline/diff.c trunk/subversion/clients/cmdline/diff-cmd.c trunk/subversion/clients/cmdline/trace-update.c trunk/subversion/clients/cmdline/propget-cmd.c trunk/subversion/clients/cmdline/propset-cmd.c
> Log:
> Use the SVN_ERR macro. (no functional changes)
a) could we include more info in the Subject line about what was changed?
E.g.
Subject: commit: trunk/subversion/clients/cmdline diff.c diff-cmd.c trace-update.c propget-cmd.c propset-cmd.c
b) could we set the "from" header to come from user@devhost? Either
something like joe@svn.collab.net, or since this is the same UID as on
tigris.org, joe@tigris.org...
Let me know if these aren't quick hacks and I should enter them into the
bugdb...
Brian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Commit
Posted by Ben Collins-Sussman <su...@collab.net>.
Garrett Rooney <ro...@electricjellyfish.net> writes:
> > Commit: Revision 35: foo.c bar.c baz.h [...]
> >
> > So we can keep "35" as the unique commit identifier, and people can
> > still search for filenames in subjects.
>
> out of curiosity, what's the advantage to having the rev number in the
> subject? it strikes me that if you need the rev #, you're probably
> looking at the rest of the email that describes the changes, so you
> could just put it there. i imagine you could use it to order the
> mails, but they're dated, so that's not really necessary...
You should look at our commit mails. The body already contains the
author, date, revision number, modified files, log message, and
unified diff. Absolutely everything is in there. Really, this is a
bikeshed discussion about "what's a convenient subject line?".
Anything in the subject line is already redundant.
That said, we're trying to promote a habit of talking about commits as
unique objects. Really, "revision 35" is the name of a certain
changeset. In the same way we talk about "issue 480", it's nice to be
able to say "oh yeah, revision 35 fixed issue 480."
Of course, the *other* reason we want the revision number in the
subject line is threading. Dates aren't enough. We need clean
subjects for clean threading.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Commit
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Tue, Sep 04, 2001 at 12:52:24PM -0500, Ben Collins-Sussman wrote:
> Garrett Rooney <ro...@electricjellyfish.net> writes:
>
> > honestly, on larger projects, i find that information very useful.
> >
> > it's very convenient to be able to filter based on the files that were
> > modified [...]
>
> So maybe the compromise is to have subject lines like
>
> Commit: Revision 35: foo.c bar.c baz.h [...]
>
> So we can keep "35" as the unique commit identifier, and people can
> still search for filenames in subjects.
out of curiosity, what's the advantage to having the rev number in the
subject? it strikes me that if you need the rev #, you're probably
looking at the rest of the email that describes the changes, so you
could just put it there. i imagine you could use it to order the
mails, but they're dated, so that's not really necessary...
--
garrett rooney Unix was not designed to stop you from
rooneg@electricjellyfish.net doing stupid things, because that would
http://electricjellyfish.net/ stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Commit
Posted by Ben Collins-Sussman <su...@collab.net>.
Garrett Rooney <ro...@electricjellyfish.net> writes:
> honestly, on larger projects, i find that information very useful.
>
> it's very convenient to be able to filter based on the files that were
> modified [...]
So maybe the compromise is to have subject lines like
Commit: Revision 35: foo.c bar.c baz.h [...]
So we can keep "35" as the unique commit identifier, and people can
still search for filenames in subjects.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Commit
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
> > E.g.
> >
> > Subject: commit: trunk/subversion/clients/cmdline diff.c diff-cmd.c
> > trace-update.c propget-cmd.c propset-cmd.c
>
> Maybe you disagree with us here; we don't think seeing a list of 10+
> files in a subject line is useful. It's just a lot of clutter. The
> only reason CVS commit mails do this (or so we *thought*) is to give
> mostly-unique names to mails, and to allow them to be threaded. But
> we just accomplished that by putting the global revision number into
> the subject line.
honestly, on larger projects, i find that information very useful.
it's very convenient to be able to filter based on the files that were
modified (speaking in the "i only read the mail i'm interested in",
not the "i procmail it out" sense). for example, i only read like 10%
of the FreeBSD commit mails, since i'm only interested in some parts
of the project.
granted, i'm not even subscribed to the svn commits list, so my
opinion doesn't matter that much ;-)
--
garrett rooney Unix was not designed to stop you from
rooneg@electricjellyfish.net doing stupid things, because that would
http://electricjellyfish.net/ stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Commit
Posted by Brian Behlendorf <br...@collab.net>.
On 4 Sep 2001, Ben Collins-Sussman wrote:
> Brian Behlendorf <br...@collab.net> writes:
>
> > E.g.
> >
> > Subject: commit: trunk/subversion/clients/cmdline diff.c diff-cmd.c
> > trace-update.c propget-cmd.c propset-cmd.c
>
> Maybe you disagree with us here; we don't think seeing a list of 10+
> files in a subject line is useful. It's just a lot of clutter.
I follow the commit lists on about 20 projects, into my main inbox. When
I start reading email in the morning I sort by subject to follow threads,
sometimes surfing the thread index looking for interesting things to
start. A subject line that tells me what project the commit was for
(trunk/subversion) and what rough section of the code (clients/cmdline) is
very useful to me, both for subject-line-surfing reasons and for grouping
together commits around related parts of code. This is also true for
those commit lists I channel off to side mailboxes and read once a month
or so. So this goes beyond just threading.
> > b) could we set the "from" header to come from user@devhost? Either
> > something like joe@svn.collab.net, or since this is the same UID as on
> > tigris.org, joe@tigris.org...
>
> Hmmm. Right now, httpd is running as user "svn", and thus this is the
> user that is exectuing the post-commit mail script. Maybe there are
> options the script could pass to /usr/bin/mail that change the "from"
> header? Anyone?
Just put a "From:" header in the commit message, above the Subject line,
and that should be good enough, no? At least that works if you call
sendmail instead of mail, which I would do anyways...
Brian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: Commit
Posted by Sander Striker <st...@apache.org>.
> Brian Behlendorf <br...@collab.net> writes:
>
> > a) could we include more info in the Subject line about what
> was changed?
>
> Mike and I just changed commit mails to have subject lines of:
>
> "Commit -- Revision N"
>
> So now they can be uniquely discussed and threaded by your mailer.
>
> > E.g.
> >
> > Subject: commit: trunk/subversion/clients/cmdline diff.c diff-cmd.c
> > trace-update.c propget-cmd.c propset-cmd.c
>
> Maybe you disagree with us here; we don't think seeing a list of 10+
> files in a subject line is useful. It's just a lot of clutter. The
> only reason CVS commit mails do this (or so we *thought*) is to give
> mostly-unique names to mails, and to allow them to be threaded. But
> we just accomplished that by putting the global revision number into
> the subject line.
Having 'modified directories' on the subject line could be convenient
for human filtering...
> > b) could we set the "from" header to come from user@devhost? Either
> > something like joe@svn.collab.net, or since this is the same UID as on
> > tigris.org, joe@tigris.org...
>
> Hmmm. Right now, httpd is running as user "svn", and thus this is the
> user that is exectuing the post-commit mail script. Maybe there are
> options the script could pass to /usr/bin/mail that change the "from"
> header? Anyone?
I've been looking into a self contained commit mailer (ie. that connects
to port 25 etc). Maybe doing one using apr would be a good idea. I'll
look into that later.
For now, doesn't sendmail have the option of specifying the From: ?
[there was something about passing the entire mail plus headers to
sendmail... Ofcourse then you would have to run sendmail or something
with a similar feature. 'mail' won't do.]
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [SVN-DEV] Re: Commit
Posted by "C. Scott Ananian" <ca...@lesser-magoo.lcs.mit.edu>.
On 4 Sep 2001, Ben Collins-Sussman wrote:
> Maybe you disagree with us here; we don't think seeing a list of 10+
> files in a subject line is useful. It's just a lot of clutter. The
> only reason CVS commit mails do this (or so we *thought*) is to give
> mostly-unique names to mails, and to allow them to be threaded. But
> we just accomplished that by putting the global revision number into
> the subject line.
Well, in a large project (such as the ones I run) I like to be able to
ignore commits which happen in 'other people's parts' of the code, and pay
careful attention to commits in parts of the code I know well. (Rewrite
the sentence to make sense w.r.t. SVN's "anti-territoriality", but you
should know what I mean.) If I'm working on (say) libsvn_subr, I'd like
to know when people make changes that might affect my code. I agree that
filenames can be unuseful, but *directories* (or at least the 'module
name' of the repository) can be very useful.
--s
> Hmmm. Right now, httpd is running as user "svn", and thus this is the
> user that is exectuing the post-commit mail script. Maybe there are
> options the script could pass to /usr/bin/mail that change the "from"
> header? Anyone?
Interface to 'sendmail' instead of mail and pass in a fully-formed mail
message, complete with the desired 'From:' header. See the standard CVS
commitlog scripts for details (or write me).
--s
SSBN 731 assassinate pending agent OVER THE HORIZON RADAR insurgent
class struggle Yeltsin Rijndael NORAD Japan terrorist Serbian domestic disruption
( http://lesser-magoo.lcs.mit.edu/~cananian )
--
"These students are going to have to find out what law and order is
all about." -- Brig. General Robert Canterbury, Noon, May 4, 1970,
minutes before his troops shot 13 unarmed Kent State students, killing 4.
--
[http://www.cs.cmu.edu/~dst/DeCSS/Gallery/]
#!/usr/bin/perl -w
# 526-byte qrpff, Keith Winstein and Marc Horowitz <si...@mit.edu>
# MPEG 2 PS VOB file on stdin -> descrambled output on stdout
# arguments: title key bytes in least to most-significant order
$_='while(read+STDIN,$_,2048){$a=29;$c=142;if((@a=unx"C*",$_)[20]&48){$h=5;
$_=unxb24,join"",@b=map{xB8,unxb8,chr($_^$a[--$h+84])}@ARGV;s/...$/1$&/;$d=
unxV,xb25,$_;$b=73;$e=256|(ord$b[4])<<9|ord$b[3];$d=$d>>8^($f=($t=255)&($d
>>12^$d>>4^$d^$d/8))<<17,$e=$e>>8^($t&($g=($q=$e>>14&7^$e)^$q*8^$q<<6))<<9
,$_=(map{$_%16or$t^=$c^=($m=(11,10,116,100,11,122,20,100)[$_/16%8])&110;$t
^=(72,@z=(64,72,$a^=12*($_%16-2?0:$m&17)),$b^=$_%64?12:0,@z)[$_%8]}(16..271))
[$_]^(($h>>=8)+=$f+(~$g&$t))for@a[128..$#a]}print+x"C*",@a}';s/x/pack+/g;eval
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Commit
Posted by Ben Collins-Sussman <su...@collab.net>.
Brian Behlendorf <br...@collab.net> writes:
> a) could we include more info in the Subject line about what was changed?
Mike and I just changed commit mails to have subject lines of:
"Commit -- Revision N"
So now they can be uniquely discussed and threaded by your mailer.
> E.g.
>
> Subject: commit: trunk/subversion/clients/cmdline diff.c diff-cmd.c
> trace-update.c propget-cmd.c propset-cmd.c
Maybe you disagree with us here; we don't think seeing a list of 10+
files in a subject line is useful. It's just a lot of clutter. The
only reason CVS commit mails do this (or so we *thought*) is to give
mostly-unique names to mails, and to allow them to be threaded. But
we just accomplished that by putting the global revision number into
the subject line.
> b) could we set the "from" header to come from user@devhost? Either
> something like joe@svn.collab.net, or since this is the same UID as on
> tigris.org, joe@tigris.org...
Hmmm. Right now, httpd is running as user "svn", and thus this is the
user that is exectuing the post-commit mail script. Maybe there are
options the script could pass to /usr/bin/mail that change the "from"
header? Anyone?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org