[storm] branch 2.1.x-branch updated: [STORM-3568] prevent user from changing log level with empty logger name from topo UI

[et...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ethanli pushed a commit to branch 2.1.x-branch
in repository https://gitbox.apache.org/repos/asf/storm.git


The following commit(s) were added to refs/heads/2.1.x-branch by this push:
     new 4b8e0ab  [STORM-3568] prevent user from changing log level with empty logger name from topo UI
     new f4ace6f  Merge pull request #3198 from RuiLi8080/storm-3568-2.1
4b8e0ab is described below

commit 4b8e0ab4ab3eeea6e7ded010c75daf47b19fb597
Author: Rui Li <ru...@verizonmedia.com>
AuthorDate: Fri Jan 17 15:34:10 2020 -0600

    [STORM-3568] prevent user from changing log level with empty logger name from topo UI
---
 .../src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html    | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html b/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html
index 0dda533..59c7c52 100644
--- a/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html
+++ b/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html
@@ -142,6 +142,10 @@ function sendLoggerLevel(id){
             return;
         }
     }
+    if (!loggerName) {
+        alert ("Logger name must be provided. Use \"ROOT\" if you want to change current default log behavior.");
+        return;
+    }
     var data = {};
     var loggerSetting;