You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/16 18:23:18 UTC
[GitHub] [incubator-nuttx] daniel-p-carvalho opened a new pull request #2009: Added STM32L432KC DAC support.
daniel-p-carvalho opened a new pull request #2009:
URL: https://github.com/apache/incubator-nuttx/pull/2009
## Summary
This PR adds support to STM32L432KC internal DAC on nucleo-l432kc board.
## Impact
## Testing
The changes was tested using DAC Tool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] daniel-p-carvalho commented on pull request #2009: Added STM32L432KC DAC support.
Posted by GitBox <gi...@apache.org>.
daniel-p-carvalho commented on pull request #2009:
URL: https://github.com/apache/incubator-nuttx/pull/2009#issuecomment-713236187
@patacongo I've created the STM32L4 common driver directory trying to replicate the one in STM32 boards directory. It builds and seems to work fine but the build process is showing the following messages
make[2]: Entering directory '/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/arm/stm32l4/common'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:102: warning: overriding recipe for target 'stm32_boot.o'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:102: warning: ignoring old recipe for target 'stm32_boot.o'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:102: warning: overriding recipe for target 'stm32_spi.o'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:102: warning: ignoring old recipe for target 'stm32_spi.o'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:102: warning: overriding recipe for target 'stm32_autoleds.o'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:102: warning: ignoring old recipe for target 'stm32_autoleds.o'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:102: warning: overriding recipe for target 'stm32_appinit.o'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:102: warning: ignoring old recipe for target 'stm32_appinit.o'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:108: warning: overriding recipe for target 'libboard.a'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:108: warning: ignoring old recipe for target 'libboard.a'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:114: warning: overriding recipe for target '.depend'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:114: warning: ignoring old recipe for target '.depend'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:129: warning: overriding recipe for target 'clean'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:129: warning: ignoring old recipe for target 'clean'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:136: warning: overriding recipe for target 'distclean'
/home/daniel/nuttx-workspace/stm32l4_adc_llops/nuttx/boards/Board.mk:136: warning: ignoring old recipe for target 'distclean'
Can you help me with this problem?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] daniel-p-carvalho commented on a change in pull request #2009: Added STM32L432KC DAC support.
Posted by GitBox <gi...@apache.org>.
daniel-p-carvalho commented on a change in pull request #2009:
URL: https://github.com/apache/incubator-nuttx/pull/2009#discussion_r506971480
##########
File path: boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c
##########
@@ -0,0 +1,97 @@
+/*****************************************************************************
+ * boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c
+ *
+ * Copyright (C) 2017 Haltian Ltd. All rights reserved.
Review comment:
@juniskane did you signed the ICLA or Haltian signed the SGA?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2009: Added STM32L432KC DAC support.
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #2009:
URL: https://github.com/apache/incubator-nuttx/pull/2009#discussion_r506991730
##########
File path: boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c
##########
@@ -0,0 +1,97 @@
+/*****************************************************************************
+ * boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c
+ *
+ * Copyright (C) 2017 Haltian Ltd. All rights reserved.
Review comment:
I think that this change must be reverted. We cannot being ANY new files into the repositories that do not have Apache 2.0 license.
UNLESS we follow the rules for third party software. If it is not Apache 2.0, it is third party and not truly a part of NuttX.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #2009: Added STM32L432KC DAC support.
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2009:
URL: https://github.com/apache/incubator-nuttx/pull/2009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] daniel-p-carvalho commented on a change in pull request #2009: Added STM32L432KC DAC support.
Posted by GitBox <gi...@apache.org>.
daniel-p-carvalho commented on a change in pull request #2009:
URL: https://github.com/apache/incubator-nuttx/pull/2009#discussion_r506971016
##########
File path: boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c
##########
@@ -0,0 +1,97 @@
+/*****************************************************************************
+ * boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c
+ *
+ * Copyright (C) 2017 Haltian Ltd. All rights reserved.
Review comment:
@xiaoxiang781216 this file was copied from nucleo-l452re so I think that I don't have the rights to do the copyright change unless Haltian Ltd. give the permission.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2009: Added STM32L432KC DAC support.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2009:
URL: https://github.com/apache/incubator-nuttx/pull/2009#discussion_r506955524
##########
File path: boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c
##########
@@ -0,0 +1,97 @@
+/*****************************************************************************
+ * boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c
+ *
+ * Copyright (C) 2017 Haltian Ltd. All rights reserved.
Review comment:
@daniel-p-carvalho could you create a new patch to change the copright to Apache?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org