You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/15 20:48:20 UTC
[GitHub] [superset] robdiciuccio opened a new pull request #12560: style: Update Celery config & docs to use new style settings
robdiciuccio opened a new pull request #12560:
URL: https://github.com/apache/superset/pull/12560
### SUMMARY
Update Celery default configuration and docs to use the [new style configuration settings](https://docs.celeryproject.org/en/4.4.2/userguide/configuration.html#new-lowercase-settings).
This change is mainly to prepare for future Celery upgrades, as support for the old style config settings [will be removed in the next major version](https://docs.celeryproject.org/en/stable/userguide/configuration.html#new-lowercase-settings) (6.0).
Other (potentially) functional changes:
- Removing the long-deprecated `CELERYD_LOG_LEVEL` default setting. Logging should be configured using [these settings](https://docs.celeryproject.org/en/4.4.2/userguide/configuration.html#logging).
- Remove `CELERY_TASK_PROTOCOL = 1` in the Docker config as the default protocol (2) has been the default since 4.0 and is supported by versions 3.1.24 and 4.x+.
### TEST PLAN
Ensure correct Celery operation using the new settings.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-764733440
> Is this a breaking change? If so, should we note it in `UPDATING.md`?
I don't think it's a breaking change, `config.py` was changed without impact on any possible config override. Can you confirm @robdiciuccio ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-761250580
Is this a breaking change? If so, should we note it in `UPDATING.md`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stale[bot] closed pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #12560:
URL: https://github.com/apache/superset/pull/12560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-791806383
π· risk:breaking-change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-761232388
# [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=h1) Report
> Merging [#12560](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=desc) (02ebd46) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12560 +/- ##
==========================================
+ Coverage 63.82% 66.43% +2.61%
==========================================
Files 486 1015 +529
Lines 29958 49624 +19666
Branches 0 4839 +4839
==========================================
+ Hits 19120 32968 +13848
- Misses 10838 16533 +5695
- Partials 0 123 +123
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `50.98% <ΓΈ> (?)` | |
| javascript | `60.73% <ΓΈ> (?)` | |
| python | `63.43% <100.00%> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (-0.04%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-2.82%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <0.00%> (ΓΈ)` | |
| [superset-frontend/src/addSlice/index.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL2luZGV4LnRzeA==) | `0.00% <0.00%> (ΓΈ)` | |
| [...set-frontend/src/explore/components/optionTypes.ts](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9vcHRpb25UeXBlcy50cw==) | `100.00% <0.00%> (ΓΈ)` | |
| [...set-frontend/src/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==) | `100.00% <0.00%> (ΓΈ)` | |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=footer). Last update [fc5e311...02ebd46](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-761232388
# [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=h1) Report
> Merging [#12560](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=desc) (02ebd46) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12560 +/- ##
==========================================
+ Coverage 63.82% 66.43% +2.61%
==========================================
Files 486 1015 +529
Lines 29958 49624 +19666
Branches 0 4839 +4839
==========================================
+ Hits 19120 32968 +13848
- Misses 10838 16533 +5695
- Partials 0 123 +123
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `50.98% <ΓΈ> (?)` | |
| javascript | `60.73% <ΓΈ> (?)` | |
| python | `63.43% <100.00%> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (-0.04%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-2.82%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `92.68% <0.00%> (ΓΈ)` | |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (ΓΈ)` | |
| [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | `0.00% <0.00%> (ΓΈ)` | |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=footer). Last update [fc5e311...02ebd46](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-761232388
# [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=h1) Report
> Merging [#12560](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=desc) (02ebd46) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.59%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12560 +/- ##
==========================================
+ Coverage 63.82% 66.41% +2.59%
==========================================
Files 486 1015 +529
Lines 29958 49624 +19666
Branches 0 4839 +4839
==========================================
+ Hits 19120 32957 +13837
- Misses 10838 16544 +5706
- Partials 0 123 +123
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `50.98% <ΓΈ> (?)` | |
| javascript | `60.73% <ΓΈ> (?)` | |
| python | `63.39% <100.00%> (-0.43%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (-0.04%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-2.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.36%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.45% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/data/hooks.ts](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9ob29rcy50cw==) | `71.42% <0.00%> (ΓΈ)` | |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=footer). Last update [fc5e311...02ebd46](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-761232388
# [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=h1) Report
> Merging [#12560](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=desc) (02ebd46) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.84%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12560 +/- ##
==========================================
+ Coverage 63.82% 66.66% +2.84%
==========================================
Files 486 1015 +529
Lines 29958 49624 +19666
Branches 0 4839 +4839
==========================================
+ Hits 19120 33083 +13963
- Misses 10838 16418 +5580
- Partials 0 123 +123
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `50.98% <ΓΈ> (?)` | |
| javascript | `60.73% <ΓΈ> (?)` | |
| python | `63.81% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (-0.04%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [...tend/src/components/ListView/Filters/DateRange.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9EYXRlUmFuZ2UudHN4) | `52.17% <0.00%> (ΓΈ)` | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | `42.10% <0.00%> (ΓΈ)` | |
| [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `70.83% <0.00%> (ΓΈ)` | |
| [superset-frontend/src/utils/reducerUtils.js](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3JlZHVjZXJVdGlscy5qcw==) | `0.00% <0.00%> (ΓΈ)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `94.11% <0.00%> (ΓΈ)` | |
| [...hboard/components/gridComponents/new/NewColumn.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdDb2x1bW4uanN4) | `100.00% <0.00%> (ΓΈ)` | |
| [...rontend/src/components/ListView/Filters/Search.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9TZWFyY2gudHN4) | `86.66% <0.00%> (ΓΈ)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `62.71% <0.00%> (ΓΈ)` | |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=footer). Last update [fc5e311...02ebd46](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-790988063
Yes, you're correct @robdiciuccio this is breaking - I think it needs to wait for 2.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-761232388
# [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=h1) Report
> Merging [#12560](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=desc) (02ebd46) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `3.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12560 +/- ##
==========================================
- Coverage 63.82% 60.73% -3.09%
==========================================
Files 486 529 +43
Lines 29958 19648 -10310
Branches 0 4839 +4839
==========================================
- Hits 19120 11934 -7186
+ Misses 10838 7516 -3322
- Partials 0 198 +198
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `60.73% <ΓΈ> (?)` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/utils/schema.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NoZW1hLnB5) | | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | | |
| [...a45e\_form\_strip\_leading\_and\_trailing\_whitespace.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNThiNTI4MGE0NWVfZm9ybV9zdHJpcF9sZWFkaW5nX2FuZF90cmFpbGluZ193aGl0ZXNwYWNlLnB5) | | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | | |
| [superset/views/api.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | | |
| [...erset/migrations/versions/ab8c66efdd01\_resample.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjhjNjZlZmRkMDFfcmVzYW1wbGUucHk=) | | |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | | |
| [superset/async\_events/api.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FwaS5weQ==) | | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | | |
| [superset/views/health.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvaGVhbHRoLnB5) | | |
| ... and [1004 more](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=footer). Last update [fc5e311...02ebd46](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stale[bot] commented on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-859200889
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-761232388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-761232388
# [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=h1) Report
> Merging [#12560](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=desc) (02ebd46) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.84%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12560 +/- ##
==========================================
+ Coverage 63.82% 66.66% +2.84%
==========================================
Files 486 1015 +529
Lines 29958 49624 +19666
Branches 0 4839 +4839
==========================================
+ Hits 19120 33084 +13964
- Misses 10838 16417 +5579
- Partials 0 123 +123
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `50.98% <ΓΈ> (?)` | |
| javascript | `60.73% <ΓΈ> (?)` | |
| python | `63.82% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (-0.04%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `92.68% <0.00%> (ΓΈ)` | |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (ΓΈ)` | |
| [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | `0.00% <0.00%> (ΓΈ)` | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `73.72% <0.00%> (ΓΈ)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `81.42% <0.00%> (ΓΈ)` | |
| [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | `100.00% <0.00%> (ΓΈ)` | |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `58.18% <0.00%> (ΓΈ)` | |
| [...frontend/src/components/SupersetResourceSelect.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC50c3g=) | `75.86% <0.00%> (ΓΈ)` | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=footer). Last update [fc5e311...02ebd46](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-764733440
> Is this a breaking change? If so, should we note it in `UPDATING.md`?
I don't think it's a breaking change, `config.py` was changed without impact on any possible config override. Can you confirm @robdiciuccio ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-761232388
# [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=h1) Report
> Merging [#12560](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=desc) (02ebd46) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.84%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12560 +/- ##
==========================================
+ Coverage 63.82% 66.66% +2.84%
==========================================
Files 486 1015 +529
Lines 29958 49624 +19666
Branches 0 4839 +4839
==========================================
+ Hits 19120 33083 +13963
- Misses 10838 16418 +5580
- Partials 0 123 +123
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `50.98% <ΓΈ> (?)` | |
| javascript | `60.73% <ΓΈ> (?)` | |
| python | `63.81% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (-0.04%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [...rset-frontend/src/components/LastUpdated/index.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFzdFVwZGF0ZWQvaW5kZXgudHN4) | `96.00% <0.00%> (ΓΈ)` | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | `87.50% <0.00%> (ΓΈ)` | |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `100.00% <0.00%> (ΓΈ)` | |
| [...rc/views/CRUD/alert/components/AlertStatusIcon.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9BbGVydFN0YXR1c0ljb24udHN4) | `46.87% <0.00%> (ΓΈ)` | |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <0.00%> (ΓΈ)` | |
| [...ashboard/components/nativeFilters/ColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvQ29sdW1uU2VsZWN0LnRzeA==) | `60.60% <0.00%> (ΓΈ)` | |
| [...uperset-frontend/src/components/AsyncAceEditor.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IudHN4) | `85.71% <0.00%> (ΓΈ)` | |
| [...erset-frontend/src/profile/components/UserInfo.tsx](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9Vc2VySW5mby50c3g=) | `100.00% <0.00%> (ΓΈ)` | |
| ... and [521 more](https://codecov.io/gh/apache/superset/pull/12560/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=footer). Last update [fc5e311...02ebd46](https://codecov.io/gh/apache/superset/pull/12560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio commented on pull request #12560: style: Update Celery config & docs to use new style settings
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #12560:
URL: https://github.com/apache/superset/pull/12560#issuecomment-790205181
I think this could be considered a breaking change due to how the overrides function in the import of `superset_config.py`. It also changes the `CELERY_TASK_PROTOCOL` version, which could definitely be breaking (though this could be moved to a separate PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org