[shardingsphere] branch master updated: Simplify UnsupportedOperationParameterMetaTest (#9162)

[pa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new b7ff794  Simplify UnsupportedOperationParameterMetaTest (#9162)
b7ff794 is described below

commit b7ff794e1eb4b971069d535ade5c95c6ae46aac3
Author: Liang Zhang <te...@163.com>
AuthorDate: Mon Jan 25 22:29:25 2021 +0800

    Simplify UnsupportedOperationParameterMetaTest (#9162)
---
 .../UnsupportedOperationParameterMetaTest.java     | 67 +++++-----------------
 1 file changed, 14 insertions(+), 53 deletions(-)

diff --git a/shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedOperationParameterMetaTest.java b/shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedOperationParameterMetaTest.java
index 315b638..08bc9c7 100644
--- a/shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedOperationParameterMetaTest.java
+++ b/shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/java/org/apache/shardingsphere/driver/jdbc/unsupported/UnsupportedOperationParameterMetaTest.java
@@ -17,95 +17,56 @@
 
 package org.apache.shardingsphere.driver.jdbc.unsupported;
 
-import org.apache.shardingsphere.driver.jdbc.base.AbstractShardingSphereDataSourceForShardingTest;
-import org.apache.shardingsphere.driver.jdbc.core.connection.ShardingSphereConnection;
-import org.junit.After;
-import org.junit.Before;
+import org.apache.shardingsphere.driver.jdbc.core.statement.metadata.ShardingSphereParameterMetaData;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.SQLStatement;
 import org.junit.Test;
 
-import java.sql.ParameterMetaData;
-import java.sql.PreparedStatement;
 import java.sql.SQLException;
 import java.sql.SQLFeatureNotSupportedException;
-import java.util.ArrayList;
-import java.util.List;
 
-public final class UnsupportedOperationParameterMetaTest extends AbstractShardingSphereDataSourceForShardingTest {
-    
-    private static final String SQL = "SELECT user_id AS usr_id FROM t_order WHERE status = 'init'";
-    
-    private final List<ShardingSphereConnection> shardingSphereConnections = new ArrayList<>();
-    
-    private final List<ParameterMetaData> parameterMetaData = new ArrayList<>();
-    
-    @Before
-    public void init() throws SQLException {
-        ShardingSphereConnection connection = getShardingSphereDataSource().getConnection();
-        shardingSphereConnections.add(connection);
-        PreparedStatement preparedStatement = connection.prepareStatement(SQL);
-        parameterMetaData.add(preparedStatement.getParameterMetaData());
-    }
+import static org.mockito.Mockito.mock;
+
+public final class UnsupportedOperationParameterMetaTest {
     
-    @After
-    public void close() throws SQLException {
-        for (ShardingSphereConnection each : shardingSphereConnections) {
-            each.close();
-        }
-    }
+    private final ShardingSphereParameterMetaData shardingSphereParameterMetaData = new ShardingSphereParameterMetaData(mock(SQLStatement.class));
     
     @Test(expected = SQLFeatureNotSupportedException.class)
     public void assertIsNullable() throws SQLException {
-        for (ParameterMetaData each : parameterMetaData) {
-            each.getParameterClassName(1);
-        }
+        shardingSphereParameterMetaData.getParameterClassName(1);
     }
     
     @Test(expected = SQLFeatureNotSupportedException.class)
     public void assertIsSigned() throws SQLException {
-        for (ParameterMetaData each : parameterMetaData) {
-            each.isSigned(1);
-        }
+        shardingSphereParameterMetaData.isSigned(1);
     }
     
     @Test(expected = SQLFeatureNotSupportedException.class)
     public void assertGetPrecision() throws SQLException {
-        for (ParameterMetaData each : parameterMetaData) {
-            each.getPrecision(1);
-        }
+        shardingSphereParameterMetaData.getPrecision(1);
     }
     
     @Test(expected = SQLFeatureNotSupportedException.class)
     public void assertGetScale() throws SQLException {
-        for (ParameterMetaData each : parameterMetaData) {
-            each.getScale(1);
-        }
+        shardingSphereParameterMetaData.getScale(1);
     }
     
     @Test(expected = SQLFeatureNotSupportedException.class)
     public void assertGetParameterType() throws SQLException {
-        for (ParameterMetaData each : parameterMetaData) {
-            each.getParameterType(1);
-        }
+        shardingSphereParameterMetaData.getParameterType(1);
     }
     
     @Test(expected = SQLFeatureNotSupportedException.class)
     public void assertGetParameterTypeName() throws SQLException {
-        for (ParameterMetaData each : parameterMetaData) {
-            each.getParameterTypeName(1);
-        }
+        shardingSphereParameterMetaData.getParameterTypeName(1);
     }
     
     @Test(expected = SQLFeatureNotSupportedException.class)
     public void assertGetParameterClassName() throws SQLException {
-        for (ParameterMetaData each : parameterMetaData) {
-            each.getParameterClassName(1);
-        }
+        shardingSphereParameterMetaData.getParameterClassName(1);
     }
     
     @Test(expected = SQLFeatureNotSupportedException.class)
     public void assertGetParameterMode() throws SQLException {
-        for (ParameterMetaData each : parameterMetaData) {
-            each.getParameterMode(1);
-        }
+        shardingSphereParameterMetaData.getParameterMode(1);
     }
 }