Re: [PR] add graceful shutdown to management core [pekko-management]

["He-Pin (via GitHub)" <gi...@apache.org>]

He-Pin commented on code in PR #909:
URL: https://github.com/apache/pekko-management/pull/909#discussion_r3717615255


##########
management/src/main/scala/org/apache/pekko/management/PekkoManagementSettings.scala:
##########
@@ -17,7 +17,9 @@ import java.net.InetAddress
 import java.util.Optional
 
 import scala.collection.immutable
+import scala.concurrent.duration.FiniteDuration
 import scala.jdk.CollectionConverters._
+import scala.jdk.DurationConverters._
 import scala.jdk.OptionConverters._

Review Comment:
   Minor heads-up: ServerBinding.terminate does a require(hardDeadline > Duration.Zero), so if someone sets graceful-termination-timeout = 0s (or negative), stop() will fail with an IllegalArgumentException at shutdown. Might be worth validating it here at settings load time with a clearer message. Not blocking though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org