You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Jeremy Thomerson <je...@wickettraining.com> on 2010/11/23 04:08:10 UTC
[announce] Pedro Santos added to Wicket PMC / Committer
I'd just like to pass this on to everyone on the list. Pedro Santos
has been added as a committer and PMC member for Apache Wicket. Pedro
has been increasingly active in the Wicket community in recent months,
and his patches continue to improve in quality. Additionally, Pedro
is always willing to do the "grunt work" of creating great test cases
for his patches, or for JIRA issues that others have attached patches
to. Test cases are invaluable to the development of Wicket because
they help us not introduce regressions as we fix bugs and add
features.
Thanks Pedro, and we look forward to working with you!
PS - the message below is Pedro's first commit to Wicket - already
improving test cases!
--
Jeremy Thomerson
http://wickettraining.com
Need a CMS for Wicket? Use Brix! http://brixcms.org
---------- Forwarded message ----------
From: <pe...@apache.org>
Date: Mon, Nov 22, 2010 at 5:45 PM
Subject: svn commit: r1037925 - in
/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree:
MoveChildToParentNodeMarkedForRecreationTest.java
MoveChildToParentNodeMarkedForRecreationTestPage.java
To: commits@wicket.apache.org
Author: pedro
Date: Mon Nov 22 22:45:41 2010
New Revision: 1037925
URL: http://svn.apache.org/viewvc?rev=1037925&view=rev
Log:
adding an assert line in the test to turn it more meaningful
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java?rev=1037925&r1=1037924&r2=1037925&view=diff
==============================================================================
--- wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
(original)
+++ wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
Mon Nov 22 22:45:41 2010
@@ -38,7 +38,9 @@ public class MoveChildToParentNodeMarked
public void test()
{
WicketTester tester = new WicketTester();
-
tester.startPage(MoveChildToParentNodeMarkedForRecreationTestPage.class);
+ MoveChildToParentNodeMarkedForRecreationTestPage
testPage = new MoveChildToParentNodeMarkedForRecreationTestPage();
+ tester.startPage(testPage);
tester.clickLink("moveC3ToC2");
+ assertTrue(testPage.c2.isNodeChild(testPage.c3));
}
}
Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java?rev=1037925&r1=1037924&r2=1037925&view=diff
==============================================================================
--- wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
(original)
+++ wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
Mon Nov 22 22:45:41 2010
@@ -28,8 +28,8 @@ public class MoveChildToParentNodeMarked
private static final long serialVersionUID = 1L;
private final Tree treeTable;
- private DefaultMutableTreeNode c2;
- private DefaultMutableTreeNode c3;
+ DefaultMutableTreeNode c2;
+ DefaultMutableTreeNode c3;
public MoveChildToParentNodeMarkedForRecreationTestPage()
{
Re: [announce] Pedro Santos added to Wicket PMC / Committer
Posted by Martijn Dashorst <ma...@gmail.com>.
Welcome Pedro!
(I've added this announcement as a blog entry to our website)
Martijn
On Tue, Nov 23, 2010 at 4:08 AM, Jeremy Thomerson
<je...@wickettraining.com> wrote:
> I'd just like to pass this on to everyone on the list. Pedro Santos
> has been added as a committer and PMC member for Apache Wicket. Pedro
> has been increasingly active in the Wicket community in recent months,
> and his patches continue to improve in quality. Additionally, Pedro
> is always willing to do the "grunt work" of creating great test cases
> for his patches, or for JIRA issues that others have attached patches
> to. Test cases are invaluable to the development of Wicket because
> they help us not introduce regressions as we fix bugs and add
> features.
>
> Thanks Pedro, and we look forward to working with you!
>
> PS - the message below is Pedro's first commit to Wicket - already
> improving test cases!
>
> --
> Jeremy Thomerson
> http://wickettraining.com
> Need a CMS for Wicket? Use Brix! http://brixcms.org
>
>
>
>
> ---------- Forwarded message ----------
> From: <pe...@apache.org>
> Date: Mon, Nov 22, 2010 at 5:45 PM
> Subject: svn commit: r1037925 - in
> /wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree:
> MoveChildToParentNodeMarkedForRecreationTest.java
> MoveChildToParentNodeMarkedForRecreationTestPage.java
> To: commits@wicket.apache.org
>
>
> Author: pedro
> Date: Mon Nov 22 22:45:41 2010
> New Revision: 1037925
>
> URL: http://svn.apache.org/viewvc?rev=1037925&view=rev
> Log:
> adding an assert line in the test to turn it more meaningful
>
> Modified:
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
>
> Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java?rev=1037925&r1=1037924&r2=1037925&view=diff
> ==============================================================================
> --- wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> (original)
> +++ wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> Mon Nov 22 22:45:41 2010
> @@ -38,7 +38,9 @@ public class MoveChildToParentNodeMarked
> public void test()
> {
> WicketTester tester = new WicketTester();
> -
> tester.startPage(MoveChildToParentNodeMarkedForRecreationTestPage.class);
> + MoveChildToParentNodeMarkedForRecreationTestPage
> testPage = new MoveChildToParentNodeMarkedForRecreationTestPage();
> + tester.startPage(testPage);
> tester.clickLink("moveC3ToC2");
> + assertTrue(testPage.c2.isNodeChild(testPage.c3));
> }
> }
>
> Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
> URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java?rev=1037925&r1=1037924&r2=1037925&view=diff
> ==============================================================================
> --- wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
> (original)
> +++ wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
> Mon Nov 22 22:45:41 2010
> @@ -28,8 +28,8 @@ public class MoveChildToParentNodeMarked
> private static final long serialVersionUID = 1L;
>
> private final Tree treeTable;
> - private DefaultMutableTreeNode c2;
> - private DefaultMutableTreeNode c3;
> + DefaultMutableTreeNode c2;
> + DefaultMutableTreeNode c3;
>
> public MoveChildToParentNodeMarkedForRecreationTestPage()
> {
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: [announce] Pedro Santos added to Wicket PMC / Committer
Posted by Peter Ertl <pe...@gmx.org>.
Welcome to a great project and have a good time :-)
Am 23.11.2010 um 15:54 schrieb Pedro Santos:
> Thank u very much guys! I'm very happy in being a member of the great Wicket
> team!
> I'm looking forward to fix and prevent bugs and learn as much as possible in
> this work!
>
> On Tue, Nov 23, 2010 at 7:04 AM, Carl-Eric Menzel <cm...@wicketbuch.de>wrote:
>
>> On Mon, 22 Nov 2010 22:08:10 -0500
>> Jeremy Thomerson <je...@wickettraining.com> wrote:
>>
>>> I'd just like to pass this on to everyone on the list. Pedro Santos
>>> has been added as a committer and PMC member for Apache Wicket. Pedro
>>
>> Congratulations!
>>
>> Carl-Eric
>> www.wicketbuch.de
>>
>
>
>
> --
> Pedro Henrique Oliveira dos Santos
Re: [announce] Pedro Santos added to Wicket PMC / Committer
Posted by Pedro Santos <pe...@gmail.com>.
Thank u very much guys! I'm very happy in being a member of the great Wicket
team!
I'm looking forward to fix and prevent bugs and learn as much as possible in
this work!
On Tue, Nov 23, 2010 at 7:04 AM, Carl-Eric Menzel <cm...@wicketbuch.de>wrote:
> On Mon, 22 Nov 2010 22:08:10 -0500
> Jeremy Thomerson <je...@wickettraining.com> wrote:
>
> > I'd just like to pass this on to everyone on the list. Pedro Santos
> > has been added as a committer and PMC member for Apache Wicket. Pedro
>
> Congratulations!
>
> Carl-Eric
> www.wicketbuch.de
>
--
Pedro Henrique Oliveira dos Santos
Re: [announce] Pedro Santos added to Wicket PMC / Committer
Posted by Carl-Eric Menzel <cm...@wicketbuch.de>.
On Mon, 22 Nov 2010 22:08:10 -0500
Jeremy Thomerson <je...@wickettraining.com> wrote:
> I'd just like to pass this on to everyone on the list. Pedro Santos
> has been added as a committer and PMC member for Apache Wicket. Pedro
Congratulations!
Carl-Eric
www.wicketbuch.de
Re: [announce] Pedro Santos added to Wicket PMC / Committer
Posted by Martin Grigorov <mg...@apache.org>.
Welcome on board, Pedro!
Keep the good work !
On Tue, Nov 23, 2010 at 4:42 AM, James Carman <ja...@carmanconsulting.com>wrote:
> Congratulations, Pedro!
>
> On Mon, Nov 22, 2010 at 10:08 PM, Jeremy Thomerson
> <je...@wickettraining.com> wrote:
> > I'd just like to pass this on to everyone on the list. Pedro Santos
> > has been added as a committer and PMC member for Apache Wicket. Pedro
> > has been increasingly active in the Wicket community in recent months,
> > and his patches continue to improve in quality. Additionally, Pedro
> > is always willing to do the "grunt work" of creating great test cases
> > for his patches, or for JIRA issues that others have attached patches
> > to. Test cases are invaluable to the development of Wicket because
> > they help us not introduce regressions as we fix bugs and add
> > features.
> >
> > Thanks Pedro, and we look forward to working with you!
> >
> > PS - the message below is Pedro's first commit to Wicket - already
> > improving test cases!
> >
> > --
> > Jeremy Thomerson
> > http://wickettraining.com
> > Need a CMS for Wicket? Use Brix! http://brixcms.org
> >
> >
> >
> >
> > ---------- Forwarded message ----------
> > From: <pe...@apache.org>
> > Date: Mon, Nov 22, 2010 at 5:45 PM
> > Subject: svn commit: r1037925 - in
> >
> /wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree:
> > MoveChildToParentNodeMarkedForRecreationTest.java
> > MoveChildToParentNodeMarkedForRecreationTestPage.java
> > To: commits@wicket.apache.org
> >
> >
> > Author: pedro
> > Date: Mon Nov 22 22:45:41 2010
> > New Revision: 1037925
> >
> > URL: http://svn.apache.org/viewvc?rev=1037925&view=rev
> > Log:
> > adding an assert line in the test to turn it more meaningful
> >
> > Modified:
> >
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> >
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
> >
> > Modified:
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> > URL:
> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java?rev=1037925&r1=1037924&r2=1037925&view=diff
> >
> ==============================================================================
> > ---
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> > (original)
> > +++
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> > Mon Nov 22 22:45:41 2010
> > @@ -38,7 +38,9 @@ public class MoveChildToParentNodeMarked
> > public void test()
> > {
> > WicketTester tester = new WicketTester();
> > -
> > tester.startPage(MoveChildToParentNodeMarkedForRecreationTestPage.class);
> > + MoveChildToParentNodeMarkedForRecreationTestPage
> > testPage = new MoveChildToParentNodeMarkedForRecreationTestPage();
> > + tester.startPage(testPage);
> > tester.clickLink("moveC3ToC2");
> > + assertTrue(testPage.c2.isNodeChild(testPage.c3));
> > }
> > }
> >
> > Modified:
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
> > URL:
> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java?rev=1037925&r1=1037924&r2=1037925&view=diff
> >
> ==============================================================================
> > ---
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
> > (original)
> > +++
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
> > Mon Nov 22 22:45:41 2010
> > @@ -28,8 +28,8 @@ public class MoveChildToParentNodeMarked
> > private static final long serialVersionUID = 1L;
> >
> > private final Tree treeTable;
> > - private DefaultMutableTreeNode c2;
> > - private DefaultMutableTreeNode c3;
> > + DefaultMutableTreeNode c2;
> > + DefaultMutableTreeNode c3;
> >
> > public MoveChildToParentNodeMarkedForRecreationTestPage()
> > {
> >
>
Re: [announce] Pedro Santos added to Wicket PMC / Committer
Posted by James Carman <ja...@carmanconsulting.com>.
Congratulations, Pedro!
On Mon, Nov 22, 2010 at 10:08 PM, Jeremy Thomerson
<je...@wickettraining.com> wrote:
> I'd just like to pass this on to everyone on the list. Pedro Santos
> has been added as a committer and PMC member for Apache Wicket. Pedro
> has been increasingly active in the Wicket community in recent months,
> and his patches continue to improve in quality. Additionally, Pedro
> is always willing to do the "grunt work" of creating great test cases
> for his patches, or for JIRA issues that others have attached patches
> to. Test cases are invaluable to the development of Wicket because
> they help us not introduce regressions as we fix bugs and add
> features.
>
> Thanks Pedro, and we look forward to working with you!
>
> PS - the message below is Pedro's first commit to Wicket - already
> improving test cases!
>
> --
> Jeremy Thomerson
> http://wickettraining.com
> Need a CMS for Wicket? Use Brix! http://brixcms.org
>
>
>
>
> ---------- Forwarded message ----------
> From: <pe...@apache.org>
> Date: Mon, Nov 22, 2010 at 5:45 PM
> Subject: svn commit: r1037925 - in
> /wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree:
> MoveChildToParentNodeMarkedForRecreationTest.java
> MoveChildToParentNodeMarkedForRecreationTestPage.java
> To: commits@wicket.apache.org
>
>
> Author: pedro
> Date: Mon Nov 22 22:45:41 2010
> New Revision: 1037925
>
> URL: http://svn.apache.org/viewvc?rev=1037925&view=rev
> Log:
> adding an assert line in the test to turn it more meaningful
>
> Modified:
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
>
> Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java?rev=1037925&r1=1037924&r2=1037925&view=diff
> ==============================================================================
> --- wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> (original)
> +++ wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java
> Mon Nov 22 22:45:41 2010
> @@ -38,7 +38,9 @@ public class MoveChildToParentNodeMarked
> public void test()
> {
> WicketTester tester = new WicketTester();
> -
> tester.startPage(MoveChildToParentNodeMarkedForRecreationTestPage.class);
> + MoveChildToParentNodeMarkedForRecreationTestPage
> testPage = new MoveChildToParentNodeMarkedForRecreationTestPage();
> + tester.startPage(testPage);
> tester.clickLink("moveC3ToC2");
> + assertTrue(testPage.c2.isNodeChild(testPage.c3));
> }
> }
>
> Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
> URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java?rev=1037925&r1=1037924&r2=1037925&view=diff
> ==============================================================================
> --- wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
> (original)
> +++ wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
> Mon Nov 22 22:45:41 2010
> @@ -28,8 +28,8 @@ public class MoveChildToParentNodeMarked
> private static final long serialVersionUID = 1L;
>
> private final Tree treeTable;
> - private DefaultMutableTreeNode c2;
> - private DefaultMutableTreeNode c3;
> + DefaultMutableTreeNode c2;
> + DefaultMutableTreeNode c3;
>
> public MoveChildToParentNodeMarkedForRecreationTestPage()
> {
>