You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/05 06:01:00 UTC
[GitHub] [pulsar] hrsakai opened a new pull request #6480: [Issue
6461][C++]Avoid calling redeliverMessages() when message list is empty
hrsakai opened a new pull request #6480: [Issue 6461][C++]Avoid calling redeliverMessages() when message list is empty
URL: https://github.com/apache/pulsar/pull/6480
### Motivation
Fix https://github.com/apache/pulsar/issues/6461
### Modifications
* Call `ConsumerImpl::redeliverMessages(const std::set<MessageId>& messageIds)` in `NegativeAcksTracker::handleTimer()`only if MessageId list is not empty.
If `ConsumerImpl::redeliverMessages(const std::set<MessageId>& messageIds)` is called with messageIds empty, all unacked messages will be redelivered immediately.
https://github.com/apache/pulsar/blob/v2.4.2/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L1109-L1113
https://github.com/apache/pulsar/blob/v2.4.2/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L542-L569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat merged pull request #6480: [Issue 6461][C++]Avoid
calling redeliverMessages() when message list is empty
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #6480: [Issue 6461][C++]Avoid calling redeliverMessages() when message list is empty
URL: https://github.com/apache/pulsar/pull/6480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] hrsakai commented on issue #6480: [Issue 6461][C++]Avoid
calling redeliverMessages() when message list is empty
Posted by GitBox <gi...@apache.org>.
hrsakai commented on issue #6480: [Issue 6461][C++]Avoid calling redeliverMessages() when message list is empty
URL: https://github.com/apache/pulsar/pull/6480#issuecomment-595056365
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6480: [Issue 6461][C++]Avoid
calling redeliverMessages() when message list is empty
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6480: [Issue 6461][C++]Avoid calling redeliverMessages() when message list is empty
URL: https://github.com/apache/pulsar/pull/6480#issuecomment-598574194
cherry-picked into branch-2.5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services