You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@shindig.apache.org by ch...@apache.org on 2009/04/14 13:03:03 UTC

svn commit: r764736 - /incubator/shindig/trunk/php/src/gadgets/render/GadgetHtmlRenderer.php

Author: chabotc
Date: Tue Apr 14 11:03:02 2009
New Revision: 764736

URL: http://svn.apache.org/viewvc?rev=764736&view=rev
Log:
improper escaping of &'s in javascript assigned by nodeValue caused &&'s to become &'s and break all our if's :)

Modified:
    incubator/shindig/trunk/php/src/gadgets/render/GadgetHtmlRenderer.php

Modified: incubator/shindig/trunk/php/src/gadgets/render/GadgetHtmlRenderer.php
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/php/src/gadgets/render/GadgetHtmlRenderer.php?rev=764736&r1=764735&r2=764736&view=diff
==============================================================================
--- incubator/shindig/trunk/php/src/gadgets/render/GadgetHtmlRenderer.php (original)
+++ incubator/shindig/trunk/php/src/gadgets/render/GadgetHtmlRenderer.php Tue Apr 14 11:03:02 2009
@@ -111,7 +111,8 @@
     $script .= $this->appendPreloads($this->gadget);
 
     $scriptNode = $doc->createElement('script');
-    $scriptNode->nodeValue = $script;
+    $scriptNode->setAttribute('type', 'text/javascript');
+    $scriptNode->nodeValue = str_replace('&', '&amp;', $script);
     $node->appendChild($scriptNode);
   }