You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by John Pritchard <jd...@syntelos.com> on 2009/03/19 04:30:38 UTC
skins and themes
Hi,
Looks like much of the code in wtk/skin/terra isn't really L&F but more
basic, and should probably be refactored back into wtk/skin. Comparing the
state of TablePaneSkin / TerraTablePaneSkin with SplitPaneSkin /
TerraSplitPaneSkin highlights the situation. (first, there is no
SplitPaneSkin).
I'll send some patches.
And then I'm on to making Split Pane default to 50%. I have an eye out for a
solution to relative layout for Split Pane.
/john/
Re: skins and themes
Posted by John Pritchard <jd...@syntelos.com>.
weird.. the pattern is that you guys aren't seeing '*.java' attachments..
(see attached)
On Thu, Mar 19, 2009 at 11:09 AM, Todd Volkert <tv...@gmail.com> wrote:
> > Here's a refactoring of SplitPaneSkin ..
> > one notable change would be the Shadow classes changed from
> terra::protected
> > to skin::public.
>
> Can you send SplitPaneSkin as well (I only see the TerraSplitPaneSkin
> refactor), and I'll check it out.
>
> Thanks,
> -T
>
Re: skins and themes
Posted by Todd Volkert <tv...@gmail.com>.
> Here's a refactoring of SplitPaneSkin ..
> one notable change would be the Shadow classes changed from terra::protected
> to skin::public.
Can you send SplitPaneSkin as well (I only see the TerraSplitPaneSkin
refactor), and I'll check it out.
Thanks,
-T
Re: skins and themes
Posted by John Pritchard <jd...@syntelos.com>.
Hi,
Here's a refactoring of SplitPaneSkin ..
one notable change would be the Shadow classes changed from terra::protected
to skin::public.
/john/
> Hi,
>
> Looks like much of the code in wtk/skin/terra isn't really L&F but more
> basic, and should probably be refactored back into wtk/skin. Comparing the
> state of TablePaneSkin / TerraTablePaneSkin with SplitPaneSkin /
> TerraSplitPaneSkin highlights the situation. (first, there is no
> SplitPaneSkin).
>
> I'll send some patches.
>
> And then I'm on to making Split Pane default to 50%. I have an eye out for
> a solution to relative layout for Split Pane.
>
> /john/
>
>
Re: skins and themes
Posted by Greg Brown <gk...@mac.com>.
>Looks like much of the code in wtk/skin/terra isn't really L&F but more
>basic, and should probably be refactored back into wtk/skin.
Agreed - we're planning to do this in a future release. It's not something we have time to do for 1.1.