You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-commits@hadoop.apache.org by je...@apache.org on 2013/02/20 22:01:37 UTC
svn commit: r1448411 - in
/hadoop/common/branches/branch-0.23/hadoop-yarn-project: CHANGES.txt
hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
Author: jeagles
Date: Wed Feb 20 21:01:37 2013
New Revision: 1448411
URL: http://svn.apache.org/r1448411
Log:
YARN-236. RM should point tracking URL to RM web page when app fails to start (Jason Lowe via jeagles)
Modified:
hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
Modified: hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt?rev=1448411&r1=1448410&r2=1448411&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt (original)
+++ hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt Wed Feb 20 21:01:37 2013
@@ -16,6 +16,9 @@ Release 0.23.7 - UNRELEASED
YARN-249. Capacity Scheduler web page should show list of active users per
queue like it used to (in 1.x) (Ravi Prakash via tgraves)
+ YARN-236. RM should point tracking URL to RM web page when app fails to
+ start (Jason Lowe via jeagles)
+
OPTIMIZATIONS
YARN-357. App submission should not be synchronized (daryn)
Modified: hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java?rev=1448411&r1=1448410&r2=1448411&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java (original)
+++ hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java Wed Feb 20 21:01:37 2013
@@ -66,6 +66,7 @@ public class WebAppProxyServlet extends
public static final String PROXY_USER_COOKIE_NAME = "proxy-user";
private final List<TrackingUriPlugin> trackingUriPlugins;
+ private final String rmAppPageUrlBase;
private static class _ implements Hamlet._ {
//Empty
@@ -91,6 +92,8 @@ public class WebAppProxyServlet extends
this.trackingUriPlugins =
conf.getInstances(YarnConfiguration.YARN_TRACKING_URL_GENERATOR,
TrackingUriPlugin.class);
+ this.rmAppPageUrlBase = StringHelper.pjoin(
+ YarnConfiguration.getRMWebAppURL(conf), "cluster", "app");
}
/**
@@ -291,25 +294,10 @@ public class WebAppProxyServlet extends
if (original != null) {
trackingUri = ProxyUriUtils.getUriFromAMUrl(original);
}
+ // fallback to ResourceManager's app page if no tracking URI provided
if(original == null || original.equals("N/A")) {
- String message;
- switch(applicationReport.getFinalApplicationStatus()) {
- case FAILED:
- case KILLED:
- case SUCCEEDED:
- message =
- "The requested application exited before setting a tracking URL.";
- break;
- case UNDEFINED:
- message = "The requested application does not appear to be running "
- +"yet, and has not set a tracking URL.";
- break;
- default:
- //This should never happen, but just to be safe
- message = "The requested application has not set a tracking URL.";
- break;
- }
- notFound(resp, message);
+ resp.sendRedirect(resp.encodeRedirectURL(
+ StringHelper.pjoin(rmAppPageUrlBase, id.toString())));
return;
}