You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Ralph Goers <ra...@dslextreme.com> on 2014/03/24 22:14:49 UTC
Re: svn commit: r1581025 - /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
This change breaks binary compatibility and so needs to be documented in changes.xml.
Ralph
On Mar 24, 2014, at 1:03 PM, ggregory@apache.org wrote:
> Author: ggregory
> Date: Mon Mar 24 20:03:13 2014
> New Revision: 1581025
>
> URL: http://svn.apache.org/r1581025
> Log:
> Two test methods are missing the "is" predicate, which some other methods use.
>
> Modified:
> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
>
> Modified: logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java?rev=1581025&r1=1581024&r2=1581025&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java (original)
> +++ logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java Mon Mar 24 20:03:13 2014
> @@ -151,7 +151,7 @@ public final class Level implements Comp
> * @param level The level to check.
> * @return True if the passed Level is more specific or the same as this Level.
> */
> - public boolean lessOrEqual(final Level level) {
> + public boolean isLessOrEqual(final Level level) {
> return this.intLevel <= level.intLevel;
> }
>
> @@ -160,7 +160,7 @@ public final class Level implements Comp
> * @param level The level to check.
> * @return True if the passed Level is more specific or the same as this Level.
> */
> - public boolean lessOrEqual(final int level) {
> + public boolean isLessOrEqual(final int level) {
> return this.intLevel <= level;
> }
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1581025 - /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Mar 24, 2014 at 5:43 PM, Matt Sicker <bo...@gmail.com> wrote:
> In that case, the serialVersionUID should probably be modified. Regenerate
> or set to 1L.
>
Done.
Gary
>
>
> On 24 March 2014 16:42, Gary Gregory <ga...@gmail.com> wrote:
>
>> On Mon, Mar 24, 2014 at 5:14 PM, Ralph Goers <ra...@dslextreme.com>wrote:
>>
>>> This change breaks binary compatibility and so needs to be documented in
>>> changes.xml.
>>>
>>
>> Good catch, done.
>>
>> Gary
>>
>>
>>>
>>> Ralph
>>>
>>> On Mar 24, 2014, at 1:03 PM, ggregory@apache.org wrote:
>>>
>>> > Author: ggregory
>>> > Date: Mon Mar 24 20:03:13 2014
>>> > New Revision: 1581025
>>> >
>>> > URL: http://svn.apache.org/r1581025
>>> > Log:
>>> > Two test methods are missing the "is" predicate, which some other
>>> methods use.
>>> >
>>> > Modified:
>>> >
>>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
>>> >
>>> > Modified:
>>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
>>> > URL:
>>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java?rev=1581025&r1=1581024&r2=1581025&view=diff
>>> >
>>> ==============================================================================
>>> > ---
>>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
>>> (original)
>>> > +++
>>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
>>> Mon Mar 24 20:03:13 2014
>>> > @@ -151,7 +151,7 @@ public final class Level implements Comp
>>> > * @param level The level to check.
>>> > * @return True if the passed Level is more specific or the same
>>> as this Level.
>>> > */
>>> > - public boolean lessOrEqual(final Level level) {
>>> > + public boolean isLessOrEqual(final Level level) {
>>> > return this.intLevel <= level.intLevel;
>>> > }
>>> >
>>> > @@ -160,7 +160,7 @@ public final class Level implements Comp
>>> > * @param level The level to check.
>>> > * @return True if the passed Level is more specific or the same
>>> as this Level.
>>> > */
>>> > - public boolean lessOrEqual(final int level) {
>>> > + public boolean isLessOrEqual(final int level) {
>>> > return this.intLevel <= level;
>>> > }
>>> >
>>> >
>>> >
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1581025 - /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
Posted by Matt Sicker <bo...@gmail.com>.
In that case, the serialVersionUID should probably be modified. Regenerate
or set to 1L.
On 24 March 2014 16:42, Gary Gregory <ga...@gmail.com> wrote:
> On Mon, Mar 24, 2014 at 5:14 PM, Ralph Goers <ra...@dslextreme.com>wrote:
>
>> This change breaks binary compatibility and so needs to be documented in
>> changes.xml.
>>
>
> Good catch, done.
>
> Gary
>
>
>>
>> Ralph
>>
>> On Mar 24, 2014, at 1:03 PM, ggregory@apache.org wrote:
>>
>> > Author: ggregory
>> > Date: Mon Mar 24 20:03:13 2014
>> > New Revision: 1581025
>> >
>> > URL: http://svn.apache.org/r1581025
>> > Log:
>> > Two test methods are missing the "is" predicate, which some other
>> methods use.
>> >
>> > Modified:
>> >
>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java?rev=1581025&r1=1581024&r2=1581025&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
>> Mon Mar 24 20:03:13 2014
>> > @@ -151,7 +151,7 @@ public final class Level implements Comp
>> > * @param level The level to check.
>> > * @return True if the passed Level is more specific or the same as
>> this Level.
>> > */
>> > - public boolean lessOrEqual(final Level level) {
>> > + public boolean isLessOrEqual(final Level level) {
>> > return this.intLevel <= level.intLevel;
>> > }
>> >
>> > @@ -160,7 +160,7 @@ public final class Level implements Comp
>> > * @param level The level to check.
>> > * @return True if the passed Level is more specific or the same as
>> this Level.
>> > */
>> > - public boolean lessOrEqual(final int level) {
>> > + public boolean isLessOrEqual(final int level) {
>> > return this.intLevel <= level;
>> > }
>> >
>> >
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
Matt Sicker <bo...@gmail.com>
Re: svn commit: r1581025 - /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Mar 24, 2014 at 5:14 PM, Ralph Goers <ra...@dslextreme.com>wrote:
> This change breaks binary compatibility and so needs to be documented in
> changes.xml.
>
Good catch, done.
Gary
>
> Ralph
>
> On Mar 24, 2014, at 1:03 PM, ggregory@apache.org wrote:
>
> > Author: ggregory
> > Date: Mon Mar 24 20:03:13 2014
> > New Revision: 1581025
> >
> > URL: http://svn.apache.org/r1581025
> > Log:
> > Two test methods are missing the "is" predicate, which some other
> methods use.
> >
> > Modified:
> >
> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
> >
> > Modified:
> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java?rev=1581025&r1=1581024&r2=1581025&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
> (original)
> > +++
> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/Level.java
> Mon Mar 24 20:03:13 2014
> > @@ -151,7 +151,7 @@ public final class Level implements Comp
> > * @param level The level to check.
> > * @return True if the passed Level is more specific or the same as
> this Level.
> > */
> > - public boolean lessOrEqual(final Level level) {
> > + public boolean isLessOrEqual(final Level level) {
> > return this.intLevel <= level.intLevel;
> > }
> >
> > @@ -160,7 +160,7 @@ public final class Level implements Comp
> > * @param level The level to check.
> > * @return True if the passed Level is more specific or the same as
> this Level.
> > */
> > - public boolean lessOrEqual(final int level) {
> > + public boolean isLessOrEqual(final int level) {
> > return this.intLevel <= level;
> > }
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory