You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alexander Saydakov (Code Review)" <ge...@cloudera.org> on 2021/10/07 22:03:03 UTC

[Impala-ASF-CR] IMPALA-10956: datasketches UDFs: memory leak and merge overhead

Hello Fucun Chu, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17869

to look at the new patch set (#3).

Change subject: IMPALA-10956: datasketches UDFs: memory leak and merge overhead
......................................................................

IMPALA-10956: datasketches UDFs: memory leak and merge overhead

- call destructors of sketch and union objects
- avoid overhead of constructing union and getting result from it every time

Change-Id: I8dd0e6736f4266f74f5f265f58d40a4e4707287f
---
M be/src/exprs/aggregate-functions-ir.cc
1 file changed, 273 insertions(+), 195 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/17869/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8dd0e6736f4266f74f5f265f58d40a4e4707287f
Gerrit-Change-Number: 17869
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Saydakov <al...@apache.org>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>