You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by ni...@apache.org on 2019/08/09 19:50:05 UTC

[lucenenet] 04/09: build/Dependencies.props: Added reminder to lock down the ICU4N package dependency version when it is stable. The Lucene.Net.ICU resources are not compatible with versions of ICU other than 60.1.

This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git

commit fde5bdc2664f551a1df5fefbfc9d650bab2eb7d6
Author: Shad Storhaug <sh...@shadstorhaug.com>
AuthorDate: Fri Aug 9 19:54:06 2019 +0700

    build/Dependencies.props: Added reminder to lock down the ICU4N package dependency version when it is stable. The Lucene.Net.ICU resources are not compatible with versions of ICU other than 60.1.
---
 build/Dependencies.props | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/build/Dependencies.props b/build/Dependencies.props
index 397eea7..b7a63b7 100644
--- a/build/Dependencies.props
+++ b/build/Dependencies.props
@@ -21,6 +21,17 @@
 <Project> 
   <PropertyGroup Label="NuGet Package Reference Versions">
     <Antlr3RuntimePackageVersion>3.5.1</Antlr3RuntimePackageVersion>
+    <!-- LUCENENET TODO: When ICU4N is released to production,
+        be sure to lock down the version range below. The resource
+        files in Lucene.Net.ICU are not compatible with any other
+        ICU version than 60.1!! This should only change if ICU4N
+        is upgraded AND the resources in Lucene.Net.ICU are upgraded to match.
+        Note that some of the files need to be generated.
+        The resource files to sync include .nrm files, .brk files, and .rbbi files.
+        They can be generated based off of the files here:
+        https://github.com/apache/lucene-solr/tree/31d7ec7bbfdcd2c4cc61d9d35e962165410b65fe/lucene/analysis/icu/src/data/utr30
+        Just make sure they are adjusted to the right version of ICU/Lucene.
+    <ICU4NPackageVersion>[60.1,60.2)</ICU4NPackageVersion> -->
     <ICU4NPackageVersion>60.1.0-alpha.52</ICU4NPackageVersion>
     <ICU4NCollationPackageVersion>$(ICU4NPackageVersion)</ICU4NCollationPackageVersion>
     <ICU4NCurrencyDataPackageVersion>$(ICU4NPackageVersion)</ICU4NCurrencyDataPackageVersion>