You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/06 06:28:22 UTC
[GitHub] [incubator-tvm] zhen-jia opened a new pull request #5000: And opt
out operator for has_multiple_inputs for graph tuner
zhen-jia opened a new pull request #5000: And opt out operator for has_multiple_inputs for graph tuner
URL: https://github.com/apache/incubator-tvm/pull/5000
If layout_transform is in the graph, graph tuner’s has_multiple_inputs will give wrong answer. This PR is to solve this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request
#5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph
tuner
Posted by GitBox <gi...@apache.org>.
kevinthesun commented on a change in pull request #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner
URL: https://github.com/apache/incubator-tvm/pull/5000#discussion_r389064158
##########
File path: python/tvm/autotvm/graph_tuner/dynamic_programming_tuner.py
##########
@@ -57,6 +59,8 @@ def __init__(self, *args, **kwargs):
"input_shapes": self._input_shapes,
"layout_transform_interlayer_cost": self._layout_transform_interlayer_cost
}
+ self._opt_out_op = OPT_OUT_OP
Review comment:
We don't need to do this again for sub class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhen-jia commented on issue #5000: [Graph tuner]Add
opt out operator for has_multiple_inputs for graph tuner
Posted by GitBox <gi...@apache.org>.
zhen-jia commented on issue #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner
URL: https://github.com/apache/incubator-tvm/pull/5000#issuecomment-596927909
> @zhen-jia Overall lgtm. Can you take a look at the ci failure?
I am working on it and fixed the failures on my part. The current failure reported by rust test. It does not seem like caused by my changes. Any ideas? @kevinthesun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhen-jia commented on a change in pull request
#5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph
tuner
Posted by GitBox <gi...@apache.org>.
zhen-jia commented on a change in pull request #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner
URL: https://github.com/apache/incubator-tvm/pull/5000#discussion_r389065582
##########
File path: python/tvm/autotvm/graph_tuner/dynamic_programming_tuner.py
##########
@@ -57,6 +59,8 @@ def __init__(self, *args, **kwargs):
"input_shapes": self._input_shapes,
"layout_transform_interlayer_cost": self._layout_transform_interlayer_cost
}
+ self._opt_out_op = OPT_OUT_OP
Review comment:
I see. I will remove that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] kevinthesun merged pull request #5000: [Graph
tuner]Add opt out operator for has_multiple_inputs for graph tuner
Posted by GitBox <gi...@apache.org>.
kevinthesun merged pull request #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner
URL: https://github.com/apache/incubator-tvm/pull/5000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhen-jia opened a new pull request #5000: And opt
out operator for has_multiple_inputs for graph tuner
Posted by GitBox <gi...@apache.org>.
zhen-jia opened a new pull request #5000: And opt out operator for has_multiple_inputs for graph tuner
URL: https://github.com/apache/incubator-tvm/pull/5000
If layout_transform is in the graph, graph tuner’s has_multiple_inputs will give wrong answer. This PR is to solve this problem.
@kevinthesun please help to review this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] kevinthesun commented on issue #5000: [Graph
tuner]Add opt out operator for has_multiple_inputs for graph tuner
Posted by GitBox <gi...@apache.org>.
kevinthesun commented on issue #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner
URL: https://github.com/apache/incubator-tvm/pull/5000#issuecomment-597466343
You can create a dummy commit and re-trigger ci.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] kevinthesun commented on issue #5000: [Graph
tuner]Add opt out operator for has_multiple_inputs for graph tuner
Posted by GitBox <gi...@apache.org>.
kevinthesun commented on issue #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner
URL: https://github.com/apache/incubator-tvm/pull/5000#issuecomment-596810383
@zhen-jia Overall lgtm. Can you take a look at the ci failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] kevinthesun commented on issue #5000: [Graph
tuner]Add opt out operator for has_multiple_inputs for graph tuner
Posted by GitBox <gi...@apache.org>.
kevinthesun commented on issue #5000: [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner
URL: https://github.com/apache/incubator-tvm/pull/5000#issuecomment-598824316
Thanks @zhen-jia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhen-jia closed pull request #5000: And opt out
operator for has_multiple_inputs for graph tuner
Posted by GitBox <gi...@apache.org>.
zhen-jia closed pull request #5000: And opt out operator for has_multiple_inputs for graph tuner
URL: https://github.com/apache/incubator-tvm/pull/5000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services