You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/06/25 21:06:15 UTC
[I] [Variant] Remove explicit ObjectBuilder::finish() and ListBuilder::finish and move to `Drop` impl [arrow-rs]
alamb opened a new issue, #7780:
URL: https://github.com/apache/arrow-rs/issues/7780
Looking at these examples, it seems to me like the current API requires calling`finish`
One problem with this is that it requires someone to remember to call `finish` otherwise their object will only be half written
it seems like it might be a nicer API if that just happened on `drop()` -- so you could use the scope of the example, like you have here, and the dropping would just complete the object
This would be a great follow on PR
_Originally posted by @alamb in https://github.com/apache/arrow-rs/pull/7778#discussion_r2167608750_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Variant] Remove explicit ObjectBuilder::finish() and ListBuilder::finish and move to `Drop` impl [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #7780:
URL: https://github.com/apache/arrow-rs/issues/7780#issuecomment-3130010028
`label_issue.py` automatically added labels {'parquet'} from #7843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Variant] Remove explicit ObjectBuilder::finish() and ListBuilder::finish and move to `Drop` impl [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #7780: [Variant] Remove explicit ObjectBuilder::finish() and ListBuilder::finish and move to `Drop` impl
URL: https://github.com/apache/arrow-rs/issues/7780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org