You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2021/05/01 01:12:33 UTC

[skywalking-rocketbot-ui] branch master updated: fix: update independentSelector in dashboard (#487)

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-rocketbot-ui.git


The following commit(s) were added to refs/heads/master by this push:
     new bc16a90  fix: update independentSelector in dashboard (#487)
bc16a90 is described below

commit bc16a90ae9f8ea78d599420a27d5ce64b9851113
Author: Qiuxia Fan <fi...@outlook.com>
AuthorDate: Sat May 1 09:12:21 2021 +0800

    fix: update independentSelector in dashboard (#487)
---
 src/views/components/dashboard/charts/chart-edit.vue | 1 +
 src/views/components/dashboard/charts/constant.ts    | 4 ++--
 src/views/components/trace/trace-search.vue          | 2 --
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/views/components/dashboard/charts/chart-edit.vue b/src/views/components/dashboard/charts/chart-edit.vue
index 2254416..3124571 100755
--- a/src/views/components/dashboard/charts/chart-edit.vue
+++ b/src/views/components/dashboard/charts/chart-edit.vue
@@ -433,6 +433,7 @@ limitations under the License. -->
         } else {
           this.EDIT_COMP_CONFIG({ index: this.index, values: { [params.type]: this.itemConfig[params.type] } });
         }
+        return;
       }
       if (params.type === 'aggregation' && ['milliseconds', 'seconds'].includes(this.itemConfig.aggregation)) {
         this.updateAggregation(params);
diff --git a/src/views/components/dashboard/charts/constant.ts b/src/views/components/dashboard/charts/constant.ts
index 619e74a..6fbd643 100644
--- a/src/views/components/dashboard/charts/constant.ts
+++ b/src/views/components/dashboard/charts/constant.ts
@@ -29,8 +29,8 @@ export const BrowserEntityType = [
 ];
 
 export const IndependentType = [
-  { key: 'true', label: 'Self selectors' },
-  { key: 'false', label: 'Common selectors' },
+  { key: true, label: 'Self selectors' },
+  { key: false, label: 'Common selectors' },
 ];
 
 export enum MetricsType {
diff --git a/src/views/components/trace/trace-search.vue b/src/views/components/trace/trace-search.vue
index 79ea57b..75d8de4 100644
--- a/src/views/components/trace/trace-search.vue
+++ b/src/views/components/trace/trace-search.vue
@@ -221,10 +221,8 @@ limitations under the License. -->
         temp.traceId = this.traceId;
       }
       localStorage.setItem('traceId', this.traceId);
-      
       temp.tags = this.tagsMap;
       localStorage.setItem('traceTags', JSON.stringify(this.tagsList));
-      
       this.SET_TRACE_FORM(temp);
       this.$eventBus.$emit('SET_LOADING_TRUE', () => {
         this.GET_TRACELIST().then(() => {