[jira] [Commented] (HADOOP-18516) [ABFS]: Support fixed SAS token config in addition to SAS Token Provider class

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635901#comment-17635901 ] 

ASF GitHub Bot commented on HADOOP-18516:
-----------------------------------------

sreeb-msft opened a new pull request, #5148:
URL: https://github.com/apache/hadoop/pull/5148

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
   -->
   This PR introduces a new configuration for Fixed SAS Tokens. 
   
   Users can either set the fixed SAS Tokens in the configuration itself or provide an implementation of the SASTokenProvider interface, using which a SAS Token can be obtained from the user. The code checks for which is set. In case of both being set, preference is given to the SASTokenProvider implementation. Whereas, in the case of either one being set, that is chosen for creation of the URIs for the HTTP requests for various API calls. 
   
   #### Test Code added: 
   4 test cases have been added that tests the conditions mentioned above - whether both token provider class and fixed token configuration are set, whether both are unset, or whether either one is set. It checks for both whether the correct choice of SAS token is made and whether further API calls can be made using the SAS Token chosen.




> [ABFS]: Support fixed SAS token config in addition to SAS Token Provider class
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-18516
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18516
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/azure
>    Affects Versions: 3.3.4
>            Reporter: Sree Bhattacharyya
>            Assignee: Sree Bhattacharyya
>            Priority: Minor
>
> Introduce a new configuration for setting the fixed account/service SAS token in ABFS driver. This will be in addition to the implementations of the SASTokenProvider interface that can be used for obtaining a SAS Token from the user.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org