You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/22 11:12:24 UTC
[GitHub] [hadoop-ozone] elek opened a new pull request #479: HDDS-2925.
Remove hdfs-client dependency from hdds-common
elek opened a new pull request #479: HDDS-2925. Remove hdfs-client dependency from hdds-common
URL: https://github.com/apache/hadoop-ozone/pull/479
## What changes were proposed in this pull request?
As of now we have a `hdds-common` -> `hdfs-client` dependency but in reality we don't use any important thing from hdfs-client, only a few string utils.
I would propose to remove this dependency to have a safer / smaller and more independent ozone package.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2925
## How was this patch tested?
Tested with build only (will see the acceptance test results) as there is no big modification. I put back the dependency to the SCM server in *test* scope (!) as some client utils are used to test the secure availability of the HTTP servers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] anuengineer commented on issue #479: HDDS-2925.
Remove hdfs-client dependency from hdds-common
Posted by GitBox <gi...@apache.org>.
anuengineer commented on issue #479: HDDS-2925. Remove hdfs-client dependency from hdds-common
URL: https://github.com/apache/hadoop-ozone/pull/479#issuecomment-577816708
One more push with Rat and Checkstyle and other oddities, please. I will commit as soon as we get a good run. Once more, thank you very much for these patches. I really like them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek closed pull request #479: HDDS-2925. Remove
hdfs-client dependency from hdds-common
Posted by GitBox <gi...@apache.org>.
elek closed pull request #479: HDDS-2925. Remove hdfs-client dependency from hdds-common
URL: https://github.com/apache/hadoop-ozone/pull/479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#479: HDDS-2925. Remove hdfs-client dependency from hdds-common
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #479: HDDS-2925. Remove hdfs-client dependency from hdds-common
URL: https://github.com/apache/hadoop-ozone/pull/479#discussion_r370535035
##########
File path: hadoop-ozone/dev-support/checks/unit.sh
##########
@@ -17,7 +17,7 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
export MAVEN_OPTS="-Xmx4096m"
-mvn -B -DskipShade -Dskip.yarn -fae test -pl \!:hadoop-ozone-integration-test "$@"
+mvn -B -DskipShade -Dskip.yarn -fae install -pl \!:hadoop-ozone-integration-test "$@"
Review comment:
Can you please explain the goal of this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #479:
HDDS-2925. Remove hdfs-client dependency from hdds-common
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #479: HDDS-2925. Remove hdfs-client dependency from hdds-common
URL: https://github.com/apache/hadoop-ozone/pull/479#discussion_r370645314
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/StingUtils.java
##########
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdds;
+
+import java.io.UnsupportedEncodingException;
+import java.nio.charset.StandardCharsets;
+
+/**
+ * Simple utility class to collection string conversion methods.
+ */
+public final class StingUtils {
Review comment:
Not sure what is is your exact problem with [Sting](https://en.wikipedia.org/wiki/Sting_%28musician%29) but changed it to a more boring one ;-)
(=thanks, fixed it)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #479:
HDDS-2925. Remove hdfs-client dependency from hdds-common
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #479: HDDS-2925. Remove hdfs-client dependency from hdds-common
URL: https://github.com/apache/hadoop-ozone/pull/479#discussion_r370642521
##########
File path: hadoop-ozone/dev-support/checks/unit.sh
##########
@@ -17,7 +17,7 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
export MAVEN_OPTS="-Xmx4096m"
-mvn -B -DskipShade -Dskip.yarn -fae test -pl \!:hadoop-ozone-integration-test "$@"
+mvn -B -DskipShade -Dskip.yarn -fae install -pl \!:hadoop-ozone-integration-test "$@"
Review comment:
I tried to understand why the unit tests are failed and I was afraid that some changes are missing because the missing install phase. But I think it was because the tricky provided dependency between hdfs server and hdfs.
I reverted the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#479: HDDS-2925. Remove hdfs-client dependency from hdds-common
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #479: HDDS-2925. Remove hdfs-client dependency from hdds-common
URL: https://github.com/apache/hadoop-ozone/pull/479#discussion_r370533680
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/StingUtils.java
##########
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdds;
+
+import java.io.UnsupportedEncodingException;
+import java.nio.charset.StandardCharsets;
+
+/**
+ * Simple utility class to collection string conversion methods.
+ */
+public final class StingUtils {
Review comment:
```suggestion
public final class StringUtils {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #479: HDDS-2925. Remove
hdfs-client dependency from hdds-common
Posted by GitBox <gi...@apache.org>.
elek commented on issue #479: HDDS-2925. Remove hdfs-client dependency from hdds-common
URL: https://github.com/apache/hadoop-ozone/pull/479#issuecomment-579154446
Thanks the review @adoroszlai and @anuengineer. I am merged it to the master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #479: HDDS-2925. Remove
hdfs-client dependency from hdds-common
Posted by GitBox <gi...@apache.org>.
elek commented on issue #479: HDDS-2925. Remove hdfs-client dependency from hdds-common
URL: https://github.com/apache/hadoop-ozone/pull/479#issuecomment-578041107
Thank you very much to support this effort @anuengineer.
It turned out to be more messy than I thought: hadoop-hdfs (server) has no compile time dependency on hdfs-client but throws class not found exception at runtime if it's not there (I think it's a wrong usage of `provided` maven dependency scope).
I put hdfs-client back to our *server* side dependency. And will continue the cleanup in follow-up jiras.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org