You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/16 22:10:38 UTC

[GitHub] TisonKun opened a new pull request #7516: [FLINK-11360] [test] Check and remove LocalFlinkMiniClusterITCase

TisonKun opened a new pull request #7516: [FLINK-11360] [test] Check and remove LocalFlinkMiniClusterITCase
URL: https://github.com/apache/flink/pull/7516
 
 
   ## What is the purpose of the change
   
   Check tests in LocalFlinkMiniClusterITCase whether they also apply to the MiniCluster and port if necessary. Afterwards remove LocalFlinkMiniClusterITCase.
   
   ## Brief change log
   
   `LocalFlinkMiniClusterITCase` contains only `testLocalFlinkMiniClusterWithMultipleTaskManagers`. We don't cover multi TMs case in `MiniClusterITCase`. Thus add it. For implementation, simply test positive cases that a job with `numOfTMs * slotPerTM` can run with corresponding TMs and slots. negative cases test manually.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   `MiniClusterITCase#runJobWithSingleRpcService` and `MiniClusterITCase#runJobWithMultipleRpcServices` are now covered multi TMs case.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   
   cc @tillrohrmann 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services