[GitHub] [arrow-rs] alamb commented on a change in pull request #1286: Fix simd comparison kernels

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1286:
URL: https://github.com/apache/arrow-rs/pull/1286#discussion_r800869101



##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -2442,6 +2442,20 @@ mod tests {
             let b = b.slice(0, b.len());
             let c = $DYN_KERNEL(a.as_ref(), b.as_ref()).unwrap();
             assert_eq!(BooleanArray::from($EXPECTED), c);
+

Review comment:
       👍  in case anyone else is curious, without the code fix, this test fails like this:
   
   ```shell
   
   ---- compute::kernels::comparison::tests::test_primitive_array_eq stdout ----
   thread 'compute::kernels::comparison::tests::test_primitive_array_eq' panicked at 'assertion failed: `(left == right)`
     left: `BooleanArray
   [
     false,
     false,
     true,
     false,
     false,
     false,
     false,
     true,
     false,
     false,
     ...80 elements...,
     false,
     false,
     true,
     false,
     false,
     false,
     false,
     true,
     false,
     false,
   ]`,
    right: `BooleanArray
   [
     false,
     false,
     true,
     true,
     true,
     true,
     true,
     true,
     true,
     true,
     ...80 elements...,
     false,
     false,
     true,
     false,
     false,
     false,
     false,
     true,
     false,
     false,
   ]`', arrow/src/compute/kernels/comparison.rs:2486:9
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   ...
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org