You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2023/07/20 10:42:30 UTC
[GitHub] [arrow] thisisnic opened a new pull request, #36788: GH-36787: [R] lintr update leads to failing tests on main
thisisnic opened a new pull request, #36788:
URL: https://github.com/apache/arrow/pull/36788
### What changes are included in this PR?
Turning off the newly introduced indentation linter as it causes test failures, and isn't in sync with styler which we use to style our code.
### Are these changes tested?
No, is linter config.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #36788: GH-36787: [R] lintr update leads to failing tests on main
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #36788:
URL: https://github.com/apache/arrow/pull/36788#issuecomment-1644278346
> Thanks! Just curious...is it worth fixing the indentation problems or are they spurious?
Good question! I had a look at some of them, and they seem to be stylistic choices which don't make the code look better rather than fixing true problems. More importantly, using `make style` doesn't "correct" them to the new lintr standards, so it seems problematic to enable it right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36788: GH-36787: [R] lintr update leads to failing tests on main
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36788:
URL: https://github.com/apache/arrow/pull/36788#issuecomment-1656492601
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit fca6a6633300694ae9089e92b736ce7d95fd7ed7.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15444404181) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic merged pull request #36788: GH-36787: [R] lintr update leads to failing tests on main
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #36788:
URL: https://github.com/apache/arrow/pull/36788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org