You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by st...@apache.org on 2014/06/04 09:56:39 UTC

svn commit: r1599962 - in /sling/trunk/tooling/ide: eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingLaunchpadBehaviour.java impl-vlt/src/org/apache/sling/ide/impl/vlt/AddOrUpdateNodeCommand.java

Author: stefanegli
Date: Wed Jun  4 07:56:38 2014
New Revision: 1599962

URL: http://svn.apache.org/r1599962
Log:
no-jira : more debug information in error case

Modified:
    sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingLaunchpadBehaviour.java
    sling/trunk/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/AddOrUpdateNodeCommand.java

Modified: sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingLaunchpadBehaviour.java
URL: http://svn.apache.org/viewvc/sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingLaunchpadBehaviour.java?rev=1599962&r1=1599961&r2=1599962&view=diff
==============================================================================
--- sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingLaunchpadBehaviour.java (original)
+++ sling/trunk/tooling/ide/eclipse-core/src/org/apache/sling/ide/eclipse/core/internal/SlingLaunchpadBehaviour.java Wed Jun  4 07:56:38 2014
@@ -365,8 +365,8 @@ public class SlingLaunchpadBehaviour ext
 
         if (!result.isSuccess()) {
             // TODO - proper error logging
-            throw new CoreException(new Status(Status.ERROR, Activator.PLUGIN_ID, "Failed publishing "
-                    + result.toString()));
+            throw new CoreException(new Status(Status.ERROR, Activator.PLUGIN_ID, "Failed publishing path="
+                    + command.getPath() + ", result=" + result.toString()));
         }
 
     }

Modified: sling/trunk/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/AddOrUpdateNodeCommand.java
URL: http://svn.apache.org/viewvc/sling/trunk/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/AddOrUpdateNodeCommand.java?rev=1599962&r1=1599961&r2=1599962&view=diff
==============================================================================
--- sling/trunk/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/AddOrUpdateNodeCommand.java (original)
+++ sling/trunk/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/AddOrUpdateNodeCommand.java Wed Jun  4 07:56:38 2014
@@ -366,14 +366,18 @@ public class AddOrUpdateNodeCommand exte
             }
 
             if (value != null) {
-                node.setProperty(propertyName, value);
                 Object[] arguments = { propertyName, value, propertyValue, node.getPath() };
                 Activator.getDefault().getPluginLogger()
+                        .trace("Setting property {0} with value {1} (raw =  {2}) on node at {3}", arguments);
+                node.setProperty(propertyName, value);
+                Activator.getDefault().getPluginLogger()
                         .trace("Set property {0} with value {1} (raw =  {2}) on node at {3}", arguments);
             } else if (values != null) {
-                node.setProperty(propertyName, values);
                 Object[] arguments = { propertyName, values, propertyValue, node.getPath() };
                 Activator.getDefault().getPluginLogger()
+                        .trace("Setting property {0} with values {1} (raw =  {2}) on node at {3}", arguments);
+                node.setProperty(propertyName, values);
+                Activator.getDefault().getPluginLogger()
                         .trace("Set property {0} with values {1} (raw =  {2}) on node at {3}", arguments);
             } else {
                 throw new IllegalArgumentException("Unable to extract a value or a value array for property '"