You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/02/24 18:12:23 UTC

[PR] HDDS-12198. Exclude Recon generated code in coverage [ozone]

adoroszlai opened a new pull request, #7962:
URL: https://github.com/apache/ozone/pull/7962

   ## What changes were proposed in this pull request?
   
   1. Fix package hierarchy name `org.hadoop.ozone` to `org.apache.ozone`.
   2. Move generated code into `org.apache.ozone.recon.schema.generated`, so that it can be excluded by coverage calculation.
   3. Also exclude `org.apache.ozone.recon.codegen` for coverage calculation.
   
   https://issues.apache.org/jira/browse/HDDS-12198
   
   ## How was this patch tested?
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/13503133196
   
   `org.apache.ozone.recon.schema` has 99% coverage after the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12198. Exclude Recon generated code in coverage [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7962:
URL: https://github.com/apache/ozone/pull/7962#issuecomment-2680526596

   Thanks @devmadhuu for the review.
   
   > why are we excluding `org.hadoop.ozone.recon.codegen` package from coverage ? I mean this package does not contain generated code, its the code which is related to schema definition and , some util classes etc.
   
   `JooqCodeGenerator` and `TableNamingStrategy` are used at build time.  Coverage is calculated based on class usage at runtime.  So coverage for these classes is 0%.
   
   You are right that some other code is used at runtime (`SqlDbUtils`, `ReconSchemaGenerationModule`, `ReconSqlDbConfig`).  I'll move those out of the `...codegen` package.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12198. Exclude Recon generated code in coverage [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7962:
URL: https://github.com/apache/ozone/pull/7962#issuecomment-2683003912

   Thanks @devmadhuu, @nandakumar131 for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12198. Exclude Recon generated code in coverage [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7962:
URL: https://github.com/apache/ozone/pull/7962


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12198. Exclude Recon generated code in coverage [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7962:
URL: https://github.com/apache/ozone/pull/7962#issuecomment-2679491074

   Thanks @nandakumar131 for the review.  Let's wait if @ArafatKhan2198 or @devmadhuu have any concerns.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org