You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/21 05:42:45 UTC
[GitHub] [netbeans] jlahoda opened a new pull request #2095: If cancel happens while Analyzer is running, AssertionError is thrown…
jlahoda opened a new pull request #2095:
URL: https://github.com/apache/netbeans/pull/2095
…. Rather ignore all exception happening while the parser is cancelled.
While running without nb-javac, the AssertionErrors from Analyzer due to cancellation are about 1/2 of javac-related exceptions I see. So feels like something worthy to solve. Theoretically, this can lead to ignored exceptions - but I don't think we really care about anything if the parser is cancelled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #2095: If cancel happens while Analyzer is running, AssertionError is thrown…
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #2095:
URL: https://github.com/apache/netbeans/pull/2095#discussion_r413017572
##########
File path: java/java.source.base/src/org/netbeans/modules/java/source/parsing/JavacParser.java
##########
@@ -709,9 +709,14 @@ Phase moveToPhase (final Phase phase, final CompilationInfoImpl currentInfo, Lis
} catch (Abort abort) {
parserError = currentPhase;
} catch (RuntimeException | Error ex) {
Review comment:
Perhaps this should be catching AssertionError more specifically, rather than Error in general, giving other kinds of Error the old behavior. Though I'm fine with either approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] arvindaprameya commented on issue #2095: If cancel happens while Analyzer is running, AssertionError is thrown…
Posted by GitBox <gi...@apache.org>.
arvindaprameya commented on issue #2095:
URL: https://github.com/apache/netbeans/pull/2095#issuecomment-617561664
+ 1 Approved, Thanks Jan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists