You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mimaison (via GitHub)" <gi...@apache.org> on 2023/06/15 10:59:10 UTC
[GitHub] [kafka] mimaison opened a new pull request, #13859: KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests
mimaison opened a new pull request, #13859:
URL: https://github.com/apache/kafka/pull/13859
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on a diff in pull request #13859: KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on code in PR #13859:
URL: https://github.com/apache/kafka/pull/13859#discussion_r1239984189
##########
tests/kafkatest/tests/core/upgrade_test.py:
##########
@@ -94,6 +94,12 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None):
self.wait_until_rejoin()
@cluster(num_nodes=6)
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["none"])
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["lz4"])
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["snappy"])
Review Comment:
Oh, I agree, this definitely needs to not be in this pull request, I was just wondering in case the answer was on top of your head
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on pull request #13859: KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on PR #13859:
URL: https://github.com/apache/kafka/pull/13859#issuecomment-1601121985
I believe this (https://github.com/apache/kafka/blob/trunk/tests/kafkatest/version.py#L246-L248) should be changed to
```
...
V_3_4_1 = KafkaVersion("3.4.1")
LATEST_3_4 = V_3_4_1
```
as part of this pull request, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on a diff in pull request #13859: KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on code in PR #13859:
URL: https://github.com/apache/kafka/pull/13859#discussion_r1237243060
##########
tests/kafkatest/tests/core/upgrade_test.py:
##########
@@ -94,6 +94,12 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None):
self.wait_until_rejoin()
@cluster(num_nodes=6)
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["none"])
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["lz4"])
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["snappy"])
Review Comment:
A general question because I have been going into this part of the codebase - is there a reason why the other two compression types are not tested (i.e. gzip, zstd)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on a diff in pull request #13859: KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on code in PR #13859:
URL: https://github.com/apache/kafka/pull/13859#discussion_r1239984189
##########
tests/kafkatest/tests/core/upgrade_test.py:
##########
@@ -94,6 +94,12 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None):
self.wait_until_rejoin()
@cluster(num_nodes=6)
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["none"])
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["lz4"])
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["snappy"])
Review Comment:
Oh, I agree, this definitely needs to not be in this pull request, I was just wondering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #13859: KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #13859:
URL: https://github.com/apache/kafka/pull/13859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on a diff in pull request #13859: KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #13859:
URL: https://github.com/apache/kafka/pull/13859#discussion_r1238507645
##########
tests/kafkatest/tests/core/upgrade_test.py:
##########
@@ -94,6 +94,12 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None):
self.wait_until_rejoin()
@cluster(num_nodes=6)
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["none"])
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["lz4"])
+ @parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["snappy"])
Review Comment:
To be honest I don't know. At this point, we've copied the same lines as the previous releases. Maybe this could be improved. If so I'd rather separate it from this PR and handle this out of a release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org