You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/12/11 10:10:22 UTC
[kudu-CR] WIP: webserver: fix SPNEGO handling for some clients
Hello Thomas Tauber-Marshall, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14890
to review the following change.
Change subject: WIP: webserver: fix SPNEGO handling for some clients
......................................................................
WIP: webserver: fix SPNEGO handling for some clients
In testing with Apache Knox (which uses Apache HttpClient), I found that
when the web UI required SPNEGO, Knox failed to establish a connection. The
log showed it sending an initial GET to the web UI, receiving the expected
"401 Forbidden" response, sending a follow-on GET with the appropriate
authentication token, receiving an EOF response, and throwing an exception.
Some 401 handling in squeasel caught my eye, and experimentation yielded
this fix.
Change-Id: I417ef69db51ca34f25e8bdb886260f2512d5bf93
WIP: I don't understand it, and it needs automated tests.
---
M src/kudu/server/webserver.cc
1 file changed, 28 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/14890/1
--
To view, visit http://gerrit.cloudera.org:8080/14890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I417ef69db51ca34f25e8bdb886260f2512d5bf93
Gerrit-Change-Number: 14890
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP: webserver: fix SPNEGO handling for some clients
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/14890 )
Change subject: WIP: webserver: fix SPNEGO handling for some clients
......................................................................
Abandoned
I couldn't find anything in the HTTP spec to support this behavior, so ended up going in a different direction with a targeted fix in squeasel.
--
To view, visit http://gerrit.cloudera.org:8080/14890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I417ef69db51ca34f25e8bdb886260f2512d5bf93
Gerrit-Change-Number: 14890
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>