You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2014/01/23 22:37:42 UTC
svn commit: r1560817 -
/tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java
Author: remm
Date: Thu Jan 23 21:37:42 2014
New Revision: 1560817
URL: http://svn.apache.org/r1560817
Log:
Fix some arcane introspection errors.
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java?rev=1560817&r1=1560816&r2=1560817&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java Thu Jan 23 21:37:42 2014
@@ -49,6 +49,12 @@ public abstract class PojoMessageHandler
int indexSession, long maxMessageSize) {
this.pojo = pojo;
this.method = method;
+ try {
+ this.method.setAccessible(true);
+ } catch (Exception e) {
+ // It is better to make sure the method is accessible, but
+ // ignore exceptions and hope for the best
+ }
this.session = session;
this.params = params;
this.indexPayload = indexPayload;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1560817 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java
Posted by Mark Thomas <ma...@apache.org>.
On 23/01/2014 21:37, remm@apache.org wrote:
> Author: remm
> Date: Thu Jan 23 21:37:42 2014
> New Revision: 1560817
>
> URL: http://svn.apache.org/r1560817
> Log:
> Fix some arcane introspection errors.
Could you explain what problem this is trying to fix. The method passed
in to this constructor is previously checked with:
if (!Modifier.isPublic(m.getModifiers())) {
throw new DeploymentException(sm.getString(
"pojoMethodMapping.methodNotPublic", m.getName()));
}
Is there a code path where that isn't happening?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org