[GitHub] [commons-ognl] lukaszlenart commented on a change in pull request #46: Minor Changes:

[GitBox <gi...@apache.org>]

lukaszlenart commented on a change in pull request #46:
URL: https://github.com/apache/commons-ognl/pull/46#discussion_r655877580



##########
File path: src/main/java/org/apache/commons/ognl/ASTVarRef.java
##########
@@ -124,7 +124,7 @@ public String toGetSourceString( OgnlContext context, Object target )
             post = ")";
         }
 
-        if ( parent != null && ASTAssign.class.isInstance( parent ) )
+        if (ASTAssign.class.isInstance(parent))

Review comment:
       Why not to use `isinstanceof`?

##########
File path: src/main/java/org/apache/commons/ognl/ASTAdd.java
##########
@@ -129,13 +129,6 @@ boolean isWider( NodeType type, NodeType lastType )
         {
             return false;
         }
-
-        if ( Float.class.isAssignableFrom( type.getGetterClass() )
-            && Integer.class.isAssignableFrom( lastType.getGetterClass() ) )
-        {
-            return true;
-        }

Review comment:
       Why did you remove this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org