You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/02 12:27:41 UTC

[GitHub] [spark] MaxGekk opened a new pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

MaxGekk opened a new pull request #34782:
URL: https://github.com/apache/spark/pull/34782


   ### What changes were proposed in this pull request?
   In the PR, I propose to expose the existing string expression `StartsWith` and `EndsWith` as functions to Spark SQL.
   
   ### Why are the changes needed?
   To make migration from other systems easier for new Spark users. The functions are popular, and broadly used in other systems. For example,
   
   Snowflake:
   https://docs.snowflake.com/en/sql-reference/functions/startswith.html
   https://docs.snowflake.com/en/sql-reference/functions/endswith.html
   
   Cosmos DB:
   https://docs.microsoft.com/en-us/azure/cosmos-db/sql/sql-query-startswith
   https://docs.microsoft.com/en-us/azure/cosmos-db/sql/sql-query-endswith
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   By running new tests:
   ```
   $ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z string-functions.sql"
   $ build/sbt "sql/test:testOnly org.apache.spark.sql.expressions.ExpressionInfoSuite"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984842935


   **[Test build #145862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145862/testReport)** for PR 34782 at commit [`f42b8c4`](https://github.com/apache/spark/commit/f42b8c44aaa2b27ed2fa623d8ab827f3ebd48c09).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984586851


   **[Test build #145856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145856/testReport)** for PR 34782 at commit [`acb321d`](https://github.com/apache/spark/commit/acb321de395d2062c0b79879f0b66b8b49c5e71f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon removed a comment on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-985094661


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984847430


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145862/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984877513


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50337/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-985108136


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984684648


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145856/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984655623


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50331/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-985094661


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984620926


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50331/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984924071


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50337/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34782:
URL: https://github.com/apache/spark/pull/34782


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984842935


   **[Test build #145862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145862/testReport)** for PR 34782 at commit [`f42b8c4`](https://github.com/apache/spark/commit/f42b8c44aaa2b27ed2fa623d8ab827f3ebd48c09).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984847430


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145862/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984936415


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50337/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984684300


   **[Test build #145856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145856/testReport)** for PR 34782 at commit [`acb321d`](https://github.com/apache/spark/commit/acb321de395d2062c0b79879f0b66b8b49c5e71f).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984586851


   **[Test build #145856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145856/testReport)** for PR 34782 at commit [`acb321d`](https://github.com/apache/spark/commit/acb321de395d2062c0b79879f0b66b8b49c5e71f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984684648


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145856/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984847389


   **[Test build #145862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145862/testReport)** for PR 34782 at commit [`f42b8c4`](https://github.com/apache/spark/commit/f42b8c44aaa2b27ed2fa623d8ab827f3ebd48c09).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984678626


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50331/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984678626


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50331/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34782: [SPARK-37520][SQL] Add the `startswith()` and `endswith()` string functions

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34782:
URL: https://github.com/apache/spark/pull/34782#issuecomment-984936415


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50337/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org