You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/06/04 17:50:33 UTC
Re: [PR] support ojdbc6 blob type [shardingsphere]
terrymanu commented on PR #37791:
URL: https://github.com/apache/shardingsphere/pull/37791#issuecomment-4624753605
Hi @daiqiang, thanks for working on the Oracle BLOB fix.
This PR has been inactive since Mar 10, 2026, and the latest review still has pending change requests. In particular, please confirm or address the following points:
- Preserve per-batch setter metadata so batch replay does not reuse the wrong setter type or length.
- Ensure the Oracle parameter replayer SPI is available on the JDBC classpath.
- Avoid introducing a new failure path when resolving database type from the JDBC URL.
- Add a regression test for batch inserts with multiple batches using different setters or lengths.
Could you please update this PR, rebase it onto the latest master, and provide the relevant local verification results by Jun 19, 2026?
If there is no update by then, we will close this PR as inactive to keep the review queue actionable. The linked issue can remain open, and you are welcome to reopen this PR or submit a new one when you have time to continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org