You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/15 08:59:20 UTC

[GitHub] [shardingsphere] jingshanglu opened a new pull request #6045: Refactor pg grammar file, fix #5802

jingshanglu opened a new pull request #6045:
URL: https://github.com/apache/shardingsphere/pull/6045


   Fixes #5802 .
   
   Changes proposed in this pull request:
   - Refactor pg grammar file
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6045: Refactor pg grammar file, fix #5802

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6045:
URL: https://github.com/apache/shardingsphere/pull/6045#discussion_r441251639



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -23,41 +23,92 @@ parameterMarker
     : QUESTION_ literalsType_?
     ;
 
-literals
-    : stringLiterals
-    | numberLiterals
-    | hexadecimalLiterals
-    | bitValueLiterals
-    | booleanLiterals
-    | nullValueLiterals
-    ;
-
-stringLiterals
-    : unicodeEscapes_? STRING_ literalsType_? uescape_?
-    ;
+reserved_keyword
+    : ALL
+	| ANALYSE
+	| ANALYZE
+	| AND
+	| ANY

Review comment:
       Inconsistent rule format.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #6045: Refactor pg grammar file, fix #5802

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #6045:
URL: https://github.com/apache/shardingsphere/pull/6045#discussion_r440615230



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -141,166 +509,836 @@ primaryKey
     : PRIMARY? KEY
     ;
 
-// TODO comb expr
-expr
-    : expr logicalOperator expr
-    | notOperator_ expr
-    | LP_ expr RP_
-    | booleanPrimary
-    ;
-
 logicalOperator
     : OR | OR_ | AND | AND_
     ;
 
-notOperator_
-    : NOT | NOT_
+comparisonOperator
+    : EQ_ | GTE_ | GT_ | LTE_ | LT_ | NEQ_
     ;
 
-booleanPrimary
-    : booleanPrimary IS NOT? (TRUE | FALSE | UNKNOWN | NULL)
-    | booleanPrimary SAFE_EQ_ predicate
-    | booleanPrimary comparisonOperator predicate
-    | booleanPrimary comparisonOperator (ALL | ANY) subquery
-    | predicate
+
+cursor_name
+    : name
+	;
+
+a_expr

Review comment:
       pg's source code is so named and applied directly, in order to be consistent with the source code. It's just an expression.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #6045: Refactor pg grammar file, fix #5802

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6045:
URL: https://github.com/apache/shardingsphere/pull/6045


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #6045: Refactor pg grammar file, fix #5802

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6045:
URL: https://github.com/apache/shardingsphere/pull/6045#issuecomment-644019837


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=h1) Report
   > Merging [#6045](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ff29e3963511f53fe786c6e11d504529d202ea02&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6045/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6045      +/-   ##
   ============================================
   - Coverage     53.13%   53.06%   -0.08%     
     Complexity      438      438              
   ============================================
     Files          1188     1188              
     Lines         20932    20961      +29     
     Branches       3769     3752      -17     
   ============================================
     Hits          11122    11122              
   - Misses         9112     9141      +29     
     Partials        698      698              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...l/parser/postgresql/visitor/PostgreSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9Qb3N0Z3JlU1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=footer). Last update [ff29e39...8656092](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #6045: Refactor pg grammar file, fix #5802

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #6045:
URL: https://github.com/apache/shardingsphere/pull/6045#issuecomment-644019837


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=h1) Report
   > Merging [#6045](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ff29e3963511f53fe786c6e11d504529d202ea02&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6045/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6045      +/-   ##
   ============================================
   - Coverage     53.13%   53.06%   -0.08%     
     Complexity      438      438              
   ============================================
     Files          1188     1188              
     Lines         20932    20961      +29     
     Branches       3769     3752      -17     
   ============================================
     Hits          11122    11122              
   - Misses         9112     9141      +29     
     Partials        698      698              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...l/parser/postgresql/visitor/PostgreSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9Qb3N0Z3JlU1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=footer). Last update [ff29e39...8656092](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6045: Refactor pg grammar file, fix #5802

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6045:
URL: https://github.com/apache/shardingsphere/pull/6045#discussion_r440602767



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -23,41 +23,106 @@ parameterMarker
     : QUESTION_ literalsType_?
     ;
 
-literals
-    : stringLiterals
-    | numberLiterals
-    | hexadecimalLiterals
-    | bitValueLiterals
-    | booleanLiterals
-    | nullValueLiterals
-    ;
+reserved_keyword
+    : ALL
+	| ANALYSE
+	| ANALYZE
+	| AND
+	| ANY
+	| ARRAY
+	| AS
+	| ASC
+	| ASYMMETRIC
+	| BOTH
+	| CASE
+	| CAST
+	| CHECK
+	| COLLATE
+	| COLUMN
+	| CONSTRAINT
+	| CREATE
+	| CURRENT_CATALOG
+	| CURRENT_DATE
+	| CURRENT_ROLE
+	| CURRENT_TIME
+	| CURRENT_TIMESTAMP
+	| CURRENT_USER
+	| DEFAULT
+	| DEFERRABLE
+	| DESC
+	| DISTINCT
+	| DO
+	| ELSE
+	| END
+	| EXCEPT
+	| FALSE
+	| FETCH
+	| FOR
+	| FOREIGN
+	| FROM
+	| GRANT
+	| GROUP
+	| HAVING
+	| IN
+	| INITIALLY
+	| INTERSECT
+	| INTO
+	| LATERAL
+	| LEADING
+	| LIMIT
+	| LOCALTIME
+	| LOCALTIMESTAMP
+	| NOT
+	| NULL
+	| OFFSET
+	| ON
+	| ONLY
+	| OR
+	| ORDER
+	| PLACING
+	| PRIMARY
+	| REFERENCES
+	| RETURNING
+	| SELECT
+	| SESSION_USER
+	| SOME
+	| SYMMETRIC
+	| TABLE
+	| THEN
+	| TO
+	| TRAILING
+	| TRUE
+	| UNION
+	| UNIQUE
+	| USER
+	| USING
+	| VARIADIC
+	| WHEN
+	| WHERE
+	| WINDOW
+	| WITH
+	;
 
-stringLiterals
-    : unicodeEscapes_? STRING_ literalsType_? uescape_?
-    ;
+//literals
+//    : stringLiterals
+//    | numberLiterals
+//    | hexadecimalLiterals

Review comment:
       Remove or remain?

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -118,11 +486,11 @@ name
     ;
 
 tableNames
-    : LP_? tableName (COMMA_ tableName)* RP_?
+    : '('? tableName (COMMA_ tableName)* ')'?

Review comment:
       Is there any difference?

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -141,166 +509,836 @@ primaryKey
     : PRIMARY? KEY
     ;
 
-// TODO comb expr
-expr
-    : expr logicalOperator expr
-    | notOperator_ expr
-    | LP_ expr RP_
-    | booleanPrimary
-    ;
-
 logicalOperator
     : OR | OR_ | AND | AND_
     ;
 
-notOperator_
-    : NOT | NOT_
+comparisonOperator
+    : EQ_ | GTE_ | GT_ | LTE_ | LT_ | NEQ_
     ;
 
-booleanPrimary
-    : booleanPrimary IS NOT? (TRUE | FALSE | UNKNOWN | NULL)
-    | booleanPrimary SAFE_EQ_ predicate
-    | booleanPrimary comparisonOperator predicate
-    | booleanPrimary comparisonOperator (ALL | ANY) subquery
-    | predicate
+
+cursor_name
+    : name
+	;
+
+a_expr
+    : c_expr
+	| a_expr TYPE_CAST_ typeName
+	| a_expr COLLATE anyName
+	| a_expr AT TIME ZONE a_expr
+	| '+' a_expr

Review comment:
       To replace '+' with `Symbol.g4` is ok？

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -73,29 +138,332 @@ uescape_
     ;
     
 unreservedWord
-    : ADMIN | ESCAPE | EXCLUDE | KEY | PARTITION | SET | UNKNOWN 
-    | ADD | ALTER | ALWAYS | CASCADE | COMMIT | CURRENT | DAY 
-    | DELETE | DISABLE | DROP | ENABLE | FUNCTION | GENERATED | INDEX
-    | ISOLATION | LEVEL | OPTION | PRIVILEGES | READ | REVOKE | ROLE 
-    | ROLLBACK | ROWS | START | TRANSACTION | TRUNCATE | YEAR | ACTION 
-    | BEGIN | CACHE | CHARACTERISTICS | CLUSTER | COMMENTS | CONSTRAINTS | CYCLE 
-    | DATA | DATABASE | DEFAULTS | DEFERRED | DEPENDS | DOMAIN | EXCLUDING 
-    | EXECUTE | EXTENDED | EXTENSION | EXTERNAL | EXTRACT | FILTER 
-    | FIRST | FOLLOWING | FORCE | GLOBAL | HOUR | IDENTITY | IF | IMMEDIATE 
-    | INCLUDING | INCREMENT | INDEXES | INHERIT | INHERITS | INCLUDE | INSERT 
-    | LANGUAGE | LARGE | LAST | LOCAL | LOGGED | MAIN | MATCH 
-    | MAXVALUE | MINVALUE | MINUTE | MONTH | NOTHING | NULLS | OBJECT
-    | OF | OIDS | OVER | OWNED | OWNER | PARTIAL | PLAIN
-    | PRECEDING | PROCEDURE | RANGE | RENAME | REPLICA | RESET | RESTART
-    | RESTRICT | ROUTINE | RULE | SAVEPOINT | SCHEMA | SECOND | SECURITY
-    | SEQUENCE | SESSION | SHOW | SIMPLE | STATISTICS | STORAGE | TABLESPACE
-    | TEMP | TEMPORARY | TRIGGER | TYPE | UNBOUNDED | UNLOGGED | UPDATE
-    | USAGE | VALID | VALIDATE | WITHIN | WITHOUT | ZONE | GROUPS
-    | RECURSIVE | INSTANCE | DEFINER | PRESERVE | SQL | LOCAL | CASCADED
-    | CLOSE | OPEN | NEXT | NAME | NAMES | INTEGER | REAL | DECIMAL | TYPE
-    | BOOLEAN | CHAR | TIME | TIMESTAMP | INTERVAL
-    | INT2 | INT4 | INT8 | FLOAT4 | FLOAT8 | MACADDR8 | INT4RANGE | INT8RANGE
-    ;
+    : ABORT
+	| ABSOLUTE
+	| ACCESS
+	| ACTION
+	| ADD
+	| ADMIN
+	| AFTER
+	| AGGREGATE
+	| ALSO
+	| ALTER
+	| ALWAYS
+	| ASSERTION
+	| ASSIGNMENT
+	| AT
+	| ATTACH
+	| ATTRIBUTE
+	| BACKWARD
+	| BEFORE
+	| BEGIN
+	| BY
+	| CACHE
+	| CALL
+	| CALLED
+	| CASCADE
+	| CASCADED
+	| CATALOG
+	| CHAIN
+	| CHARACTERISTICS
+	| CHECKPOINT
+	| CLASS
+	| CLOSE
+	| CLUSTER
+	| COLUMNS
+	| COMMENT
+	| COMMENTS
+	| COMMIT
+	| COMMITTED
+	| CONFIGURATION
+	| CONFLICT
+	| CONNECTION
+	| CONSTRAINTS
+	| CONTENT
+	| CONTINUE
+	| CONVERSION
+	| COPY
+	| COST
+	| CSV
+	| CUBE
+	| CURRENT
+	| CURSOR
+	| CYCLE
+	| DATA
+	| DATABASE
+	| DAY
+	| DEALLOCATE
+	| DECLARE
+	| DEFAULTS
+	| DEFERRED
+	| DEFINER
+	| DELETE
+	| DELIMITER
+	| DELIMITERS
+	| DEPENDS
+	| DETACH
+	| DICTIONARY
+	| DISABLE
+	| DISCARD
+	| DOCUMENT
+	| DOMAIN
+	| DOUBLE
+	| DROP
+	| EACH
+	| ENABLE
+	| ENCODING
+	| ENCRYPTED
+	| ENUM
+	| ESCAPE
+	| EVENT
+	| EXCLUDE
+	| EXCLUDING
+	| EXCLUSIVE
+	| EXECUTE
+	| EXPLAIN
+	| EXPRESSION
+	| EXTENSION
+	| EXTERNAL
+	| FAMILY
+	| FILTER
+	| FIRST
+	| FOLLOWING
+	| FORCE
+	| FORWARD
+	| FUNCTION
+	| FUNCTIONS
+	| GENERATED
+	| GLOBAL
+	| GRANTED
+	| GROUPS
+	| HANDLER
+	| HEADER
+	| HOLD
+	| HOUR
+	| IDENTITY
+	| IF
+	| IMMEDIATE
+	| IMMUTABLE
+	| IMPLICIT
+	| IMPORT
+	| INCLUDE
+	| INCLUDING
+	| INCREMENT
+	| INDEX
+	| INDEXES
+	| INHERIT
+	| INHERITS
+	| INLINE
+	| INPUT
+	| INSENSITIVE
+	| INSERT
+	| INSTEAD
+	| INVOKER
+	| ISOLATION
+	| KEY
+	| LABEL
+	| LANGUAGE
+	| LARGE
+	| LAST
+	| LEAKPROOF
+	| LEVEL
+	| LISTEN
+	| LOAD
+	| LOCAL
+	| LOCATION
+	| LOCK
+	| LOCKED
+	| LOGGED
+	| MAPPING
+	| MATCH
+	| MATERIALIZED
+	| MAXVALUE
+	| METHOD
+	| MINUTE
+	| MINVALUE
+	| MODE
+	| MONTH
+	| MOVE
+	| NAME
+	| NAMES
+	| NEW
+	| NEXT
+	| NFC
+	| NFD
+	| NFKC
+	| NFKD
+	| NO
+	| NORMALIZED
+	| NOTHING
+	| NOTIFY
+	| NOWAIT
+	| NULLS
+	| OBJECT
+	| OF
+	| OFF
+	| OIDS
+	| OLD
+	| OPERATOR
+	| OPTION
+	| OPTIONS
+	| ORDINALITY
+	| OTHERS
+	| OVER
+	| OVERRIDING
+	| OWNED
+	| OWNER
+	| PARALLEL
+	| PARSER
+	| PARTIAL
+	| PARTITION
+	| PASSING
+	| PASSWORD
+	| PLANS
+	| POLICY
+	| PRECEDING
+	| PREPARE
+	| PREPARED
+	| PRESERVE
+	| PRIOR
+	| PRIVILEGES
+	| PROCEDURAL
+	| PROCEDURE
+	| PROCEDURES
+	| PROGRAM
+	| PUBLICATION
+	| QUOTE
+	| RANGE
+	| READ
+	| REASSIGN
+	| RECHECK
+	| RECURSIVE
+	| REF
+	| REFERENCING
+	| REFRESH
+	| REINDEX
+	| RELATIVE
+	| RELEASE
+	| RENAME
+	| REPEATABLE
+	| REPLACE
+	| REPLICA
+	| RESET
+	| RESTART
+	| RESTRICT
+	| RETURNS
+	| REVOKE
+	| ROLE
+	| ROLLBACK
+	| ROLLUP
+	| ROUTINE
+	| ROUTINES
+	| ROWS
+	| RULE
+	| SAVEPOINT
+	| SCHEMA
+	| SCHEMAS
+	| SCROLL
+	| SEARCH
+	| SECOND
+	| SECURITY
+	| SEQUENCE
+	| SEQUENCES
+	| SERIALIZABLE
+	| SERVER
+	| SESSION
+	| SET
+	| SETS
+	| SHARE
+	| SHOW
+	| SIMPLE
+//	| SKIP
+	| SNAPSHOT
+	| SQL
+	| STABLE
+	| STANDALONE
+	| START
+	| STATEMENT
+	| STATISTICS
+	| STDIN
+	| STDOUT
+	| STORAGE
+	| STORED
+	| STRICT
+	| STRIP
+	| SUBSCRIPTION
+	| SUPPORT
+	| SYSID
+	| SYSTEM
+	| TABLES
+	| TABLESPACE
+	| TEMP
+	| TEMPLATE
+	| TEMPORARY
+	| TEXT
+	| TIES
+	| TRANSACTION
+	| TRANSFORM
+	| TRIGGER
+	| TRUNCATE
+	| TRUSTED
+	| TYPE
+	| TYPES
+	| UESCAPE
+	| UNBOUNDED
+	| UNCOMMITTED
+	| UNENCRYPTED
+	| UNKNOWN
+	| UNLISTEN
+	| UNLOGGED
+	| UNTIL

Review comment:
       Is it possible to inline them? It is too long.

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -141,166 +509,836 @@ primaryKey
     : PRIMARY? KEY
     ;
 
-// TODO comb expr
-expr
-    : expr logicalOperator expr
-    | notOperator_ expr
-    | LP_ expr RP_
-    | booleanPrimary
-    ;
-
 logicalOperator
     : OR | OR_ | AND | AND_
     ;
 
-notOperator_
-    : NOT | NOT_
+comparisonOperator
+    : EQ_ | GTE_ | GT_ | LTE_ | LT_ | NEQ_
     ;
 
-booleanPrimary
-    : booleanPrimary IS NOT? (TRUE | FALSE | UNKNOWN | NULL)
-    | booleanPrimary SAFE_EQ_ predicate
-    | booleanPrimary comparisonOperator predicate
-    | booleanPrimary comparisonOperator (ALL | ANY) subquery
-    | predicate
+
+cursor_name

Review comment:
       `cursor_name` looks different from others.

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -141,166 +509,836 @@ primaryKey
     : PRIMARY? KEY
     ;
 
-// TODO comb expr
-expr
-    : expr logicalOperator expr
-    | notOperator_ expr
-    | LP_ expr RP_
-    | booleanPrimary
-    ;
-
 logicalOperator
     : OR | OR_ | AND | AND_
     ;
 
-notOperator_
-    : NOT | NOT_
+comparisonOperator
+    : EQ_ | GTE_ | GT_ | LTE_ | LT_ | NEQ_
     ;
 
-booleanPrimary
-    : booleanPrimary IS NOT? (TRUE | FALSE | UNKNOWN | NULL)
-    | booleanPrimary SAFE_EQ_ predicate
-    | booleanPrimary comparisonOperator predicate
-    | booleanPrimary comparisonOperator (ALL | ANY) subquery
-    | predicate
+
+cursor_name
+    : name
+	;
+
+a_expr

Review comment:
       What's the meaning of `a_expr`, `b_expr` and `c_expr`?

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -141,166 +509,836 @@ primaryKey
     : PRIMARY? KEY
     ;
 
-// TODO comb expr
-expr
-    : expr logicalOperator expr
-    | notOperator_ expr
-    | LP_ expr RP_
-    | booleanPrimary
-    ;
-
 logicalOperator
     : OR | OR_ | AND | AND_
     ;
 
-notOperator_
-    : NOT | NOT_
+comparisonOperator
+    : EQ_ | GTE_ | GT_ | LTE_ | LT_ | NEQ_
     ;
 
-booleanPrimary
-    : booleanPrimary IS NOT? (TRUE | FALSE | UNKNOWN | NULL)
-    | booleanPrimary SAFE_EQ_ predicate
-    | booleanPrimary comparisonOperator predicate
-    | booleanPrimary comparisonOperator (ALL | ANY) subquery
-    | predicate
+
+cursor_name
+    : name
+	;
+
+a_expr
+    : c_expr
+	| a_expr TYPE_CAST_ typeName
+	| a_expr COLLATE anyName
+	| a_expr AT TIME ZONE a_expr
+	| '+' a_expr
+	| '-' a_expr
+	| a_expr '+' a_expr
+	| a_expr '-' a_expr
+	| a_expr '*' a_expr
+	| a_expr '/' a_expr
+	| a_expr '%' a_expr
+	| a_expr '^' a_expr
+	| a_expr comparisonOperator a_expr
+    | '(' a_expr ')' opt_indirection
+	| a_expr qual_Op a_expr
+	| qual_Op a_expr
+	| a_expr qual_Op
+	| NOT a_expr
+	| a_expr LIKE a_expr
+	| a_expr LIKE a_expr ESCAPE a_expr
+	| a_expr NOT LIKE a_expr
+	| a_expr NOT LIKE a_expr ESCAPE a_expr
+	| a_expr ILIKE a_expr
+	| a_expr ILIKE a_expr ESCAPE a_expr
+	| a_expr NOT ILIKE a_expr
+	| a_expr NOT ILIKE a_expr ESCAPE a_expr
+	| a_expr SIMILAR TO a_expr
+	| a_expr SIMILAR TO a_expr ESCAPE a_expr
+	| a_expr NOT SIMILAR TO a_expr
+	| a_expr NOT SIMILAR TO a_expr ESCAPE a_expr
+	| a_expr IS NULL
+	| a_expr ISNULL
+	| a_expr IS NOT NULL
+	| a_expr NOTNULL
+	| row OVERLAPS row
+	| a_expr IS TRUE
+	| a_expr IS NOT TRUE
+	| a_expr IS FALSE
+	| a_expr IS NOT FALSE
+	| a_expr IS UNKNOWN
+	| a_expr IS NOT UNKNOWN
+	| a_expr IS DISTINCT FROM a_expr
+	| a_expr IS NOT DISTINCT FROM a_expr
+	| a_expr IS OF '(' type_list ')'
+	| a_expr IS NOT OF '(' type_list ')'
+	| a_expr BETWEEN ASYMMETRIC? b_expr AND a_expr
+	| a_expr NOT BETWEEN ASYMMETRIC? b_expr AND a_expr
+	| a_expr BETWEEN SYMMETRIC b_expr AND a_expr
+	| a_expr NOT BETWEEN SYMMETRIC b_expr AND a_expr
+	| a_expr IN in_expr
+	| a_expr NOT IN in_expr
+	| a_expr subquery_Op sub_type select_with_parens
+	| a_expr subquery_Op sub_type '(' a_expr ')'
+	| UNIQUE select_with_parens
+	| a_expr IS DOCUMENT
+	| a_expr IS NOT DOCUMENT
+	| a_expr IS NORMALIZED
+	| a_expr IS unicodeNormalForm NORMALIZED
+	| a_expr IS NOT NORMALIZED
+	| a_expr IS NOT unicodeNormalForm NORMALIZED
+	| a_expr logicalOperator a_expr
+	| DEFAULT
+	;
+
+b_expr
+    : c_expr
+	| b_expr TYPE_CAST_ typeName
+	| '+' b_expr
+	| '-' b_expr
+	| b_expr qual_Op b_expr
+	| qual_Op b_expr
+	| b_expr qual_Op
+	| b_expr IS DISTINCT FROM b_expr
+	| b_expr IS NOT DISTINCT FROM b_expr
+	| b_expr IS OF '(' type_list ')'
+	| b_expr IS NOT OF '(' type_list ')'
+	| b_expr IS DOCUMENT
+	| b_expr IS NOT DOCUMENT
+	;
+
+c_expr
+    : parameterMarker
+    | columnref
+	| aexprConst
+	| PARAM indirection_el?
+	| case_expr
+	| func_expr
+	| select_with_parens
+	| select_with_parens indirection
+	| EXISTS select_with_parens
+	| ARRAY select_with_parens
+	| ARRAY array_expr
+	| explicit_row
+	| implicit_row
+	| GROUPING '(' exprList ')'
+	;
+
+indirection
+    : indirection_el
+	| indirection indirection_el
+	;
+
+opt_indirection
+    : opt_indirection indirection_el |
+	;
+
+indirection_el
+    : '.' attrName
+	| '.' '*'
+	| '[' a_expr ']'
+	| '[' slice_bound? ':' slice_bound? ']'
+	;
+
+slice_bound
+    : a_expr
+	;
+
+in_expr
+    : select_with_parens | '(' exprList ')'
+	;
+
+case_expr
+    : CASE case_arg? when_clause_list case_default? END
+	;
+
+when_clause_list
+    : when_clause
+	| when_clause_list when_clause
+	;
+
+when_clause
+    : WHEN a_expr THEN a_expr
+	;
+
+case_default
+    : ELSE a_expr
+	;
+
+case_arg
+    : a_expr
+	;
+
+
+columnref
+    : colId
+	| colId indirection
+	;
+
+qual_Op
+    : mathOperator
+    | TILDE_TILDE_
+    | NOT_TILDE_TILDE_
+    | OPERATOR '(' any_operator ')'
+	;
+
+subquery_Op
+    : all_Op
+	| OPERATOR '(' any_operator ')'
+	| LIKE
+	| NOT LIKE
+	| ILIKE
+	| NOT ILIKE
+	;
+
+all_Op
+    : mathOperator
+	;
+
+mathOperator
+    : '+'
+	| '-'
+	| '*'
+	| '/'
+	| '%'
+	| '^'
+	| '<'
+	| '>'
+	| '='
+	| LTE_
+	| GTE_
+	| NEQ_
+	;
+
+
+qual_all_Op
+    : all_Op
+	| OPERATOR '(' any_operator ')'
+	;
+
+asc_desc
+    : ASC | DESC
+	;
+
+any_operator
+    : all_Op | colId '.' any_operator
+	;
+
+frame_clause
+    : RANGE frame_extent window_exclusion_clause?
+	| ROWS frame_extent window_exclusion_clause?
+	| GROUPS frame_extent window_exclusion_clause?
+	;
+
+frame_extent
+    : frame_bound
+	| BETWEEN frame_bound AND frame_bound
+	;
+
+frame_bound
+    : UNBOUNDED PRECEDING
+	| UNBOUNDED FOLLOWING
+	| CURRENT ROW
+	| a_expr PRECEDING
+	| a_expr FOLLOWING
+	;
+
+window_exclusion_clause
+    : EXCLUDE CURRENT ROW
+	| EXCLUDE GROUP
+	| EXCLUDE TIES
+	| EXCLUDE NO OTHERS
+	;
+
+row
+    : ROW '(' exprList ')'
+	| ROW '(' ')'
+	| '(' exprList ',' a_expr ')'
+	;
+
+explicit_row
+    : ROW '(' exprList ')'
+	| ROW '(' ')'
+	;
+
+implicit_row
+    : '(' exprList ',' a_expr ')'
+	;
+
+sub_type
+    : ANY | SOME | ALL
+	;
+
+array_expr
+    : '[' exprList ']'
+	| '[' array_expr_list ']'
+	| '[' ']'
+	;
+
+array_expr_list
+    : array_expr | array_expr_list ',' array_expr
+	;
+
+func_arg_list
+    : func_arg_expr
+	| func_arg_list ',' func_arg_expr
+	;
+
+param_name
+    : typeFunctionName
+	;
+
+func_arg_expr
+    : a_expr
+	| param_name CQ_ a_expr
+	| param_name GTE_ a_expr
+	;
+
+type_list
+    : typeName
+	| type_list ',' typeName
+	;
+
+funcApplication
+    : funcName '(' ')'
+    | funcName '(' func_arg_list sort_clause? ')'
+    | funcName '(' VARIADIC func_arg_expr sort_clause? ')'
+    | funcName '(' func_arg_list ',' VARIADIC func_arg_expr sort_clause? ')'
+    | funcName '(' ALL func_arg_list sort_clause? ')'
+    | funcName '(' DISTINCT func_arg_list sort_clause? ')'
+    | funcName '(' '*' ')'
     ;
 
-comparisonOperator
-    : EQ_ | GTE_ | GT_ | LTE_ | LT_ | NEQ_
+funcName
+    : typeFunctionName | colId indirection
     ;
 
-predicate
-    : bitExpr NOT? IN subquery
-    | bitExpr NOT? IN LP_ expr (COMMA_ expr)* RP_
-    | bitExpr NOT? BETWEEN bitExpr AND predicate
-    | bitExpr NOT? LIKE simpleExpr (ESCAPE simpleExpr)?
-    | bitExpr (TILDE_TILDE_ | NOT_TILDE_TILDE_) simpleExpr (ESCAPE simpleExpr)?
-    | bitExpr
-    ;
-
-bitExpr
-    : bitExpr VERTICAL_BAR_ bitExpr
-    | bitExpr AMPERSAND_ bitExpr
-    | bitExpr SIGNED_LEFT_SHIFT_ bitExpr
-    | bitExpr SIGNED_RIGHT_SHIFT_ bitExpr
-    | bitExpr PLUS_ bitExpr
-    | bitExpr MINUS_ bitExpr
-    | bitExpr ASTERISK_ bitExpr
-    | bitExpr SLASH_ bitExpr
-    | bitExpr MOD_ bitExpr
-    | bitExpr CARET_ bitExpr
-    | simpleExpr
-    ;
-
-simpleExpr
-    : functionCall
-    | parameterMarker
-    | literals
-    | columnName
-    | simpleExpr COLLATE (STRING_ | identifier)
-    | simpleExpr OR_ simpleExpr
-    | (PLUS_ | MINUS_ | TILDE_ | NOT_ | BINARY) simpleExpr
-    | ROW? LP_ expr (COMMA_ expr)* RP_
-    | EXISTS? subquery
-    | LBE_ identifier expr RBE_
-    | caseExpression
-    | CURRENT_USER
+aexprConst
+    : NUMBER_
+	| STRING_
+	| funcName STRING_
+	| funcName '(' func_arg_list sort_clause? ')' STRING_
+	| TRUE
+	| FALSE
+	| NULL
+	;
+
+qualifiedName
+    : colId | colId indirection
     ;
 
-functionCall
-    : aggregationFunction | specialFunction | regularFunction 
+colId
+    : identifier
     ;
 
-aggregationFunction
-    : aggregationFunctionName LP_ distinct? (expr (COMMA_ expr)* | ASTERISK_)? RP_ filterClause_?
+typeFunctionName
+    : identifier | unreservedWord |type_func_name_keyword
     ;
 
-aggregationFunctionName
-    : MAX | MIN | SUM | COUNT | AVG
+functionTable
+    : functionExprWindowless optOrdinality
+    | ROWS FROM '(' rowsFromList ')' optOrdinality
     ;
 
-distinct
-    : DISTINCT
+xmlTable
+    : XMLTABLE '(' c_expr xmlExistsArgument COLUMNS xmlTableColumnList ')'
+	| XMLTABLE '(' XMLNAMESPACES '(' xmlNamespaceList ')' ',' c_expr xmlExistsArgument COLUMNS xmlTableColumnList ')'
+	;
+
+xmlTableColumnList
+    : xmlTableColumnEl
+	| xmlTableColumnList ',' xmlTableColumnEl
+	;
+
+xmlTableColumnEl
+    : colId typeName
+	| colId typeName xmlTableColumnOptionList
+	| colId FOR ORDINALITY
+	;
+
+xmlTableColumnOptionList
+    : xmlTableColumnOptionEl
+	| xmlTableColumnOptionList xmlTableColumnOptionEl
+	;
+
+xmlTableColumnOptionEl
+    : identifier b_expr
+	| DEFAULT b_expr
+	| NOT NULL
+	| NULL
+	;
+
+xmlNamespaceList
+    : xmlNamespaceEl
+	| xmlNamespaceList ',' xmlNamespaceEl
+	;
+
+xmlNamespaceEl
+    : b_expr AS identifier
+	| DEFAULT b_expr
+	;
+
+func_expr
+    : funcApplication within_group_clause? filter_clause? over_clause?
+	| functionExprCommonSubexpr
+	;
+
+within_group_clause
+    : WITHIN GROUP '(' sort_clause ')'
+	;
+
+filter_clause
+    : FILTER '(' WHERE a_expr ')'

Review comment:
       Do you think it is better to replace these literal symbols with `Symbol.g4` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #6045: Refactor pg grammar file, fix #5802

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #6045:
URL: https://github.com/apache/shardingsphere/pull/6045#issuecomment-644019837


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=h1) Report
   > Merging [#6045](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ff29e3963511f53fe786c6e11d504529d202ea02&el=desc) will **decrease** coverage by `0.11%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6045/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6045      +/-   ##
   ============================================
   - Coverage     53.13%   53.01%   -0.12%     
     Complexity      438      438              
   ============================================
     Files          1188     1189       +1     
     Lines         20932    20999      +67     
     Branches       3769     3757      -12     
   ============================================
   + Hits          11122    11133      +11     
   - Misses         9112     9166      +54     
   - Partials        698      700       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...l/parser/postgresql/visitor/PostgreSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9Qb3N0Z3JlU1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...e/cluster/heartbeat/task/HeartbeatTaskManager.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC90YXNrL0hlYXJ0YmVhdFRhc2tNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-30.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ransaction/ShardingTransactionTypeInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXRyYW5zYWN0aW9uLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3ByaW5nL3RyYW5zYWN0aW9uL1NoYXJkaW5nVHJhbnNhY3Rpb25UeXBlSW50ZXJjZXB0b3IuamF2YQ==) | `88.23% <0.00%> (-11.77%)` | `1.00% <0.00%> (ø%)` | |
   | [...re/cluster/heartbeat/ClusterHeartbeatInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9DbHVzdGVySGVhcnRiZWF0SW5zdGFuY2UuamF2YQ==) | `33.33% <0.00%> (-8.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/cluster/heartbeat/detect/HeartbeatHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9kZXRlY3QvSGVhcnRiZWF0SGFuZGxlci5qYXZh) | `71.87% <0.00%> (-4.80%)` | `0.00% <0.00%> (ø%)` | |
   | [...ation/core/facade/ShardingOrchestrationFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvZmFjYWRlL1NoYXJkaW5nT3JjaGVzdHJhdGlvbkZhY2FkZS5qYXZh) | `91.37% <0.00%> (-3.27%)` | `0.00% <0.00%> (ø%)` | |
   | [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtY29uZmlnY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvY29uZmlnY2VudGVyL0NvbmZpZ0NlbnRlci5qYXZh) | `81.17% <0.00%> (-1.33%)` | `0.00% <0.00%> (ø%)` | |
   | [...driver/jdbc/adapter/AbstractConnectionAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2FkYXB0ZXIvQWJzdHJhY3RDb25uZWN0aW9uQWRhcHRlci5qYXZh) | `71.57% <0.00%> (-0.30%)` | `6.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [17 more](https://codecov.io/gh/apache/shardingsphere/pull/6045/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=footer). Last update [ff29e39...acca19b](https://codecov.io/gh/apache/shardingsphere/pull/6045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org