You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/07/07 10:17:16 UTC

[GitHub] fran6co commented on a change in pull request #11584: CMake will not detect a variable as empty string

fran6co commented on a change in pull request #11584: CMake will not detect a variable as empty string
URL: https://github.com/apache/incubator-mxnet/pull/11584#discussion_r200808554
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -210,7 +210,7 @@ if(USE_CUDA)
   find_package(CUDA REQUIRED)
   add_definitions(-DMSHADOW_USE_CUDA=1)
   if(FIRST_CUDA AND (NOT USE_OLDCMAKECUDA))
-    if(CUDA_TOOLSET STREQUAL "")
+    if(NOT CUDA_TOOLSET)
 
 Review comment:
   NOT checks for empty string and when the variable is not set, so there is no need for the OR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services