[GitHub] [cassandra] smiklosovic commented on a change in pull request #1485: CASSANDRA-17197: Diagnostic events for guardrails

[GitBox <gi...@apache.org>]

smiklosovic commented on a change in pull request #1485:
URL: https://github.com/apache/cassandra/pull/1485#discussion_r831057347



##########
File path: src/java/org/apache/cassandra/db/guardrails/Guardrail.java
##########
@@ -89,6 +101,7 @@ protected void fail(String message, @Nullable ClientState state)
         ClientWarn.instance.warn(message);
         // Similarly, tracing will also ignore the message if we're not running tracing on the current thread.
         Tracing.trace(message);
+        GuardrailsDiagnostics.failed(name, decorateMessage(redactedMessage));
 
         if (state != null)

Review comment:
       @adelapena maybe unrelated to this ticket but why are we throwing right here as the last statement in the method? it is little bit counter-intuitive to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org