You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/12/08 06:36:37 UTC
[GitHub] [hudi] xuzifu666 opened a new pull request #4245: Unuse method remove
xuzifu666 opened a new pull request #4245:
URL: https://github.com/apache/hudi/pull/4245
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988641881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
}, {
"hash" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4089",
"triggerID" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b1b0fcc6c35bd83846bf0914babc2199165f5c5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4089)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988572701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0893724351e36c2c0e50d1971ab4a37134c30435 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086)
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988542594
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0893724351e36c2c0e50d1971ab4a37134c30435 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086)
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988541496
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0893724351e36c2c0e50d1971ab4a37134c30435 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-998509370
@yanghua please have a review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988610403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
}, {
"hash" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4089",
"triggerID" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088)
* 2b1b0fcc6c35bd83846bf0914babc2199165f5c5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4089)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-998562331
@xuzifu666 i don't think we need to remove these. In general we may just provide no-arg constructor for deserialization or reflection. So i suggest close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 removed a comment on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
xuzifu666 removed a comment on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-998509370
@yanghua please have a review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on a change in pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on a change in pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#discussion_r772902282
##########
File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/hive/HoodieCombineHiveInputFormat.java
##########
@@ -579,10 +579,6 @@ public RecordReader getRecordReader(InputSplit split, JobConf job, Reporter repo
protected CombineFileSplit inputSplitShim;
private Map<Path, PartitionDesc> pathToPartitionInfo;
- public CombineHiveInputSplit() throws IOException {
Review comment:
no, this would not be called by serialization code for e.g
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988542916
@xushiyan Hi teacher Xu, the minor problem alse can be fix, because the construnction method is never be used. have a review if you are free please, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#discussion_r766210065
##########
File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/hive/HoodieCombineHiveInputFormat.java
##########
@@ -579,10 +579,6 @@ public RecordReader getRecordReader(InputSplit split, JobConf job, Reporter repo
protected CombineFileSplit inputSplitShim;
private Map<Path, PartitionDesc> pathToPartitionInfo;
- public CombineHiveInputSplit() throws IOException {
Review comment:
this could have been called by serialization code for e.g?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988542594
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0893724351e36c2c0e50d1971ab4a37134c30435 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086)
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988578456
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
}, {
"hash" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0893724351e36c2c0e50d1971ab4a37134c30435 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086)
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088)
* 2b1b0fcc6c35bd83846bf0914babc2199165f5c5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988572701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0893724351e36c2c0e50d1971ab4a37134c30435 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086)
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988610403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
}, {
"hash" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4089",
"triggerID" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088)
* 2b1b0fcc6c35bd83846bf0914babc2199165f5c5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4089)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988541496
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0893724351e36c2c0e50d1971ab4a37134c30435 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988543706
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0893724351e36c2c0e50d1971ab4a37134c30435 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086)
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988581448
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
}, {
"hash" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088)
* 2b1b0fcc6c35bd83846bf0914babc2199165f5c5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-998563159
> @xuzifu666 i don't think we need to remove these. In general we may just provide no-arg constructor for deserialization or reflection. So i suggest close this
ok, i close it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 closed pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
xuzifu666 closed pull request #4245:
URL: https://github.com/apache/hudi/pull/4245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988543706
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0893724351e36c2c0e50d1971ab4a37134c30435 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086)
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988578456
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
}, {
"hash" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0893724351e36c2c0e50d1971ab4a37134c30435 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086)
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088)
* 2b1b0fcc6c35bd83846bf0914babc2199165f5c5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4245: [MINOR] remove unuse construction method
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4245:
URL: https://github.com/apache/hudi/pull/4245#issuecomment-988581448
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4086",
"triggerID" : "0893724351e36c2c0e50d1971ab4a37134c30435",
"triggerType" : "PUSH"
}, {
"hash" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088",
"triggerID" : "6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0",
"triggerType" : "PUSH"
}, {
"hash" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2b1b0fcc6c35bd83846bf0914babc2199165f5c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f4e9f5fd7387cc3ec4dfa8d7f7a83a3abcbd0c0 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4088)
* 2b1b0fcc6c35bd83846bf0914babc2199165f5c5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org