You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/08 08:20:31 UTC

[GitHub] [spark] zero323 commented on pull request #29947: [SPARK-32793][SQL] Add raise_error function, adds error message parameter to assert_true

zero323 commented on pull request #29947:
URL: https://github.com/apache/spark/pull/29947#issuecomment-705411778


   It seem like R functions haven't been included in `NAMESPACE`. Unless it is intentional they should be added around here
   
   https://github.com/apache/spark/blob/5effa8ea261ba59214afedc2853d1b248b330ca6/R/pkg/NAMESPACE#L231
   
   and  here
   
   https://github.com/apache/spark/blob/5effa8ea261ba59214afedc2853d1b248b330ca6/R/pkg/NAMESPACE#L363
   
   for `assert_true` and `raise_error` respectively.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org