You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kunalsinghdadhwal (via GitHub)" <gi...@apache.org> on 2026/03/19 07:00:58 UTC

[PR] Kunal/add unshred #9526 [arrow-rs]

kunalsinghdadhwal opened a new pull request, #9576:
URL: https://github.com/apache/arrow-rs/pull/9576

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
   -->
   
   - Closes #9526 
   
   # Rationale for this change
   
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   `shred_variant` already supports Binary and LargeBinary types (#9525, #9554), but unshred_variant does not handle these types. This means shredded Binary/LargeBinary columns cannot be converted back to unshredded VariantArrays.
   
   # What changes are included in this PR?
   
     Adds unshred_variant support for DataType::Binary and DataType::LargeBinary in parquet-variant-compute/src/unshred_variant.rs:
     - New enum variants PrimitiveBinary and PrimitiveLargeBinary
     - Match arms in append_row and try_new_opt
     - AppendToVariantBuilder impls for BinaryArray and LargeBinaryArray
   
   
   
   # Are these changes tested?
   
   Yes
   
   # Are there any user-facing changes?
   
   No breaking changes
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Kunal/add unshred #9526 [arrow-rs]

Posted by "kunalsinghdadhwal (via GitHub)" <gi...@apache.org>.
kunalsinghdadhwal commented on PR #9576:
URL: https://github.com/apache/arrow-rs/pull/9576#issuecomment-4088226645

   Kindly review @sdf-jkl 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Kunal/add unshred #9526 [arrow-rs]

Posted by "sdf-jkl (via GitHub)" <gi...@apache.org>.
sdf-jkl commented on PR #9576:
URL: https://github.com/apache/arrow-rs/pull/9576#issuecomment-4092079907

   @scovich please take a look when available. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Variant] Add unshred_variant support for Binary and LargeBinary types [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9576:
URL: https://github.com/apache/arrow-rs/pull/9576#issuecomment-4098133050

   Thanks @scovich and @sdf-jkl  -- merging to get this into the 58.1.0 release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Kunal/add unshred #9526 [arrow-rs]

Posted by "kunalsinghdadhwal (via GitHub)" <gi...@apache.org>.
kunalsinghdadhwal commented on PR #9576:
URL: https://github.com/apache/arrow-rs/pull/9576#issuecomment-4092076624

   > Run `cargo fmt` to fix lint and we'll ask someone with approval rights to push this forward.
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Variant] Add unshred_variant support for Binary and LargeBinary types [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9576:
URL: https://github.com/apache/arrow-rs/pull/9576


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org