You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "XieJiann (via GitHub)" <gi...@apache.org> on 2024/07/15 02:18:48 UTC

[PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

XieJiann opened a new pull request, #37773:
URL: https://github.com/apache/doris/pull/37773

   ## Proposed changes
   
   Update character to string conversion logic to leverage Java 8's String.valueOf() method, replacing the older Character.toString(). This change improves code readability and aligns with modern Java practices while maintaining existing functionality.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2232244818

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173908 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 8c112d62719c8052307fc87d5036ff1e9430a89e, data reload: false
   
   query1	925	374	370	370
   query2	6709	1845	1884	1845
   query3	6655	214	221	214
   query4	24691	17630	17355	17355
   query5	3609	494	480	480
   query6	253	173	162	162
   query7	4576	285	277	277
   query8	229	204	193	193
   query9	8501	2386	2367	2367
   query10	427	300	269	269
   query11	10559	10287	10230	10230
   query12	119	86	82	82
   query13	1647	380	360	360
   query14	10459	7835	6884	6884
   query15	218	161	174	161
   query16	7361	322	330	322
   query17	1347	592	541	541
   query18	1929	285	284	284
   query19	205	156	164	156
   query20	91	85	88	85
   query21	216	125	125	125
   query22	4418	4183	4210	4183
   query23	34002	33857	33756	33756
   query24	9788	2957	2931	2931
   query25	677	382	396	382
   query26	718	151	148	148
   query27	2214	283	278	278
   query28	5817	2057	2072	2057
   query29	889	625	658	625
   query30	248	153	157	153
   query31	950	779	773	773
   query32	91	53	53	53
   query33	637	293	307	293
   query34	892	511	499	499
   query35	692	591	567	567
   query36	1172	1000	976	976
   query37	145	79	82	79
   query38	2933	2822	2841	2822
   query39	875	807	810	807
   query40	203	116	120	116
   query41	47	44	43	43
   query42	119	107	99	99
   query43	517	467	476	467
   query44	1037	721	741	721
   query45	197	168	163	163
   query46	1094	720	698	698
   query47	1878	1783	1755	1755
   query48	359	286	286	286
   query49	826	407	412	407
   query50	772	386	386	386
   query51	6875	6920	6900	6900
   query52	103	90	108	90
   query53	355	284	282	282
   query54	815	443	437	437
   query55	75	73	73	73
   query56	300	270	271	270
   query57	1101	1061	1058	1058
   query58	252	242	242	242
   query59	3015	2743	2603	2603
   query60	295	263	275	263
   query61	97	93	96	93
   query62	797	625	651	625
   query63	316	287	289	287
   query64	9146	2222	7473	2222
   query65	3150	3107	3131	3107
   query66	781	329	327	327
   query67	15637	15390	14992	14992
   query68	4724	549	537	537
   query69	664	502	382	382
   query70	1212	1144	1175	1144
   query71	436	277	274	274
   query72	9077	5179	5797	5179
   query73	752	329	334	329
   query74	6065	5736	5746	5736
   query75	4126	2691	2696	2691
   query76	3371	937	963	937
   query77	661	297	306	297
   query78	9723	9059	9048	9048
   query79	2674	526	516	516
   query80	2378	470	468	468
   query81	599	223	221	221
   query82	794	140	135	135
   query83	318	171	167	167
   query84	274	90	84	84
   query85	1770	313	364	313
   query86	462	309	300	300
   query87	3312	3134	3125	3125
   query88	3576	2380	2377	2377
   query89	481	392	373	373
   query90	1802	195	193	193
   query91	131	101	100	100
   query92	58	48	52	48
   query93	3117	514	502	502
   query94	1227	209	209	209
   query95	405	318	312	312
   query96	597	269	284	269
   query97	3169	3053	3001	3001
   query98	232	198	196	196
   query99	1534	1289	1310	1289
   Total cold run time: 277764 ms
   Total hot run time: 173908 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2229893739

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39764 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 20246ba9728261cf743a878ac2d75fb71cc6e8a0, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17609	4404	4275	4275
   q2	2017	187	189	187
   q3	10458	1281	1097	1097
   q4	10190	818	828	818
   q5	7547	2722	2657	2657
   q6	218	137	137	137
   q7	943	594	600	594
   q8	9216	2059	2072	2059
   q9	8975	6539	6526	6526
   q10	8865	3768	3829	3768
   q11	452	242	233	233
   q12	438	223	226	223
   q13	18010	2993	2975	2975
   q14	269	235	245	235
   q15	524	482	478	478
   q16	504	385	381	381
   q17	958	735	666	666
   q18	7987	7421	7365	7365
   q19	6719	1504	1359	1359
   q20	672	325	318	318
   q21	4846	3128	3275	3128
   q22	336	289	285	285
   Total cold run time: 117753 ms
   Total hot run time: 39764 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4343	4255	4233	4233
   q2	384	289	268	268
   q3	2981	2868	2876	2868
   q4	2026	1647	1776	1647
   q5	5637	5523	5476	5476
   q6	228	135	134	134
   q7	2202	1860	1876	1860
   q8	3285	3416	3436	3416
   q9	8733	8784	8957	8784
   q10	4130	3887	3748	3748
   q11	587	518	518	518
   q12	815	637	642	637
   q13	17109	3199	3179	3179
   q14	322	294	296	294
   q15	532	483	497	483
   q16	499	437	446	437
   q17	1825	1553	1505	1505
   q18	8160	7924	7758	7758
   q19	1742	1627	1641	1627
   q20	2116	1886	1874	1874
   q21	9539	4832	4733	4733
   q22	606	530	532	530
   Total cold run time: 77801 ms
   Total hot run time: 56009 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2232345928

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173499 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 8efa090c3ae23c6a2a2fe49ead6a30e1300d36a1, data reload: false
   
   query1	909	381	370	370
   query2	6465	1924	1889	1889
   query3	6651	209	221	209
   query4	27402	17565	17262	17262
   query5	4197	523	497	497
   query6	274	161	187	161
   query7	4581	301	298	298
   query8	235	203	202	202
   query9	8611	2420	2396	2396
   query10	456	291	293	291
   query11	10639	10132	10229	10132
   query12	140	87	88	87
   query13	1659	370	381	370
   query14	10271	8079	7691	7691
   query15	218	166	166	166
   query16	7981	334	328	328
   query17	1784	567	553	553
   query18	2015	288	282	282
   query19	208	159	159	159
   query20	98	91	86	86
   query21	211	127	131	127
   query22	4351	4096	4091	4091
   query23	33733	33192	33125	33125
   query24	12130	3049	2881	2881
   query25	687	394	398	394
   query26	1737	155	152	152
   query27	2823	279	281	279
   query28	7571	2005	2003	2003
   query29	1077	656	644	644
   query30	290	153	150	150
   query31	951	756	776	756
   query32	107	60	57	57
   query33	797	317	325	317
   query34	878	501	506	501
   query35	684	590	597	590
   query36	1084	930	981	930
   query37	289	87	86	86
   query38	2918	2752	2791	2752
   query39	873	819	804	804
   query40	282	129	129	129
   query41	51	49	49	49
   query42	128	100	100	100
   query43	521	486	484	484
   query44	1229	725	725	725
   query45	196	164	162	162
   query46	1105	728	723	723
   query47	1907	1801	1809	1801
   query48	456	297	299	297
   query49	1216	431	436	431
   query50	786	404	393	393
   query51	6988	6824	6826	6824
   query52	105	92	97	92
   query53	365	294	287	287
   query54	1014	450	444	444
   query55	81	76	74	74
   query56	316	284	273	273
   query57	1170	1071	1057	1057
   query58	268	247	249	247
   query59	2864	2709	2620	2620
   query60	313	272	287	272
   query61	104	93	121	93
   query62	815	661	664	661
   query63	316	289	293	289
   query64	10417	2245	1709	1709
   query65	3155	3110	3124	3110
   query66	1378	341	343	341
   query67	15843	15075	14908	14908
   query68	5888	548	549	548
   query69	693	469	371	371
   query70	1228	1102	1079	1079
   query71	491	288	279	279
   query72	8678	5418	5792	5418
   query73	777	331	330	330
   query74	6395	5684	5733	5684
   query75	5112	2689	2713	2689
   query76	4086	916	947	916
   query77	732	316	307	307
   query78	9714	8915	8969	8915
   query79	3697	527	533	527
   query80	2852	491	490	490
   query81	592	217	229	217
   query82	1392	136	138	136
   query83	309	171	172	171
   query84	275	93	89	89
   query85	1595	316	355	316
   query86	463	335	329	329
   query87	3344	3150	3130	3130
   query88	4600	2397	2380	2380
   query89	503	390	376	376
   query90	2027	194	199	194
   query91	131	99	102	99
   query92	65	52	53	52
   query93	5241	506	511	506
   query94	1405	221	214	214
   query95	412	320	321	320
   query96	611	275	268	268
   query97	3211	3020	3037	3020
   query98	220	205	199	199
   query99	1562	1267	1295	1267
   Total cold run time: 299675 ms
   Total hot run time: 173499 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2232351309

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.44 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 8efa090c3ae23c6a2a2fe49ead6a30e1300d36a1, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.08	0.04	0.04
   query3	0.23	0.05	0.05
   query4	1.67	0.07	0.07
   query5	0.50	0.49	0.49
   query6	1.13	0.74	0.74
   query7	0.02	0.01	0.01
   query8	0.05	0.04	0.04
   query9	0.54	0.50	0.49
   query10	0.55	0.55	0.55
   query11	0.16	0.12	0.12
   query12	0.16	0.12	0.14
   query13	0.59	0.59	0.58
   query14	0.76	0.78	0.78
   query15	0.85	0.82	0.82
   query16	0.38	0.37	0.36
   query17	1.01	1.03	1.05
   query18	0.23	0.22	0.23
   query19	1.78	1.75	1.78
   query20	0.01	0.01	0.01
   query21	15.39	0.76	0.66
   query22	4.98	6.56	1.52
   query23	18.25	1.34	1.30
   query24	2.09	0.23	0.22
   query25	0.16	0.09	0.08
   query26	0.30	0.21	0.21
   query27	0.46	0.24	0.23
   query28	13.31	1.02	0.99
   query29	12.59	3.29	3.37
   query30	0.25	0.06	0.05
   query31	2.87	0.38	0.41
   query32	3.27	0.48	0.47
   query33	2.94	2.87	2.93
   query34	17.21	4.45	4.42
   query35	4.38	4.44	4.40
   query36	0.66	0.46	0.46
   query37	0.19	0.16	0.15
   query38	0.17	0.15	0.16
   query39	0.05	0.04	0.04
   query40	0.16	0.12	0.13
   query41	0.10	0.05	0.05
   query42	0.05	0.04	0.04
   query43	0.05	0.04	0.04
   Total cold run time: 110.62 s
   Total hot run time: 30.44 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2230174014

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.54 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 20246ba9728261cf743a878ac2d75fb71cc6e8a0, data reload: false
   
   query1	0.04	0.04	0.03
   query2	0.08	0.04	0.04
   query3	0.22	0.06	0.06
   query4	1.66	0.09	0.10
   query5	0.50	0.50	0.48
   query6	1.14	0.74	0.72
   query7	0.02	0.01	0.01
   query8	0.05	0.04	0.04
   query9	0.54	0.48	0.50
   query10	0.55	0.54	0.55
   query11	0.15	0.11	0.11
   query12	0.15	0.13	0.12
   query13	0.58	0.59	0.58
   query14	0.78	0.76	0.81
   query15	0.86	0.82	0.81
   query16	0.37	0.38	0.37
   query17	1.05	1.00	1.06
   query18	0.22	0.21	0.21
   query19	1.89	1.76	1.85
   query20	0.02	0.01	0.01
   query21	15.45	0.75	0.67
   query22	4.38	6.17	2.68
   query23	18.32	1.33	1.35
   query24	2.19	0.22	0.23
   query25	0.16	0.09	0.08
   query26	0.32	0.21	0.20
   query27	0.45	0.23	0.22
   query28	13.22	1.02	1.00
   query29	12.60	3.34	3.26
   query30	0.25	0.05	0.06
   query31	2.87	0.39	0.40
   query32	3.26	0.47	0.47
   query33	2.91	2.88	2.93
   query34	16.93	4.41	4.41
   query35	4.46	4.41	4.42
   query36	0.65	0.47	0.47
   query37	0.18	0.16	0.16
   query38	0.15	0.14	0.14
   query39	0.05	0.04	0.04
   query40	0.15	0.12	0.12
   query41	0.08	0.04	0.04
   query42	0.05	0.04	0.05
   query43	0.04	0.04	0.04
   Total cold run time: 109.99 s
   Total hot run time: 31.54 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2235247853

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.66 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 137dcc891bcba71597e7b1383601649c81437065, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.08	0.04	0.04
   query3	0.23	0.05	0.05
   query4	1.68	0.08	0.10
   query5	0.51	0.51	0.48
   query6	1.14	0.74	0.73
   query7	0.02	0.01	0.01
   query8	0.05	0.04	0.05
   query9	0.55	0.48	0.50
   query10	0.54	0.54	0.55
   query11	0.15	0.11	0.11
   query12	0.16	0.12	0.13
   query13	0.59	0.58	0.58
   query14	0.75	0.78	0.77
   query15	0.85	0.82	0.82
   query16	0.38	0.37	0.36
   query17	0.96	0.97	0.96
   query18	0.22	0.22	0.22
   query19	1.81	1.68	1.69
   query20	0.01	0.01	0.01
   query21	15.39	0.76	0.67
   query22	4.21	7.61	1.97
   query23	18.57	1.46	1.28
   query24	2.15	0.22	0.22
   query25	0.14	0.08	0.09
   query26	0.30	0.21	0.21
   query27	0.46	0.24	0.24
   query28	13.27	1.02	1.00
   query29	12.66	3.32	3.28
   query30	0.25	0.06	0.07
   query31	2.87	0.39	0.38
   query32	3.28	0.49	0.47
   query33	2.90	2.85	2.92
   query34	17.16	4.37	4.37
   query35	4.41	4.45	4.42
   query36	0.65	0.47	0.47
   query37	0.18	0.17	0.15
   query38	0.15	0.15	0.15
   query39	0.04	0.03	0.04
   query40	0.15	0.12	0.13
   query41	0.10	0.05	0.05
   query42	0.05	0.04	0.05
   query43	0.05	0.04	0.04
   Total cold run time: 110.11 s
   Total hot run time: 30.66 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2230165108

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173929 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 20246ba9728261cf743a878ac2d75fb71cc6e8a0, data reload: false
   
   query1	933	368	358	358
   query2	6450	1842	1808	1808
   query3	6633	205	215	205
   query4	27832	17512	17505	17505
   query5	3660	505	476	476
   query6	257	176	172	172
   query7	4577	283	285	283
   query8	235	194	192	192
   query9	8659	2402	2393	2393
   query10	431	299	274	274
   query11	10728	10162	10083	10083
   query12	117	88	82	82
   query13	1645	378	375	375
   query14	10196	8334	7537	7537
   query15	239	167	170	167
   query16	7823	329	309	309
   query17	1800	566	544	544
   query18	1976	280	283	280
   query19	198	162	159	159
   query20	99	82	82	82
   query21	212	137	127	127
   query22	4370	4257	4202	4202
   query23	33858	33851	33684	33684
   query24	11090	2921	2909	2909
   query25	626	422	407	407
   query26	917	152	157	152
   query27	2206	279	275	275
   query28	6153	2077	2088	2077
   query29	913	640	654	640
   query30	253	157	161	157
   query31	994	775	793	775
   query32	97	54	60	54
   query33	849	295	285	285
   query34	1056	492	491	491
   query35	687	602	616	602
   query36	1115	981	999	981
   query37	147	81	85	81
   query38	3043	2842	2809	2809
   query39	923	832	828	828
   query40	212	123	123	123
   query41	47	45	46	45
   query42	122	103	105	103
   query43	503	461	474	461
   query44	1187	721	725	721
   query45	189	156	164	156
   query46	1096	723	737	723
   query47	1880	1800	1808	1800
   query48	352	290	294	290
   query49	829	407	410	407
   query50	772	391	384	384
   query51	6858	6837	6706	6706
   query52	99	95	89	89
   query53	356	279	295	279
   query54	900	455	438	438
   query55	73	71	75	71
   query56	284	282	262	262
   query57	1141	1054	1067	1054
   query58	235	246	262	246
   query59	2776	2680	2589	2589
   query60	307	275	286	275
   query61	96	91	95	91
   query62	787	641	657	641
   query63	314	278	295	278
   query64	9272	2193	1652	1652
   query65	3178	3129	3113	3113
   query66	694	322	331	322
   query67	15833	15158	14956	14956
   query68	4545	585	556	556
   query69	616	380	339	339
   query70	1109	1168	1037	1037
   query71	424	278	278	278
   query72	8606	5540	6414	5540
   query73	742	332	329	329
   query74	6146	5666	5704	5666
   query75	3760	2683	2671	2671
   query76	3318	992	892	892
   query77	691	299	303	299
   query78	9620	9732	9003	9003
   query79	5857	518	524	518
   query80	3031	481	473	473
   query81	596	221	220	220
   query82	1436	139	140	139
   query83	308	220	166	166
   query84	274	83	84	83
   query85	2019	314	295	295
   query86	426	283	303	283
   query87	3309	3128	3192	3128
   query88	4679	2358	2388	2358
   query89	486	387	368	368
   query90	1987	195	189	189
   query91	133	101	101	101
   query92	61	49	49	49
   query93	5431	519	506	506
   query94	1295	252	216	216
   query95	391	312	309	309
   query96	601	276	276	276
   query97	3172	3104	3088	3088
   query98	218	200	193	193
   query99	1526	1268	1266	1266
   Total cold run time: 291202 ms
   Total hot run time: 173929 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227954037

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173077 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c48d95ecf26ce11120717855482ec88eaa159c05, data reload: false
   
   query1	926	377	369	369
   query2	6457	1854	1829	1829
   query3	6651	204	221	204
   query4	28550	17512	17206	17206
   query5	4289	477	490	477
   query6	258	176	169	169
   query7	4598	299	296	296
   query8	255	198	195	195
   query9	8517	2386	2377	2377
   query10	430	272	272	272
   query11	10809	9868	10016	9868
   query12	130	84	83	83
   query13	1631	368	359	359
   query14	10123	7736	7921	7736
   query15	211	169	185	169
   query16	7803	316	303	303
   query17	1545	535	515	515
   query18	1956	278	268	268
   query19	186	144	151	144
   query20	91	79	87	79
   query21	206	134	126	126
   query22	4291	4166	4109	4109
   query23	33909	33252	33108	33108
   query24	12184	2934	2911	2911
   query25	663	365	391	365
   query26	1804	154	149	149
   query27	2988	273	271	271
   query28	7726	1966	1963	1963
   query29	1178	629	615	615
   query30	286	151	147	147
   query31	956	721	747	721
   query32	95	55	55	55
   query33	773	295	299	295
   query34	985	477	488	477
   query35	711	595	571	571
   query36	1080	957	935	935
   query37	286	83	79	79
   query38	2892	2770	2815	2770
   query39	868	810	813	810
   query40	279	126	120	120
   query41	46	46	45	45
   query42	121	101	103	101
   query43	499	468	457	457
   query44	1190	738	741	738
   query45	191	158	165	158
   query46	1088	726	705	705
   query47	1891	1774	1759	1759
   query48	366	297	304	297
   query49	1189	416	415	415
   query50	771	396	387	387
   query51	7010	6864	6822	6822
   query52	115	89	97	89
   query53	370	304	294	294
   query54	895	448	452	448
   query55	77	77	74	74
   query56	345	292	294	292
   query57	1156	1069	1050	1050
   query58	286	241	255	241
   query59	2829	2691	2667	2667
   query60	316	294	295	294
   query61	147	95	96	95
   query62	823	661	660	660
   query63	327	292	293	292
   query64	10453	2223	1713	1713
   query65	3193	3134	3122	3122
   query66	1422	360	332	332
   query67	15384	15174	14861	14861
   query68	4512	523	534	523
   query69	478	368	333	333
   query70	1165	1145	1132	1132
   query71	381	285	285	285
   query72	7049	6027	5574	5574
   query73	739	324	326	324
   query74	6162	5752	5693	5693
   query75	3425	2735	2692	2692
   query76	2487	971	976	971
   query77	500	304	309	304
   query78	9720	8973	8952	8952
   query79	2315	508	523	508
   query80	2220	483	474	474
   query81	604	227	227	227
   query82	804	134	137	134
   query83	307	169	170	169
   query84	267	94	91	91
   query85	2195	370	304	304
   query86	497	311	334	311
   query87	3295	3134	3149	3134
   query88	4178	2468	2461	2461
   query89	490	399	400	399
   query90	1836	198	194	194
   query91	135	101	106	101
   query92	64	52	51	51
   query93	2527	492	498	492
   query94	1231	209	219	209
   query95	414	321	323	321
   query96	606	273	270	270
   query97	3196	3025	3060	3025
   query98	215	211	202	202
   query99	1480	1296	1294	1294
   Total cold run time: 287570 ms
   Total hot run time: 173077 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2229903071

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173882 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 20246ba9728261cf743a878ac2d75fb71cc6e8a0, data reload: false
   
   query1	923	373	367	367
   query2	6455	2011	1813	1813
   query3	6644	206	216	206
   query4	27775	17605	17296	17296
   query5	3596	490	489	489
   query6	259	177	174	174
   query7	4586	293	289	289
   query8	261	201	198	198
   query9	8713	2415	2431	2415
   query10	437	294	284	284
   query11	11183	10172	10360	10172
   query12	121	87	93	87
   query13	1653	381	372	372
   query14	10242	7831	6994	6994
   query15	220	162	170	162
   query16	7758	322	305	305
   query17	1815	550	526	526
   query18	1859	274	270	270
   query19	198	149	141	141
   query20	91	81	83	81
   query21	201	125	121	121
   query22	4393	4216	4164	4164
   query23	34120	33652	33742	33652
   query24	11105	2894	2933	2894
   query25	569	392	414	392
   query26	696	155	149	149
   query27	2252	280	281	280
   query28	6058	2085	2106	2085
   query29	904	627	631	627
   query30	250	151	153	151
   query31	996	792	772	772
   query32	97	52	57	52
   query33	755	309	296	296
   query34	917	497	508	497
   query35	699	575	625	575
   query36	1141	978	980	978
   query37	152	86	96	86
   query38	2969	2910	2878	2878
   query39	927	878	848	848
   query40	210	123	123	123
   query41	46	45	46	45
   query42	111	100	104	100
   query43	535	480	454	454
   query44	1213	731	737	731
   query45	196	162	160	160
   query46	1083	745	725	725
   query47	1869	1808	1791	1791
   query48	364	287	290	287
   query49	815	405	416	405
   query50	773	386	388	386
   query51	6903	6760	6844	6760
   query52	105	95	97	95
   query53	359	292	296	292
   query54	911	450	450	450
   query55	75	77	76	76
   query56	293	271	276	271
   query57	1143	1076	1080	1076
   query58	244	252	263	252
   query59	2827	2755	2657	2657
   query60	313	282	279	279
   query61	135	95	90	90
   query62	776	644	648	644
   query63	322	285	291	285
   query64	9119	2187	1674	1674
   query65	3205	3134	3110	3110
   query66	729	331	328	328
   query67	15419	15085	15118	15085
   query68	4504	559	553	553
   query69	533	399	353	353
   query70	1187	1174	1169	1169
   query71	406	290	287	287
   query72	7046	5690	5752	5690
   query73	745	326	322	322
   query74	6137	5829	5745	5745
   query75	3356	2674	2721	2674
   query76	2742	918	888	888
   query77	452	315	313	313
   query78	9740	8939	9849	8939
   query79	3831	526	524	524
   query80	2140	484	476	476
   query81	589	223	220	220
   query82	941	142	134	134
   query83	333	176	175	175
   query84	284	89	89	89
   query85	1786	385	307	307
   query86	312	306	332	306
   query87	3403	3148	3116	3116
   query88	4166	2377	2352	2352
   query89	501	391	385	385
   query90	1806	194	193	193
   query91	129	99	103	99
   query92	59	49	51	49
   query93	5004	523	515	515
   query94	823	217	215	215
   query95	404	317	319	317
   query96	618	274	273	273
   query97	3243	3013	3028	3013
   query98	221	207	193	193
   query99	1677	1284	1229	1229
   Total cold run time: 283201 ms
   Total hot run time: 173882 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227934538

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 40154 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c48d95ecf26ce11120717855482ec88eaa159c05, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	18059	4392	4364	4364
   q2	2888	215	195	195
   q3	11360	1192	1121	1121
   q4	10351	834	781	781
   q5	7923	2737	2790	2737
   q6	220	137	140	137
   q7	968	612	600	600
   q8	9560	2075	2063	2063
   q9	8713	6534	6550	6534
   q10	8695	3774	3765	3765
   q11	450	243	244	243
   q12	393	221	213	213
   q13	18808	2970	2990	2970
   q14	270	237	239	237
   q15	534	495	487	487
   q16	494	391	381	381
   q17	966	723	744	723
   q18	8013	7504	7469	7469
   q19	4973	1431	1308	1308
   q20	759	322	327	322
   q21	4996	3209	3213	3209
   q22	344	295	296	295
   Total cold run time: 119737 ms
   Total hot run time: 40154 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4399	4224	4231	4224
   q2	381	278	278	278
   q3	2980	2752	2806	2752
   q4	1916	1641	1606	1606
   q5	5315	5339	5302	5302
   q6	220	153	132	132
   q7	2152	1677	1758	1677
   q8	3182	3351	3282	3282
   q9	8437	8463	8381	8381
   q10	3865	3731	3650	3650
   q11	571	505	479	479
   q12	783	618	627	618
   q13	16552	2991	2988	2988
   q14	297	283	273	273
   q15	529	484	479	479
   q16	466	417	437	417
   q17	1777	1469	1482	1469
   q18	7642	7510	7320	7320
   q19	1721	1537	1550	1537
   q20	1983	1787	1780	1780
   q21	4894	4569	4633	4569
   q22	597	497	508	497
   Total cold run time: 70659 ms
   Total hot run time: 53710 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #37773:
URL: https://github.com/apache/doris/pull/37773#discussion_r1679279299


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreClientHelper.java:
##########
@@ -883,7 +883,7 @@ public static String firstPresentOrDefault(String defaultValue, Optional<String>
     public static String getByte(String altValue) {
         if (altValue != null && altValue.length() > 0) {
             try {
-                return Character.toString((char) (Byte.parseByte(altValue) + 256) % 256);
+                return String.valueOf((char) (Byte.parseByte(altValue) + 256) % 256);

Review Comment:
   ```suggestion
                   return Character.toString(((char) (Byte.parseByte(altValue) + 256) % 256));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2232233832

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 40575 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 8c112d62719c8052307fc87d5036ff1e9430a89e, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17800	4363	4280	4280
   q2	2010	191	190	190
   q3	10467	1209	1115	1115
   q4	10199	808	739	739
   q5	7546	2723	2781	2723
   q6	230	137	135	135
   q7	963	599	612	599
   q8	9377	2141	2071	2071
   q9	8889	6652	6597	6597
   q10	8864	3855	3814	3814
   q11	448	241	239	239
   q12	435	226	221	221
   q13	17979	3013	3100	3013
   q14	301	266	255	255
   q15	549	475	511	475
   q16	521	393	398	393
   q17	961	621	739	621
   q18	8539	7844	8002	7844
   q19	7808	1372	1477	1372
   q20	728	331	315	315
   q21	5208	3279	3325	3279
   q22	362	294	285	285
   Total cold run time: 120184 ms
   Total hot run time: 40575 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4578	4324	4261	4261
   q2	386	265	283	265
   q3	3190	2999	2891	2891
   q4	2041	1688	1638	1638
   q5	5599	5469	5595	5469
   q6	229	132	135	132
   q7	2269	1807	1851	1807
   q8	3258	3419	3394	3394
   q9	8737	8880	8698	8698
   q10	3986	3848	3821	3821
   q11	609	509	493	493
   q12	805	694	626	626
   q13	16138	3163	3151	3151
   q14	323	290	289	289
   q15	525	510	483	483
   q16	496	424	422	422
   q17	1791	1519	1523	1519
   q18	8157	7900	7829	7829
   q19	1775	1555	1533	1533
   q20	3491	1880	1858	1858
   q21	9699	4848	4908	4848
   q22	565	526	526	526
   Total cold run time: 78647 ms
   Total hot run time: 55953 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2230148240

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39557 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 20246ba9728261cf743a878ac2d75fb71cc6e8a0, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17612	4258	4251	4251
   q2	2011	192	182	182
   q3	10456	1156	1054	1054
   q4	10185	764	827	764
   q5	7597	2643	2630	2630
   q6	219	136	138	136
   q7	954	601	594	594
   q8	9225	2058	2034	2034
   q9	8848	6542	6532	6532
   q10	8824	3786	3790	3786
   q11	462	240	234	234
   q12	477	228	221	221
   q13	17762	2983	2959	2959
   q14	292	243	233	233
   q15	526	472	484	472
   q16	501	395	374	374
   q17	955	724	749	724
   q18	7999	7423	7277	7277
   q19	7430	1418	1322	1322
   q20	733	326	315	315
   q21	4829	3187	3268	3187
   q22	329	276	285	276
   Total cold run time: 118226 ms
   Total hot run time: 39557 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4360	4229	4279	4229
   q2	379	273	261	261
   q3	3001	2911	2856	2856
   q4	1999	1693	1727	1693
   q5	5587	5504	5459	5459
   q6	245	132	128	128
   q7	2176	1873	1838	1838
   q8	3273	3404	3422	3404
   q9	8780	8713	8858	8713
   q10	4075	3932	3700	3700
   q11	570	511	505	505
   q12	814	638	637	637
   q13	17307	3139	3150	3139
   q14	322	329	283	283
   q15	520	481	481	481
   q16	484	436	436	436
   q17	1805	1545	1495	1495
   q18	8152	7918	7865	7865
   q19	1694	1529	1744	1529
   q20	2075	1878	1864	1864
   q21	5098	4894	4819	4819
   q22	564	500	512	500
   Total cold run time: 73280 ms
   Total hot run time: 55834 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's grammar [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2241941601

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2230095624

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227602792

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2229861447

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2235158184

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2232181764

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #37773:
URL: https://github.com/apache/doris/pull/37773#discussion_r1680355280


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreClientHelper.java:
##########
@@ -883,7 +883,7 @@ public static String firstPresentOrDefault(String defaultValue, Optional<String>
     public static String getByte(String altValue) {
         if (altValue != null && altValue.length() > 0) {

Review Comment:
   "altValue.length() > 0"  => "!altValue.isEmpty()"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227818065

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2230095361

   run cloud_p1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2232251491

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2229908492

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.41 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 20246ba9728261cf743a878ac2d75fb71cc6e8a0, data reload: false
   
   query1	0.04	0.04	0.04
   query2	0.08	0.04	0.04
   query3	0.22	0.05	0.05
   query4	1.66	0.07	0.09
   query5	0.49	0.50	0.50
   query6	1.13	0.73	0.72
   query7	0.02	0.01	0.01
   query8	0.05	0.04	0.04
   query9	0.57	0.48	0.51
   query10	0.55	0.56	0.54
   query11	0.16	0.11	0.11
   query12	0.15	0.12	0.12
   query13	0.59	0.59	0.59
   query14	0.76	0.77	0.78
   query15	0.85	0.81	0.82
   query16	0.35	0.36	0.37
   query17	0.96	1.00	0.93
   query18	0.22	0.22	0.21
   query19	1.81	1.77	1.68
   query20	0.01	0.01	0.02
   query21	15.38	0.76	0.67
   query22	4.22	6.95	1.78
   query23	18.28	1.38	1.30
   query24	2.15	0.22	0.22
   query25	0.15	0.09	0.09
   query26	0.30	0.22	0.21
   query27	0.46	0.23	0.24
   query28	13.21	1.03	1.00
   query29	12.63	3.28	3.25
   query30	0.26	0.05	0.05
   query31	2.86	0.38	0.39
   query32	3.28	0.48	0.47
   query33	2.93	2.93	2.86
   query34	16.90	4.33	4.43
   query35	4.37	4.47	4.46
   query36	0.66	0.45	0.46
   query37	0.18	0.16	0.17
   query38	0.15	0.16	0.15
   query39	0.04	0.03	0.04
   query40	0.15	0.12	0.12
   query41	0.10	0.04	0.05
   query42	0.06	0.05	0.05
   query43	0.04	0.04	0.03
   Total cold run time: 109.43 s
   Total hot run time: 30.41 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2232321715

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 40104 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 8efa090c3ae23c6a2a2fe49ead6a30e1300d36a1, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	18226	4582	4416	4416
   q2	2853	200	191	191
   q3	11010	1199	1087	1087
   q4	10585	830	774	774
   q5	7863	2729	2734	2729
   q6	223	139	136	136
   q7	975	631	614	614
   q8	9333	2120	2097	2097
   q9	8853	6531	6525	6525
   q10	8761	3754	3831	3754
   q11	464	230	235	230
   q12	395	228	227	227
   q13	18789	2993	2976	2976
   q14	277	228	237	228
   q15	528	476	490	476
   q16	507	380	375	375
   q17	962	661	684	661
   q18	8054	7532	7487	7487
   q19	6802	1424	1366	1366
   q20	653	322	317	317
   q21	4873	3157	3317	3157
   q22	338	288	281	281
   Total cold run time: 121324 ms
   Total hot run time: 40104 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4430	4237	4283	4237
   q2	356	252	272	252
   q3	2996	2739	2759	2739
   q4	1875	1668	1631	1631
   q5	5292	5336	5283	5283
   q6	227	130	127	127
   q7	2088	1699	1757	1699
   q8	3205	3332	3308	3308
   q9	8449	8442	8451	8442
   q10	3928	3709	3675	3675
   q11	590	484	486	484
   q12	768	613	603	603
   q13	16632	3019	3029	3019
   q14	288	268	262	262
   q15	523	470	476	470
   q16	473	416	419	416
   q17	1778	1511	1463	1463
   q18	7610	7546	7235	7235
   q19	1646	1486	1523	1486
   q20	1987	1764	1781	1764
   q21	5021	4610	4666	4610
   q22	585	513	517	513
   Total cold run time: 70747 ms
   Total hot run time: 53718 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's grammar [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann closed pull request #37773: [fix](Nereids) Refactor character conversion to use Java 8's grammar
URL: https://github.com/apache/doris/pull/37773


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #37773:
URL: https://github.com/apache/doris/pull/37773#discussion_r1679279299


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreClientHelper.java:
##########
@@ -883,7 +883,7 @@ public static String firstPresentOrDefault(String defaultValue, Optional<String>
     public static String getByte(String altValue) {
         if (altValue != null && altValue.length() > 0) {
             try {
-                return Character.toString((char) (Byte.parseByte(altValue) + 256) % 256);
+                return String.valueOf((char) (Byte.parseByte(altValue) + 256) % 256);

Review Comment:
   ```suggestion
                   return Character.toString((char) ((Byte.parseByte(altValue) + 256) % 256));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2235230030

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 40022 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 137dcc891bcba71597e7b1383601649c81437065, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17609	4847	4260	4260
   q2	2017	191	189	189
   q3	10464	1219	1079	1079
   q4	10186	800	872	800
   q5	7548	2726	2685	2685
   q6	220	135	137	135
   q7	965	607	596	596
   q8	9228	2111	2085	2085
   q9	8814	6586	6558	6558
   q10	8817	3807	3831	3807
   q11	444	234	239	234
   q12	440	224	223	223
   q13	18854	2974	2977	2974
   q14	281	238	237	237
   q15	533	479	506	479
   q16	501	387	383	383
   q17	966	718	751	718
   q18	8225	7439	7562	7439
   q19	5895	1464	1382	1382
   q20	696	319	329	319
   q21	4983	3156	3318	3156
   q22	344	284	296	284
   Total cold run time: 118030 ms
   Total hot run time: 40022 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4436	4261	4341	4261
   q2	369	260	263	260
   q3	3017	2978	2977	2977
   q4	1947	1723	1773	1723
   q5	5601	5592	5506	5506
   q6	224	134	132	132
   q7	2247	1896	1834	1834
   q8	3276	3471	3413	3413
   q9	8766	8916	8875	8875
   q10	4184	3721	3936	3721
   q11	587	497	499	497
   q12	810	631	618	618
   q13	15885	3173	3219	3173
   q14	309	292	298	292
   q15	550	474	493	474
   q16	500	441	463	441
   q17	1827	1517	1505	1505
   q18	8060	8014	7865	7865
   q19	1817	1628	1436	1436
   q20	2116	1912	1879	1879
   q21	5096	4877	4626	4626
   q22	626	524	517	517
   Total cold run time: 72250 ms
   Total hot run time: 56025 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2235242170

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 174484 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 137dcc891bcba71597e7b1383601649c81437065, data reload: false
   
   query1	921	371	369	369
   query2	6463	1928	1819	1819
   query3	6659	205	214	205
   query4	27794	17604	17407	17407
   query5	3688	484	484	484
   query6	271	186	166	166
   query7	4589	294	277	277
   query8	245	180	201	180
   query9	8426	2455	2451	2451
   query10	437	298	276	276
   query11	12273	10106	10104	10104
   query12	124	92	90	90
   query13	1646	369	367	367
   query14	10614	7609	7440	7440
   query15	217	170	170	170
   query16	7634	324	316	316
   query17	1712	579	537	537
   query18	1678	289	286	286
   query19	207	154	154	154
   query20	90	83	83	83
   query21	221	125	126	125
   query22	4462	4300	3998	3998
   query23	34368	34045	33766	33766
   query24	11260	2993	2930	2930
   query25	616	410	489	410
   query26	708	148	146	146
   query27	2308	279	275	275
   query28	5995	2081	2068	2068
   query29	904	659	651	651
   query30	255	153	150	150
   query31	1000	764	779	764
   query32	99	52	56	52
   query33	748	331	315	315
   query34	937	504	517	504
   query35	706	623	627	623
   query36	1126	977	984	977
   query37	137	81	91	81
   query38	2912	2762	2792	2762
   query39	844	820	789	789
   query40	203	122	117	117
   query41	44	40	41	40
   query42	120	100	102	100
   query43	524	469	478	469
   query44	1189	738	740	738
   query45	197	167	165	165
   query46	1086	745	738	738
   query47	1839	1817	1793	1793
   query48	360	289	302	289
   query49	829	412	421	412
   query50	779	388	393	388
   query51	6837	6804	6847	6804
   query52	102	100	91	91
   query53	354	293	291	291
   query54	930	458	453	453
   query55	76	72	74	72
   query56	298	272	268	268
   query57	1132	1061	1094	1061
   query58	260	244	265	244
   query59	2961	2735	2650	2650
   query60	309	289	288	288
   query61	101	93	96	93
   query62	779	658	660	658
   query63	325	296	285	285
   query64	9626	2220	7467	2220
   query65	3135	3094	3100	3094
   query66	760	339	337	337
   query67	15582	15115	15077	15077
   query68	4828	536	529	529
   query69	726	453	355	355
   query70	1209	1109	1092	1092
   query71	446	273	281	273
   query72	8087	5351	5807	5351
   query73	754	319	320	319
   query74	6210	5732	5724	5724
   query75	3528	2676	2704	2676
   query76	3313	961	933	933
   query77	697	306	317	306
   query78	11878	9583	8931	8931
   query79	7829	519	528	519
   query80	1242	509	491	491
   query81	600	221	217	217
   query82	668	137	136	136
   query83	354	173	166	166
   query84	278	85	87	85
   query85	711	363	304	304
   query86	446	328	310	310
   query87	3359	3169	3105	3105
   query88	4680	2375	2385	2375
   query89	481	382	379	379
   query90	1962	197	194	194
   query91	132	102	102	102
   query92	64	50	55	50
   query93	4624	503	493	493
   query94	1211	216	209	209
   query95	407	320	319	319
   query96	627	279	279	279
   query97	3172	3040	3012	3012
   query98	215	200	198	198
   query99	1525	1250	1288	1250
   Total cold run time: 292294 ms
   Total hot run time: 174484 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227640784

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39967 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit f073a852595f1cb44c4b22637bb65e35c5590314, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	18110	4516	4299	4299
   q2	2024	187	187	187
   q3	10546	1140	1183	1140
   q4	10245	820	868	820
   q5	7587	2695	2688	2688
   q6	223	141	139	139
   q7	967	600	593	593
   q8	9216	2074	2106	2074
   q9	8756	6597	6565	6565
   q10	8734	3759	3781	3759
   q11	520	235	238	235
   q12	403	232	232	232
   q13	17770	3018	2987	2987
   q14	285	231	244	231
   q15	515	487	496	487
   q16	500	384	387	384
   q17	976	642	700	642
   q18	8164	7621	7482	7482
   q19	5145	1459	1283	1283
   q20	713	324	316	316
   q21	4908	3139	3198	3139
   q22	357	286	285	285
   Total cold run time: 116664 ms
   Total hot run time: 39967 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4371	4266	4254	4254
   q2	376	269	285	269
   q3	2957	2917	2917	2917
   q4	2038	1661	1631	1631
   q5	5751	5581	5529	5529
   q6	227	133	136	133
   q7	2233	1902	1848	1848
   q8	3259	3383	3448	3383
   q9	8799	8694	8968	8694
   q10	4086	3929	3799	3799
   q11	601	526	497	497
   q12	825	633	614	614
   q13	16411	3166	3206	3166
   q14	325	302	289	289
   q15	526	485	484	484
   q16	496	450	455	450
   q17	1820	1509	1511	1509
   q18	8159	8219	7851	7851
   q19	1775	1551	1636	1551
   q20	2159	1846	1870	1846
   q21	5037	4854	4730	4730
   q22	584	544	553	544
   Total cold run time: 72815 ms
   Total hot run time: 55988 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227650995

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.33 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit f073a852595f1cb44c4b22637bb65e35c5590314, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.07	0.04	0.04
   query3	0.23	0.05	0.04
   query4	1.68	0.07	0.07
   query5	0.54	0.50	0.49
   query6	1.13	0.73	0.73
   query7	0.02	0.01	0.02
   query8	0.07	0.05	0.05
   query9	0.55	0.50	0.48
   query10	0.54	0.54	0.54
   query11	0.15	0.11	0.11
   query12	0.14	0.12	0.13
   query13	0.59	0.59	0.59
   query14	0.77	0.77	0.77
   query15	0.85	0.82	0.82
   query16	0.37	0.39	0.37
   query17	1.01	1.05	1.03
   query18	0.22	0.21	0.22
   query19	1.82	1.84	1.80
   query20	0.01	0.01	0.01
   query21	15.40	0.73	0.65
   query22	4.32	6.41	2.51
   query23	18.28	1.48	1.21
   query24	2.16	0.22	0.23
   query25	0.16	0.09	0.09
   query26	0.29	0.21	0.20
   query27	0.45	0.23	0.23
   query28	13.20	1.03	1.00
   query29	12.63	3.31	3.33
   query30	0.25	0.06	0.07
   query31	2.86	0.39	0.39
   query32	3.25	0.49	0.48
   query33	2.94	2.95	2.89
   query34	16.86	4.33	4.36
   query35	4.42	4.41	4.40
   query36	0.65	0.47	0.48
   query37	0.19	0.16	0.16
   query38	0.16	0.15	0.14
   query39	0.04	0.04	0.04
   query40	0.16	0.13	0.13
   query41	0.09	0.04	0.05
   query42	0.05	0.04	0.06
   query43	0.04	0.03	0.04
   Total cold run time: 109.65 s
   Total hot run time: 31.33 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227895949

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2236405239

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2232251289

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.58 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 8c112d62719c8052307fc87d5036ff1e9430a89e, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.08	0.04	0.05
   query3	0.22	0.05	0.05
   query4	1.68	0.08	0.08
   query5	0.50	0.48	0.50
   query6	1.13	0.72	0.72
   query7	0.02	0.01	0.02
   query8	0.05	0.04	0.05
   query9	0.56	0.48	0.48
   query10	0.54	0.54	0.54
   query11	0.15	0.10	0.11
   query12	0.15	0.13	0.12
   query13	0.59	0.59	0.58
   query14	0.76	0.78	0.77
   query15	0.84	0.81	0.82
   query16	0.37	0.37	0.37
   query17	1.03	0.99	1.00
   query18	0.23	0.23	0.23
   query19	1.91	1.82	1.75
   query20	0.01	0.01	0.01
   query21	15.39	0.75	0.67
   query22	4.51	7.03	1.79
   query23	18.32	1.43	1.33
   query24	2.17	0.23	0.21
   query25	0.14	0.09	0.10
   query26	0.30	0.20	0.20
   query27	0.45	0.23	0.23
   query28	13.21	1.01	1.01
   query29	12.63	3.34	3.28
   query30	0.25	0.06	0.06
   query31	2.88	0.38	0.40
   query32	3.28	0.48	0.46
   query33	2.89	2.91	2.91
   query34	16.85	4.31	4.34
   query35	4.39	4.39	4.44
   query36	0.65	0.48	0.52
   query37	0.19	0.15	0.16
   query38	0.16	0.16	0.14
   query39	0.05	0.04	0.04
   query40	0.16	0.12	0.13
   query41	0.10	0.04	0.05
   query42	0.06	0.05	0.05
   query43	0.04	0.04	0.04
   Total cold run time: 109.93 s
   Total hot run time: 30.58 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2232297793

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227963619

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.8 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit c48d95ecf26ce11120717855482ec88eaa159c05, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.08	0.04	0.04
   query3	0.24	0.05	0.05
   query4	1.68	0.06	0.06
   query5	0.50	0.52	0.49
   query6	1.14	0.72	0.74
   query7	0.02	0.02	0.02
   query8	0.05	0.04	0.04
   query9	0.55	0.50	0.49
   query10	0.56	0.55	0.54
   query11	0.14	0.11	0.11
   query12	0.15	0.12	0.12
   query13	0.59	0.59	0.58
   query14	0.76	0.78	0.78
   query15	0.85	0.83	0.82
   query16	0.36	0.38	0.37
   query17	1.00	1.02	1.04
   query18	0.22	0.21	0.22
   query19	1.88	1.74	1.75
   query20	0.01	0.01	0.02
   query21	15.39	0.75	0.65
   query22	4.44	7.39	2.00
   query23	18.27	1.38	1.24
   query24	2.12	0.22	0.23
   query25	0.16	0.09	0.08
   query26	0.30	0.20	0.22
   query27	0.47	0.23	0.22
   query28	13.27	1.02	0.98
   query29	12.94	3.31	3.29
   query30	0.27	0.05	0.05
   query31	2.87	0.38	0.38
   query32	3.30	0.48	0.47
   query33	2.91	2.91	2.91
   query34	17.14	4.40	4.36
   query35	4.37	4.45	4.47
   query36	0.65	0.48	0.48
   query37	0.18	0.16	0.15
   query38	0.15	0.15	0.14
   query39	0.05	0.03	0.04
   query40	0.16	0.13	0.12
   query41	0.09	0.05	0.05
   query42	0.06	0.05	0.05
   query43	0.04	0.04	0.04
   Total cold run time: 110.42 s
   Total hot run time: 30.8 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227647701

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 172980 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit f073a852595f1cb44c4b22637bb65e35c5590314, data reload: false
   
   query1	928	377	362	362
   query2	6449	1871	1833	1833
   query3	6632	208	215	208
   query4	27181	17753	17330	17330
   query5	3722	495	478	478
   query6	264	162	183	162
   query7	4577	294	296	294
   query8	241	191	192	191
   query9	8399	2382	2360	2360
   query10	446	278	282	278
   query11	11864	10054	10146	10054
   query12	116	81	90	81
   query13	1646	370	375	370
   query14	10243	7041	7604	7041
   query15	220	167	174	167
   query16	7604	320	322	320
   query17	1350	556	552	552
   query18	1813	291	287	287
   query19	193	158	155	155
   query20	91	84	82	82
   query21	208	135	127	127
   query22	4457	4014	3994	3994
   query23	34279	33884	33551	33551
   query24	11038	3035	2959	2959
   query25	616	491	386	386
   query26	720	159	154	154
   query27	2313	277	275	275
   query28	6019	2044	2045	2044
   query29	925	652	635	635
   query30	243	161	155	155
   query31	954	765	762	762
   query32	96	54	56	54
   query33	656	299	307	299
   query34	875	506	504	504
   query35	698	597	606	597
   query36	1134	977	976	976
   query37	143	90	89	89
   query38	2946	2885	2922	2885
   query39	865	821	827	821
   query40	199	120	117	117
   query41	47	45	44	44
   query42	117	98	96	96
   query43	491	472	453	453
   query44	1104	724	745	724
   query45	195	163	163	163
   query46	1091	719	685	685
   query47	1867	1790	1756	1756
   query48	370	292	284	284
   query49	818	403	415	403
   query50	774	394	397	394
   query51	6946	6793	6797	6793
   query52	104	100	94	94
   query53	358	293	297	293
   query54	906	449	453	449
   query55	78	73	76	73
   query56	286	261	270	261
   query57	1112	1060	1065	1060
   query58	251	246	260	246
   query59	2815	2586	2648	2586
   query60	302	281	287	281
   query61	94	93	96	93
   query62	788	668	641	641
   query63	319	289	289	289
   query64	9136	2231	1689	1689
   query65	3171	3127	3106	3106
   query66	745	322	337	322
   query67	15535	15024	14849	14849
   query68	5133	541	538	538
   query69	632	488	375	375
   query70	1197	1053	1154	1053
   query71	442	281	281	281
   query72	7338	5493	5690	5493
   query73	778	328	321	321
   query74	6155	5698	5785	5698
   query75	3528	2689	2719	2689
   query76	3058	961	889	889
   query77	614	308	310	308
   query78	10076	8994	8933	8933
   query79	2726	511	525	511
   query80	2963	484	471	471
   query81	593	221	219	219
   query82	1427	139	137	137
   query83	313	167	165	165
   query84	275	94	88	88
   query85	1535	325	359	325
   query86	469	310	329	310
   query87	3313	3124	3134	3124
   query88	4138	2464	2458	2458
   query89	476	379	401	379
   query90	1914	194	188	188
   query91	132	98	101	98
   query92	60	48	49	48
   query93	2486	496	501	496
   query94	1213	212	219	212
   query95	404	321	315	315
   query96	602	286	275	275
   query97	3280	3048	3032	3032
   query98	216	204	196	196
   query99	1619	1239	1271	1239
   Total cold run time: 282288 ms
   Total hot run time: 172980 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2228060436

   run external


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227602664

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2227818017

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids) Refactor character conversion to use Java 8's String.valueOf() [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #37773:
URL: https://github.com/apache/doris/pull/37773#issuecomment-2235148693

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org