You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/04 00:30:13 UTC
[jira] [Commented] (KAFKA-3632) ConsumerLag metrics persist after
partition migration
[ https://issues.apache.org/jira/browse/KAFKA-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269739#comment-15269739 ]
ASF GitHub Bot commented on KAFKA-3632:
---------------------------------------
GitHub user hachikuji opened a pull request:
https://github.com/apache/kafka/pull/1312
KAFKA-3632: remove fetcher metrics on shutdown and leader migration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hachikuji/kafka KAFKA-3632
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1312
----
commit d95c9df222a16b6e69df5038959624f5512a24d9
Author: Jason Gustafson <ja...@confluent.io>
Date: 2016-04-28T16:50:44Z
KAFKA-3632: remove fetcher metrics on shutdown and leader migration
----
> ConsumerLag metrics persist after partition migration
> -----------------------------------------------------
>
> Key: KAFKA-3632
> URL: https://issues.apache.org/jira/browse/KAFKA-3632
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.2.2, 0.9.0.1
> Environment: JDK 1.8, Linux
> Reporter: Brian Lueck
> Priority: Minor
>
> When a partition is migrated away from a broker, the ConsumerLag metric for the topic/partition gets 'stuck' at the current value. The only way to remove the metric is to restart the broker.
> This appears to be because in AbstractFetcherThread.scala there is no way of removing a metric. See...
> {code}
> class FetcherLagStats(metricId: ClientIdAndBroker) {
> private val valueFactory = (k: ClientIdTopicPartition) => new FetcherLagMetrics(k)
> val stats = new Pool[ClientIdTopicPartition, FetcherLagMetrics](Some(valueFactory))
> def getFetcherLagStats(topic: String, partitionId: Int): FetcherLagMetrics = {
> stats.getAndMaybePut(new ClientIdTopicPartition(metricId.clientId, topic, partitionId))
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)