You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/21 17:11:52 UTC
[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1432: HDDS-4252. Add the current layout versions to DN - SCM proto payload.
avijayanhwx commented on a change in pull request #1432:
URL: https://github.com/apache/hadoop-ozone/pull/1432#discussion_r492210006
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/DataNodeStorageConfig.java
##########
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.container.common;
+
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.hdds.protocol.proto.HddsProtos.NodeType;
+import org.apache.hadoop.ozone.common.Storage;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Properties;
+
+import static org.apache.hadoop.hdds.server.ServerUtils.getOzoneMetaDirPath;
+import static org.apache.hadoop.ozone.OzoneConsts.DATANODE_STORAGE_CONFIG;
+
+/**
+ * DataNodeStorageConfig is responsible for management of the
+ * StorageDirectories used by the DataNode.
+ */
+public class DataNodeStorageConfig extends Storage {
Review comment:
There is already a Datanode Version file managed by the org.apache.hadoop.ozone.container.common.helpers.DatanodeVersionFile class. This is supposed to manage the clusterId, Datanode ID, layout version etc. If we create a new class to be passed into the Layout Version Manager, then we end up creating 2 Version files on disk for DN.
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/DataNodeStorageConfig.java
##########
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.container.common;
+
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.hdds.protocol.proto.HddsProtos.NodeType;
+import org.apache.hadoop.ozone.common.Storage;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Properties;
+
+import static org.apache.hadoop.hdds.server.ServerUtils.getOzoneMetaDirPath;
+import static org.apache.hadoop.ozone.OzoneConsts.DATANODE_STORAGE_CONFIG;
+
+/**
+ * DataNodeStorageConfig is responsible for management of the
+ * StorageDirectories used by the DataNode.
+ */
+public class DataNodeStorageConfig extends Storage {
+
+ /**
+ * Construct DataNodeStorageConfig.
+ * @throws IOException if any directories are inaccessible.
+ */
+ public DataNodeStorageConfig(OzoneConfiguration conf) throws IOException {
+ super(NodeType.DATANODE, getOzoneMetaDirPath(conf),
+ DATANODE_STORAGE_CONFIG);
+ }
+
+ public DataNodeStorageConfig(NodeType type, File root, String sdName)
+ throws IOException {
+ super(type, root, sdName);
+ }
+
+ @Override
+ protected Properties getNodeProperties() {
+ // No additional properties for now.
+ return null;
Review comment:
Nit. Can we return empty list here?
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/StorageContainerDatanodeProtocol.java
##########
@@ -84,4 +86,19 @@ SCMRegisteredResponseProto register(
ContainerReportsProto containerReportsRequestProto,
PipelineReportsProto pipelineReports) throws IOException;
+ /**
+ * Register Datanode.
+ * @param datanodeDetails - Datanode Details.
+ * @param nodeReport - Node Report.
+ * @param containerReportsRequestProto - Container Reports.
+ * @param layoutInfo - Layout Version Information.
+ * @return SCM Command.
+ */
+ SCMRegisteredResponseProto register(
Review comment:
Why do we need to create a new 'register' method with Layout Version arg, without changing the existing method? We would always need a Layout Version during registering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org