[jira] [Commented] (TEZ-866) Add a TezMergedInputContext for MergedInputs

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069034#comment-14069034 ] 

Siddharth Seth commented on TEZ-866:
------------------------------------

Looks good. I think it's worth adding at least some of the methods from the regular InputContext into TezGroupedInputContext - specifically - getCounters, fatalError. Can be added in a follow up though.

Post TEZ-857, it should be possible to simplify MergedLogicalInput to not extend TezInputFrameworkInteface - which removes all the "UnsupportedOperationException" errors.

Another bit to look at - we end up with two initialize methods - one accepting a user payload, the other just doing an initialize(). That can get confusing. Also - leads to a visibility race (for which there's a jira already open). Need to consolidate these down. Potentially replace initialize with a constructor which accepts a Context instance (instead of the explicit initialize method).

> Add a TezMergedInputContext for MergedInputs
> --------------------------------------------
>
>                 Key: TEZ-866
>                 URL: https://issues.apache.org/jira/browse/TEZ-866
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Bikas Saha
>         Attachments: TEZ-866.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)