Patch for ByteArraydataSource class was Patch for Email class

[Colin Chalmers <co...@maxware.nl>]

Hi Daniele,

Thanx for checking in the Email class. This is the patch for the
ByteArrayDataSource that I sent with an explanation of the changes.

Could you (or any other commiters) check it in please.

/Colin


> Here is a patch for the ByteArraydatasource with an explanation why I
> changed data[] to a ByteArrayOutputStream
>
> <snip>
> I was trying to accomplish two things here:
>
> 1.
> In the original file data[] was used for holding the data.There was a
> getOuputStream method returning a dummy outputstream (because it probably
> couldn't get linked up to the data[]) whereas it should have returned a
> stream to which you can write (to). Furthermore after parsing the
> InputStream the Ouptutstream used  was being converted to a byte[]. By
> replacing data[] with an outputstream these issues were solved/simplified.
>
> 2.
> In order to reuse code (I like writing things only once :-) ) I made a
> private method which can be used whether you access the class via a byte[]
> OR an InputStream.
> </snip>
>
> /Colin





> "Colin Chalmers" <co...@maxware.nl> writes:
>
> > A couple of small changes
> >
> > 1. Corrected the " Disposition-Notification-To: user@domain.net" example
> > identified yesterday.
> > 2. There was a global session that was not being used.
> > 3. Changed the setting of debug info for the correct session and not the
> > global which was therafter redundant.
>
> Hi Colin.  Patch checked in, thanks.
>
> > Could someone check this in for me please. Also was there any reason why
the
> > patch for ByteArrayDataSource that I sent yesterday could not be checked
in?
>
> I misplaced this one, someone else will have to get it.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>
>

Re: Patch for ByteArraydataSource class was Patch for Email class

[Daniel Rall <dl...@finemaltcoding.com>]

"Colin Chalmers" <co...@maxware.nl> writes:

> Hi Daniele,
> 
> Thanx for checking in the Email class. This is the patch for the
> ByteArrayDataSource that I sent with an explanation of the changes.
> 
> Could you (or any other commiters) check it in please.

Checked in.

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org