[jira] [Commented] (OPENNLP-1033) Add unit tests for missing coverage in the opennlp.tools.ngram package

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974961#comment-15974961 ] 

ASF GitHub Bot commented on OPENNLP-1033:
-----------------------------------------

GitHub user jzonthemtn opened a pull request:

    https://github.com/apache/opennlp/pull/172

    OPENNLP-1033: Adds unit tests for opennlp.tools.ngram.

    Thank you for contributing to Apache OpenNLP.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jzonthemtn/opennlp OPENNLP-1033

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #172
    
----
commit ed439b1bad2e6246e2a570b171a0df986ac8fd0c
Author: jzonthemtn <je...@mtnfog.com>
Date:   2017-04-19T15:55:45Z

    OPENNLP-1033: Adds unit tests for opennlp.tools.ngram.

----


> Add unit tests for missing coverage in the opennlp.tools.ngram package
> ----------------------------------------------------------------------
>
>                 Key: OPENNLP-1033
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1033
>             Project: OpenNLP
>          Issue Type: Test
>          Components: Build, Packaging and Test
>            Reporter: Jeff Zemerick
>            Assignee: Jeff Zemerick
>              Labels: test
>
> Add unit tests for missing coverage in the opennlp.tools.ngram package.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)