You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/08/09 08:37:12 UTC

[GitHub] [servicecomb-service-center] codecov-io commented on issue #571: [SCB-1429] Abstract storage operation

codecov-io commented on issue #571: [SCB-1429] Abstract storage operation
URL: https://github.com/apache/servicecomb-service-center/pull/571#issuecomment-519833781
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/571?src=pr&el=h1) Report
   > Merging [#571](https://codecov.io/gh/apache/servicecomb-service-center/pull/571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/eb503d084f90c1bee4f99544b87b7fba56c2a378?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/571/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/571?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #571      +/-   ##
   ==========================================
   - Coverage   58.32%   58.32%   -0.01%     
   ==========================================
     Files         201      201              
     Lines       15452    15452              
   ==========================================
   - Hits         9013     9012       -1     
   - Misses       5800     5801       +1     
     Partials      639      639
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/571?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/571/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `97.36% <0%> (-2.64%)` | :arrow_down: |
   | [server/notify/stream.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/571/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9zdHJlYW0uZ28=) | `71.05% <0%> (-2.64%)` | :arrow_down: |
   | [server/service/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/571/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `70.57% <0%> (-0.16%)` | :arrow_down: |
   | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/571/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
   | [syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/571/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv) | `57.14% <0%> (+2.85%)` | :arrow_up: |
   | [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/571/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `67.74% <0%> (+3.22%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/571?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/571?src=pr&el=footer). Last update [eb503d0...78c431e](https://codecov.io/gh/apache/servicecomb-service-center/pull/571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services