You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "rkhachatryan (via GitHub)" <gi...@apache.org> on 2025/10/22 19:38:09 UTC

[PR] [FLINK-35556] Fix constant in RocksDBSharedResourcesFactory [flink]

rkhachatryan opened a new pull request, #27138:
URL: https://github.com/apache/flink/pull/27138

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35556] Fix constant in RocksDBSharedResourcesFactory [flink]

Posted by "rkhachatryan (via GitHub)" <gi...@apache.org>.
rkhachatryan merged PR #27138:
URL: https://github.com/apache/flink/pull/27138


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35556] Fix constant in RocksDBSharedResourcesFactory [flink]

Posted by "rkhachatryan (via GitHub)" <gi...@apache.org>.
rkhachatryan commented on PR #27138:
URL: https://github.com/apache/flink/pull/27138#issuecomment-3441811260

   Thanks for the review!
   Merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35556] Fix constant in RocksDBSharedResourcesFactory [flink]

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #27138:
URL: https://github.com/apache/flink/pull/27138#discussion_r2459268942


##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +37,7 @@
  */
 enum RocksDBSharedResourcesFactory {
     /** Memory allocated per Slot (shared across slot tasks), managed by Flink. */
-    SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+    SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {

Review Comment:
   Is it a existing bug?
   
   I checked related code, it only affects log, is my understanding correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35556] Fix constant in RocksDBSharedResourcesFactory [flink]

Posted by "rkhachatryan (via GitHub)" <gi...@apache.org>.
rkhachatryan commented on code in PR #27138:
URL: https://github.com/apache/flink/pull/27138#discussion_r2459315168


##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +37,7 @@
  */
 enum RocksDBSharedResourcesFactory {
     /** Memory allocated per Slot (shared across slot tasks), managed by Flink. */
-    SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+    SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {

Review Comment:
   Yes, this is an existing bug.
   It also defines the resource ID that is used to acquire the resource / managed memory.
   In case when a TM is running jobs configured with different memory  allocation types, the returned value might be incorrect.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35556] Fix constant in RocksDBSharedResourcesFactory [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27138:
URL: https://github.com/apache/flink/pull/27138#issuecomment-3433970396

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "31e83d3c024ecbe06faf549009b22b0232d7de6c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "31e83d3c024ecbe06faf549009b22b0232d7de6c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 31e83d3c024ecbe06faf549009b22b0232d7de6c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org