You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by jg...@apache.org on 2017/06/13 17:45:24 UTC

kafka git commit: HOTFIX: Fix invalid long format conversion in request logger message

Repository: kafka
Updated Branches:
  refs/heads/trunk 136b03868 -> 85b7c855b


HOTFIX: Fix invalid long format conversion in request logger message

Author: Jason Gustafson <ja...@confluent.io>

Reviewers: Guozhang Wang <wa...@gmail.com>

Closes #3318 from hachikuji/hotfix-request-metric-udpate


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/85b7c855
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/85b7c855
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/85b7c855

Branch: refs/heads/trunk
Commit: 85b7c855bdf88994712d6b6683c9ab69bfa437a9
Parents: 136b038
Author: Jason Gustafson <ja...@confluent.io>
Authored: Tue Jun 13 10:45:14 2017 -0700
Committer: Jason Gustafson <ja...@confluent.io>
Committed: Tue Jun 13 10:45:14 2017 -0700

----------------------------------------------------------------------
 core/src/main/scala/kafka/network/RequestChannel.scala | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/85b7c855/core/src/main/scala/kafka/network/RequestChannel.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/network/RequestChannel.scala b/core/src/main/scala/kafka/network/RequestChannel.scala
index aff1526..bd71340 100644
--- a/core/src/main/scala/kafka/network/RequestChannel.scala
+++ b/core/src/main/scala/kafka/network/RequestChannel.scala
@@ -187,10 +187,11 @@ object RequestChannel extends Logging {
         val requestQueueTimeMs = nanosToMs(requestDequeueTimeNanos - startTimeNanos)
         val apiLocalTimeMs = nanosToMs(apiLocalCompleteTimeNanos - requestDequeueTimeNanos)
         val apiRemoteTimeMs = nanosToMs(apiRemoteCompleteTimeNanos - apiLocalCompleteTimeNanos)
+        val apiThrottleTimeMs = nanosToMs(responseCompleteTimeNanos - apiRemoteCompleteTimeNanos)
         val responseQueueTimeMs = nanosToMs(responseDequeueTimeNanos - responseCompleteTimeNanos)
         val responseSendTimeMs = nanosToMs(endTimeNanos - responseDequeueTimeNanos)
         requestLogger.trace("Completed request:%s from connection %s;totalTime:%f,requestQueueTime:%f,localTime:%f,remoteTime:%f,throttleTime:%f,responseQueueTime:%f,sendTime:%f,securityProtocol:%s,principal:%s,listener:%s"
-          .format(requestDesc(detailsEnabled), connectionId, totalTimeMs, requestQueueTimeMs, apiLocalTimeMs, apiRemoteTimeMs, apiThrottleTime, responseQueueTimeMs, responseSendTimeMs, securityProtocol, session.principal, listenerName.value))
+          .format(requestDesc(detailsEnabled), connectionId, totalTimeMs, requestQueueTimeMs, apiLocalTimeMs, apiRemoteTimeMs, apiThrottleTimeMs, responseQueueTimeMs, responseSendTimeMs, securityProtocol, session.principal, listenerName.value))
       }
     }
   }