[GitHub] [hive] kasakrisz commented on a change in pull request #2231: HIVE-25071: Number of reducers limited to fixed 1 when updating/deleting

[GitBox <gi...@apache.org>]

kasakrisz commented on a change in pull request #2231:
URL: https://github.com/apache/hive/pull/2231#discussion_r627950752



##########
File path: ql/src/test/results/clientpositive/llap/acid_no_buckets.q.out
##########
@@ -810,18 +810,18 @@ STAGE PLANS:
                       Statistics: Num rows: 500 Data size: 265500 Basic stats: COMPLETE Column stats: PARTIAL
                       Reduce Output Operator
                         key expressions: _col0 (type: struct<writeid:bigint,bucketid:int,rowid:bigint>)
-                        null sort order: z
+                        null sort order: a

Review comment:
       Null order is not depending the setting `hive.default.nulls.last`:
   https://github.com/apache/hive/blob/02be85202eb46f7207ce2925b361425d87638973/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java#L6936
   
   I tried to tackle this in #2227 but I experienced some regression in SMB joins: result set mismatch because rows with nulls introduced.
   
   Let me check how was this handled prior this patch: I think the null order came from the parent RS (which introduce the sort by ROWID) not the child (enforce bucketing + sort by ROWID).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org