You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Vincent Siveton <vi...@gmail.com> on 2009/08/02 12:34:22 UTC

Re: svn commit: r799840 - in /maven/plugins/trunk/maven-linkcheck-plugin: pom.xml src/main/java/org/apache/maven/plugins/linkcheck/LinkcheckReport.java

Hi Benjamin,

2009/8/1 Benjamin Bentmann <be...@udo.edu>:
> Keep in mind that the JVM might be running much longer than the Maven build,
> e.g. when Maven is embedded in an IDE or CI server. Therefore I suggest to
> delete the temp file not via a shutdown hook but explicitly once the mojo is
> done with it (e.g. when the invoker returned).
>
> Last but not least, if the user happens to maintain a "tmppom.xml" by
> himself in the project base directory, the plugin will overwrite it. Yes,
> it's an unlikely case but using FileUtils.createTempFile() from plexus-utils
> should easily ensure we're better safe than sorry.

Good points! I will fix it.

Thanks!

Vincent

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org