You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2015/01/30 02:03:40 UTC
Review Request 30435: SENTRY-628: Add ZK based Sentry cache sync
framework
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30435/
-----------------------------------------------------------
Review request for sentry, Xiaomeng Huang and Arun Suresh.
Bugs: SENTRY-628
https://issues.apache.org/jira/browse/SENTRY-628
Repository: sentry
Description
-------
Add Cuorator based framework to post Sentry cache updates to ZK in order to sync caches for all Sentry nodes. This is the first part of the feature
Diffs
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java 9308dee
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/Updateable.java ba932ac
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java 03b288b
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java c362115
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java f1e792d
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarder.java f321d3d
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarderWithHA.java PRE-CREATION
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateablePermissions.java 6b3e2e2
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestHAUpdateForwarder.java PRE-CREATION
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestUpdateForwarder.java 0c55bb1
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java 523261e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java ddc5930
Diff: https://reviews.apache.org/r/30435/diff/
Testing
-------
Added new unit test that test Curator PathCache framework to post and retrieve cache updates.
Thanks,
Prasad Mujumdar
Re: Review Request 30435: SENTRY-628: Add ZK based Sentry cache sync
framework
Posted by Xiaomeng Huang <xi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30435/#review70310
-----------------------------------------------------------
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/Updateable.java
<https://reviews.apache.org/r/30435/#comment115402>
extra blank space
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarder.java
<https://reviews.apache.org/r/30435/#comment115403>
Remove this TODO
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarderWithHA.java
<https://reviews.apache.org/r/30435/#comment115406>
I think we don't need "implements Updateable<K>"
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarderWithHA.java
<https://reviews.apache.org/r/30435/#comment115414>
Just curious when foundSeq be true?
1. create a patch watcher to listen zkPath change.
2. update zkPath in handleUpdateNotification.
3. when zkPath change, add data to updateLog.
We have somewhere else to add updateLog?
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarderWithHA.java
<https://reviews.apache.org/r/30435/#comment115410>
change "not found" to "has found" ?
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarderWithHA.java
<https://reviews.apache.org/r/30435/#comment115405>
extra blank space, aligning
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarderWithHA.java
<https://reviews.apache.org/r/30435/#comment115407>
We just post seqNum to ZK?
Hi, Prasad, I am not very familiar with sentry hdfs plugin, but I also left some comments. One question: this patch is just for hdfs plugin? Do you think if we can follow this step to do sentry local cache?
- Xiaomeng Huang
On 一月 30, 2015, 1:03 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30435/
> -----------------------------------------------------------
>
> (Updated 一月 30, 2015, 1:03 a.m.)
>
>
> Review request for sentry, Xiaomeng Huang and Arun Suresh.
>
>
> Bugs: SENTRY-628
> https://issues.apache.org/jira/browse/SENTRY-628
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add Cuorator based framework to post Sentry cache updates to ZK in order to sync caches for all Sentry nodes. This is the first part of the feature
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java 9308dee
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/Updateable.java ba932ac
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java 03b288b
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java c362115
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java f1e792d
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarder.java f321d3d
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarderWithHA.java PRE-CREATION
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateablePermissions.java 6b3e2e2
> sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestHAUpdateForwarder.java PRE-CREATION
> sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestUpdateForwarder.java 0c55bb1
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java 523261e
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java ddc5930
>
> Diff: https://reviews.apache.org/r/30435/diff/
>
>
> Testing
> -------
>
> Added new unit test that test Curator PathCache framework to post and retrieve cache updates.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>