You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/07/04 01:22:24 UTC
[GitHub] [thrift] dugenkui03 opened a new pull request #2194: remove unused import
dugenkui03 opened a new pull request #2194:
URL: https://github.com/apache/thrift/pull/2194
remove unused import in `TBase`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] ctubbsii commented on pull request #2194: remove unused import
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2194:
URL: https://github.com/apache/thrift/pull/2194#issuecomment-655085493
FWIW, the [impsort-maven-plugin](https://code.revelc.net/impsort-maven-plugin/) is great for sorting imports, and removing unused ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2194: remove unused import
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2194:
URL: https://github.com/apache/thrift/pull/2194#issuecomment-669021302
Why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] dugenkui03 closed pull request #2194: remove unused import
Posted by GitBox <gi...@apache.org>.
dugenkui03 closed pull request #2194:
URL: https://github.com/apache/thrift/pull/2194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2194: remove unused import
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2194:
URL: https://github.com/apache/thrift/pull/2194#issuecomment-669021302
.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] dugenkui03 commented on pull request #2194: remove unused import
Posted by GitBox <gi...@apache.org>.
dugenkui03 commented on pull request #2194:
URL: https://github.com/apache/thrift/pull/2194#issuecomment-656699314
> FWIW, the [impsort-maven-plugin](https://code.revelc.net/impsort-maven-plugin/) is great for sorting imports, and removing unused ones.
yes, convenient tool. I just think that the source code will more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org